From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 1/2] Add conversions to and from struct timespec to module interface. Date: Tue, 23 Apr 2019 08:16:07 -0700 Organization: UCLA Computer Science Department Message-ID: <329aec43-8272-f39a-e7ef-e77804103a50@cs.ucla.edu> References: <20190423131742.65814-1-phst@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="5142"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 Cc: Philipp Stephani To: Philipp Stephani , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 23 17:17:03 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hIxAK-0001AU-VL for ged-emacs-devel@m.gmane.org; Tue, 23 Apr 2019 17:17:01 +0200 Original-Received: from localhost ([127.0.0.1]:55272 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIxAJ-0003zq-Tt for ged-emacs-devel@m.gmane.org; Tue, 23 Apr 2019 11:16:59 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58038) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIx9a-0003zU-4K for emacs-devel@gnu.org; Tue, 23 Apr 2019 11:16:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hIx9Y-0003PI-8s for emacs-devel@gnu.org; Tue, 23 Apr 2019 11:16:14 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:60178) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hIx9W-0003Nu-7C for emacs-devel@gnu.org; Tue, 23 Apr 2019 11:16:12 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 9E8DA16177F; Tue, 23 Apr 2019 08:16:08 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id v_7KCyatp6pO; Tue, 23 Apr 2019 08:16:07 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id CAA3516171B; Tue, 23 Apr 2019 08:16:07 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id r0gYeZXZ5Oin; Tue, 23 Apr 2019 08:16:07 -0700 (PDT) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id ADF20161719; Tue, 23 Apr 2019 08:16:07 -0700 (PDT) Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECH In-Reply-To: <20190423131742.65814-1-phst@google.com> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235825 Archived-At: On 4/23/19 6:17 AM, Philipp Stephani wrote: > +@deftypefn Function struct timespec extract_time (emacs_env *@var{env}, emacs_value @var{time}) > +This function interprets @var{time} as an Emacs time value and returns > +the corresponding @code{struct timespec}. @xref{Time of Day}. > +@var{time} may not be @code{nil}. Why not have 'nil' mean the same thing here that it does elsewhere for Emacs time values, namely, the current time? (That would make the code a tiny bit faster. :-) > This function raises an error if "signals an error" > + assert (time.tv_nsec < 1000000000); 2 billion would be safer, to cater to (hypothetical and non-POSIX) implementations that represent leap seconds with 1 billion <= tv_nsec < 2 billion. That's what timespec_cmp does, anyway. > + (dolist (input '(#x10000000000000000 ; out of range This test will fail to be out of range on (hypothetical) machines where time_t is 128 bits. How about 1.0e+INF instead? You can test -1.0e+INF and 0.0e+NaN while you're at it.