From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ivan Cibrario Bertolotti Newsgroups: gmane.emacs.bugs Subject: bug#21943: 25.1.50; Pcvs fails to list CVS entries Date: Tue, 24 Nov 2015 09:27:06 +0100 Message-ID: <3259EB2B-D4B3-4704-9322-AF43774589E6@polito.it> References: <41D9E609-3B81-42FD-848B-1AA44EA7D820@polito.it> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (Mac OS X Mail 9.1 \(3096.5\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1448353707 23759 80.91.229.3 (24 Nov 2015 08:28:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 24 Nov 2015 08:28:27 +0000 (UTC) Cc: 21943@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 24 09:28:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a18xN-0001FC-7C for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Nov 2015 09:28:09 +0100 Original-Received: from localhost ([::1]:36898 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a18xN-0001nH-GG for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Nov 2015 03:28:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40531) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a18xJ-0001k7-Tl for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2015 03:28:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a18xG-0001VF-N9 for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2015 03:28:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60539) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a18xG-0001VA-KS for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2015 03:28:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1a18xG-00053A-Do for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2015 03:28:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ivan Cibrario Bertolotti Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Nov 2015 08:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21943 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21943-submit@debbugs.gnu.org id=B21943.144835363219354 (code B ref 21943); Tue, 24 Nov 2015 08:28:02 +0000 Original-Received: (at 21943) by debbugs.gnu.org; 24 Nov 2015 08:27:12 +0000 Original-Received: from localhost ([127.0.0.1]:50246 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a18wS-000525-1O for submit@debbugs.gnu.org; Tue, 24 Nov 2015 03:27:12 -0500 Original-Received: from fm1nodo5.polito.it ([130.192.180.13]:35067) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a18wP-00051w-AC for 21943@debbugs.gnu.org; Tue, 24 Nov 2015 03:27:10 -0500 Original-Received: from polito.it (frontmail2.polito.it [130.192.180.42]) by fm1nodo5.polito.it with ESMTP id tAO8R6Mq012158-tAO8R6Ms012158 (version=TLSv1.0 cipher=AES128-SHA bits=128 verify=CAFAIL); Tue, 24 Nov 2015 09:27:06 +0100 X-ExtScanner: Niversoft's FindAttachments (free) Original-Received: from mac16icb.polito.it (account d011741@polito.it [130.192.36.181] verified) by polito.it (CommuniGate Pro SMTP 6.1.5) with ESMTPSA id 41234247; Tue, 24 Nov 2015 09:27:06 +0100 In-Reply-To: X-Mailer: Apple Mail (2.3096.5) X-FEAS-SYSTEM-WL: 130.192.180.42 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:109172 Archived-At: On 23 Nov 2015, at 20:01, Glenn Morris wrote: >=20 > Ivan Cibrario Bertolotti wrote: >=20 >> When trying to list CVS entries using the pcvs builtin package, >> for instance by means of the C-u on any CVS directory >> in a dired buffer, the following error message comes out: >>=20 >> cvs-fileinfo-from-entries: Invalid time zone specification: utc >>=20 >> The issue can probably be tracked down to the use of 'utc as third >> argument of format-time-string at line 468 of pcvs-info.el. Afaik, >> the semantics of this argument have been changed in July 2015. >=20 > Thanks for the report. The pcvs fix is obvious, but it seems to me = that > this change to format-time-string should be called out in NEWS as in > incompatible one. (Obviously it would be nicer if the change were > backwards compatible.) Thank you for your prompt reply. As far as I know (just my 2 cents, I=E2=80=99m in no way an Emacs Lisp expert) the changes introduced by commit af32fa956267af40db61051c248597144d41521c have been documented in NEWS, although the incompatibility has not been explicitly called out. More specifically, in Emacs 24.5.1, the third argument of format-time-string was handled =E2=80=9Cas a Boolean=E2=80=9D, that is, = all non-nil arguments were treated in the same way. "if non-nil, means describe TIME as Universal Time; nil means describe TIME in the local time zone=E2=80=9D In 25.1.50, a non-nil argument is further analyzed, looking for a time zone rule or a few other special values. Of them, t calls for the old behavior. "The optional ZONE is omitted or nil for Emacs local time, t for Universal Time, =E2=80=98wall=E2=80=99 for system wall clock time, or a = string as in =E2=80=98set-time-zone-rule=E2=80=99 for a time zone rule=E2=80=9D Therefore, I reckon that any call to format-time-string made in the past with a third argument that is non-nil, not t, and does not correspond to a valid time zone rule, is a potential source of compatibility issues. I do agree that the fix is obvious (most likely, just replace any non-nil third argument with t), but it may require scanning the code base for calls to format-time-string. On the other hand, without introducing additional arguments, it may be difficult to preserve backward compatibility because it is hard to predict what programmers used as a =E2=80=9Cnon-nil value=E2=80=9D in = the past. Best regards, ICB