From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: toml-ts-mode (code-review done) Date: Wed, 14 Dec 2022 12:37:18 -0800 Message-ID: <3233F4D7-AC3A-4A99-BBDE-03693E487C9A@gmail.com> References: <4E261A68-AB14-48A5-B19C-8981CB003F33@secure.kjonigsen.net> <86a63unfvp.fsf@mail.linkov.net> <83cz8pu9cr.fsf@gnu.org> <0f74be1a-8502-ce66-6101-2b3f060295c5@secure.kjonigsen.net> <7825A406-3F21-4E38-9E9B-B429B9E81B4E@gmail.com> <1711257d-a476-3f67-04e1-0da3c979594a@secure.kjonigsen.net> <94a44e82-c8ae-7ca5-ee79-0099cfd8dde4@secure.kjonigsen.net> <2a9504c6-edc6-a254-ecf0-bd7b578e48c1@secure.kjonigsen.net> <8188B1D4-9845-4CED-809A-C0F3A85AE750@thornhill.no> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34765"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jostein@kjonigsen.net, =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= , Randy Taylor , Eli Zaretskii , Juri Linkov , emacs-devel To: Theodor Thornhill Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 14 21:42:14 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p5YZx-0008mz-MO for ged-emacs-devel@m.gmane-mx.org; Wed, 14 Dec 2022 21:42:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p5YVL-0006j5-7n; Wed, 14 Dec 2022 15:37:27 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5YVI-0006hp-Ij for emacs-devel@gnu.org; Wed, 14 Dec 2022 15:37:25 -0500 Original-Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p5YVH-000388-3P; Wed, 14 Dec 2022 15:37:24 -0500 Original-Received: by mail-pl1-x62c.google.com with SMTP id g10so4585173plo.11; Wed, 14 Dec 2022 12:37:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xmUHbpOsZm070EaFEO6N5NG6j9VdTOICZ5CH5zOO4yA=; b=J6TmFyTromFtt7subRhV7z3L27wgYRjIbdLfESMdvaTMNJoQi0rP7LoDPmwlEkad5P Jw6yahVCMVqMRxTwAuM7KiSeycM+XfZ4JR+hSHXuluDhaSKfMrmr67o1si3rJiBhZqRo vBmmcIkbZyrh9ODE/X9bqjdVHJswPAr0uSgz5ycPpbAT63topO3j6tNROGf+xtsehpGh GLNOVhzGAbh0PNEWHV4C21QL9rn6fX/wQWXsGNSikMWBZVKEfKUD9KGdtbg6YEhGIEDQ L+956hUHYbLKlhw7LxpYxtEgHIsU5g8HK7Db25wJwus6WaQf9Tfh/kXU9ue1aK1NHnqP 4DoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xmUHbpOsZm070EaFEO6N5NG6j9VdTOICZ5CH5zOO4yA=; b=RwsIFNmrTBZsdInms2JNJyBxJlNnq0lYpwrMGBQkthYUS9UJCnLAsAiJ73DIvcYkmv 5fyMaBLFjI/ng685yoF4LL7TU1iIbQLO4TDt+xn53sZXINSijiMtQfW9E99vqSbHoER5 ToBxGyrcT35qz8pIW4fVIYwqTboKiQLU0eKRKh646VsdaJclYAPpRvaAPFZRFoFTIvIm qtRcTUGMxh8XUVzZQU8XyvGmXV0hF6xvL8FVcYyiBHe88kE0kZyZheAsUr52XNlu/2dz EDjh5p8URWx+7rJzhBbUMhvfDvBQrZJ7qdf5q++XSlkDuvXJ6iF+jL6g8qSKsnCdor3Z As1Q== X-Gm-Message-State: ANoB5pm1FKedbg37r2ELxSR/T/VI2t+sH2XO/bOI+Rh29777X/w/NrSd gLH9CLIgYtzROVjcovXMA3oaJMeI42woDQ== X-Google-Smtp-Source: AA0mqf6QlEBqd5fmX/Lg06x4Emk2LibHLR/OVD03vlJOoLo08Zbd8cvP2fycI44UEkLwwjBgvS+TPQ== X-Received: by 2002:a17:902:e011:b0:189:8425:730d with SMTP id o17-20020a170902e01100b001898425730dmr22036949plo.27.1671050240707; Wed, 14 Dec 2022 12:37:20 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id b2-20020a170903228200b00185402cfedesm2002456plh.246.2022.12.14.12.37.19 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Dec 2022 12:37:20 -0800 (PST) In-Reply-To: <8188B1D4-9845-4CED-809A-C0F3A85AE750@thornhill.no> X-Mailer: Apple Mail (2.3696.120.41.1.1) Received-SPF: pass client-ip=2607:f8b0:4864:20::62c; envelope-from=casouri@gmail.com; helo=mail-pl1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301410 Archived-At: > On Dec 14, 2022, at 11:02 AM, Theodor Thornhill = wrote: >=20 >=20 >=20 > On 14 December 2022 19:53:25 CET, "Jostein Kj=C3=B8nigsen" = wrote: >> On 14.12.2022 14:24, Randy Taylor wrote: >>>=20 >>> On Wednesday, December 14th, 2022 at 03:40, Jostein Kj=C3=B8nigsen = wrote: >>> Nice catch. Fixed. >>>>=20 >>>> Attached is a new revision. Final revision? Is this good for = merging now? :) >>>>=20 >>>> -- >>>>=20 >>>> Jostein >>>>=20 >>> Looks good to me! >>>=20 >> Great! Thanks for >>=20 >> So what's the next move from here on? Are there any other things = which needs to be completed before this can be merged? >>=20 >> I'm asking since this is my first full "original" submissions, which = isn't a patch to an existing package/module. :) >>=20 >> -- >> Jostein >=20 > Imo it's only missing a push :) >=20 > Theo I applied and pushed it. Great work, folks! Yuan=