all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Merten <smerten@oekonux.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: call for more ert tests
Date: Sat, 29 Jun 2013 17:11:45 +0200	[thread overview]
Message-ID: <321.1372518705@eskebo.merten-home.homelinux.org> (raw)
In-Reply-To: <83obashnwr.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1636 bytes --]

Hi!

3 days ago Eli Zaretskii wrote:
>> From: Stefan Merten <smerten@oekonux.de>
>> May be I do not understand Lars' intentions here, but what is testing
>> the C code good for at all? I mean there is an API - or rather: lots
>> of APIs - and *this* is what needs testing. The C code to me looks
>> like an implementation detail I'd not write tests for. Or at least
>> separate those tests clearly from the API tests.
> 
> You seem to think that every C code in Emacs is part or a subroutine
> of some Lisp API.  But that is false:

Of course. Sorry for my ignorance. My focus is on the interface
exposed in Lisp but that is of course only part of the story if you
really want a good test coverage.

> e.g., the display engine is
> implemented almost entirely in C.  If you have no test harness for
> testing that, you cannot be sure, for example, that some change didn't
> break cursor positioning

Sure.

> Other important parts of Emacs that are implemented almost entirely in
> C include:
> 
>   . GC
> 
>   . keyboard input
> 
>   . interaction with subprocesses
> 
>   . file I/O
> 
> There's probably more; these are just off the top of my head.

That would call for different test suites then. Also you hardly can
test all this by ert tests but need other frameworks for the tests.

Also the tests in an repository need to be organized or otherwise
you'll end up in chaos soon. For instance at the moment for rst.el I
have 22 lisp files with ert tests making up for nearly 10000 lines of
code. Yes, this is about the double of the lines rst.el has...


						Grüße

						Stefan

[-- Attachment #2: Type: application/pgp-signature, Size: 307 bytes --]

      reply	other threads:[~2013-06-29 15:11 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-24 17:31 call for more ert tests Glenn Morris
2013-06-24 18:21 ` Eli Zaretskii
2013-06-24 18:24   ` Lennart Borgman
2013-07-01 11:35     ` Andreas Röhler
2013-07-01 16:14       ` Stefan Merten
2013-07-01 16:35         ` Andreas Röhler
2013-07-01 16:37       ` Eli Zaretskii
2013-07-01 17:35         ` Eli Zaretskii
2013-07-01 18:44           ` Stephen J. Turnbull
2013-07-01 19:32             ` Eli Zaretskii
2013-07-01 20:34         ` Dmitry Gutov
2013-06-24 18:33   ` Sebastian Wiesner
2013-06-24 18:40     ` Eli Zaretskii
2013-06-24 18:55       ` Sebastian Wiesner
2013-06-24 19:16         ` Eli Zaretskii
2013-06-24 19:20           ` Lennart Borgman
2013-06-24 19:35           ` Óscar Fuentes
2013-06-24 19:59             ` John Wiegley
2013-06-25  1:21               ` Leo Liu
2013-06-25  2:44                 ` John Wiegley
2013-06-25  3:02                   ` Stefan Monnier
2013-06-25  2:31             ` Stephen J. Turnbull
2013-06-25 14:38               ` Eli Zaretskii
2013-06-25 11:06             ` Lars Magne Ingebrigtsen
2013-06-25 12:11               ` Juanma Barranquero
2013-06-25 15:15               ` Eli Zaretskii
2013-06-25 19:18                 ` Lars Magne Ingebrigtsen
2013-06-25 20:12                   ` Eli Zaretskii
2013-06-25 20:36                   ` Sebastian Wiesner
2013-06-25 20:44                     ` Lars Magne Ingebrigtsen
2013-06-28 15:01                       ` Ted Zlatanov
2013-06-28 15:39                         ` Juanma Barranquero
2013-06-28 15:41                         ` Dmitry Gutov
2013-06-26  9:03                     ` Julien Danjou
2013-06-26  5:12                   ` Stephen J. Turnbull
2013-06-24 19:46   ` Glenn Morris
2013-06-25 13:33     ` Noah Lavine
2013-06-25 17:18   ` Rüdiger Sonderfeld
2013-06-25 18:53     ` Eli Zaretskii
2013-06-25 20:29       ` Dmitry Gutov
2013-07-01 11:45   ` Andreas Röhler
2013-07-01 12:43     ` Ted Zlatanov
2013-07-01 14:13       ` Andreas Röhler
2013-06-24 18:29 ` David Engster
2013-06-24 18:38   ` Glenn Morris
2013-06-24 19:04     ` David Engster
2013-06-25 22:15 ` Daniel Hackney
2013-06-26  9:22 ` Stefan Merten
2013-06-26 12:17   ` Bozhidar Batsov
2013-06-26 15:52     ` Eli Zaretskii
2013-06-26 16:03       ` Bozhidar Batsov
2013-06-26 16:22         ` Eli Zaretskii
2013-06-26 19:01           ` Dmitry Gutov
2013-06-26 19:10             ` Michael Albinus
2013-06-26 19:34               ` Dmitry Gutov
2013-06-26 19:56                 ` Michael Albinus
2013-06-26 19:28             ` Eli Zaretskii
2013-06-26 19:46             ` Teemu Likonen
2013-06-26 15:50   ` Eli Zaretskii
2013-06-29 15:11     ` Stefan Merten [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=321.1372518705@eskebo.merten-home.homelinux.org \
    --to=smerten@oekonux.de \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.