From: Jared Finder via "Emacs development discussions." <emacs-devel@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: "Jared Finder via \"Emacs development discussions.\""
<emacs-devel@gnu.org>
Subject: Re: mouse-face and help echo support for xterm mouse
Date: Sun, 01 Nov 2020 07:56:37 -0800 [thread overview]
Message-ID: <31ff05295c806c4596c54fdcc8994a5f@finder.org> (raw)
In-Reply-To: <jwvwnz542qc.fsf-monnier+emacs@gnu.org>
On 2020-11-01 5:39 am, Stefan Monnier wrote:
> Hi Jared,
>
> I really like this new feature but have just one comment/question?
>
>> + previous_help_echo_string = help_echo_string;
>> + help_echo_string = Qnil;
>> +
>> + note_mouse_highlight(XFRAME(frame), XFIXNUM (mouse_x), XFIXNUM
>> (mouse_y));
>> +
>> + if (!NILP (help_echo_string)
>> + || !NILP (previous_help_echo_string))
>> + {
>> + gen_help_event (help_echo_string, frame, help_echo_window,
>> + help_echo_object, help_echo_pos);
>> + }
>
> I see this exact same code in other C files.
> Could we move it to a file where we can share it instead of having
> N copies?
I completely agree, not just for this code but also for mouse handling
in general. I think there should be a shared mouse interface with
individual C functions for each type of mouse event: mouse move, mouse
click, etc. Translating OS-specific events to this shared functionality
would continue to be OS-specific, but the actual handling of these
events, such as this logic, would be fully shared. For example, this
would unify the different codepaths between TTY menus for GPM,
xterm-mouse, and NT Emacs.
I would be happy to help with this next. However I need some help. I
can only locally build and test for Linux terminal with xterm-mouse or
GPM handling the mouse. Is there someone who can help for other
platforms? And should the GUI platforms be included as well? (I
suspect yes is the right answer.)
-- MJF
next prev parent reply other threads:[~2020-11-01 15:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-01 5:46 mouse-face and help echo support for xterm mouse Jared Finder via Emacs development discussions.
2020-11-01 13:39 ` Stefan Monnier
2020-11-01 15:56 ` Jared Finder via Emacs development discussions. [this message]
2020-11-04 6:54 ` Jared Finder via Emacs development discussions.
2020-11-04 14:13 ` Stefan Monnier
2020-11-04 15:46 ` Eli Zaretskii
2020-11-04 15:56 ` Stefan Monnier
2020-11-04 17:54 ` Jared Finder via Emacs development discussions.
2020-11-04 18:47 ` Stefan Monnier
2020-11-04 18:51 ` Eli Zaretskii
2020-11-04 19:05 ` Stefan Monnier
2020-11-04 19:10 ` Jared Finder via Emacs development discussions.
2020-11-04 15:19 ` Eli Zaretskii
2020-11-05 8:15 ` Jared Finder via Emacs development discussions.
2020-11-05 14:45 ` Stefan Monnier
2020-11-05 19:58 ` Jared Finder via Emacs development discussions.
2020-11-05 20:18 ` Stefan Monnier
2020-11-06 5:23 ` Jared Finder via Emacs development discussions.
2020-11-06 6:00 ` Eli Zaretskii
2020-11-06 6:46 ` Jared Finder via Emacs development discussions.
2020-11-06 7:39 ` Eli Zaretskii
2020-11-07 1:22 ` Jared Finder via Emacs development discussions.
2020-11-14 12:38 ` Eli Zaretskii
2020-11-14 12:35 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31ff05295c806c4596c54fdcc8994a5f@finder.org \
--to=emacs-devel@gnu.org \
--cc=jared@finder.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.