From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.bugs Subject: bug#61283: 29.0.60; pcomplete-completions-at-point loses text properties, breaking pcomplete-from-help annotations Date: Tue, 16 May 2023 12:44:48 +0200 Message-ID: <31f17ffe-8070-4259-03d2-2c63e5cc5ee9@daniel-mendler.de> References: <2eb987c6-0aec-55df-db4e-ef95557ab809@daniel-mendler.de> <83zg64zhyx.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6234"; mail-complaints-to="usenet@ciao.gmane.io" Cc: liuhui1610@gmail.com, monnier@iro.umontreal.ca, 61283@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 16 12:46:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pysCA-0001QR-Hr for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 16 May 2023 12:46:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pysBx-0004fO-LQ; Tue, 16 May 2023 06:46:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pysBu-0004e7-Rs for bug-gnu-emacs@gnu.org; Tue, 16 May 2023 06:46:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pysBt-0005H9-Rr for bug-gnu-emacs@gnu.org; Tue, 16 May 2023 06:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pysBt-0008EQ-NJ for bug-gnu-emacs@gnu.org; Tue, 16 May 2023 06:46:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Mendler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 May 2023 10:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61283 X-GNU-PR-Package: emacs Original-Received: via spool by 61283-submit@debbugs.gnu.org id=B61283.168423390231557 (code B ref 61283); Tue, 16 May 2023 10:46:01 +0000 Original-Received: (at 61283) by debbugs.gnu.org; 16 May 2023 10:45:02 +0000 Original-Received: from localhost ([127.0.0.1]:45307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pysAw-0008Cv-23 for submit@debbugs.gnu.org; Tue, 16 May 2023 06:45:02 -0400 Original-Received: from server.qxqx.de ([178.63.65.180]:47851 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pysAr-0008C6-4w for 61283@debbugs.gnu.org; Tue, 16 May 2023 06:45:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=3oc9dGVeEUW9vwTHNyXLyEcNGCfcVSF/v6k2hUAce7I=; b=mUyeg4s8umCPo2QVdeFxBF6m8G /IE1dZxV9wjVSe2gh8c9xMZ62F6QinxcvvyR79hL6oX6VG905C2pewmTE+FJ+5/XZntH4MnLBsDNu iav7rEWiWYOz39oR7jyirjwsWteDITFLo16rU+JpW37CA7opAT+RYY6zVPparCd5NVaQ=; Content-Language: en-US In-Reply-To: <83zg64zhyx.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261779 Archived-At: On 5/16/23 12:30, Eli Zaretskii wrote: >> Date: Tue, 16 May 2023 08:19:52 +0200 >> Cc: 61283@debbugs.gnu.org, Stefan Monnier , >> Eli Zaretskii >> From: Daniel Mendler >> >> Eli, are you okay with adding a fix for this problem to emacs-29? > > I'd need to see an actual patch to answer that. It depends on where > in the code will the fix be and how likely it will be to affect > unrelated parts of the functionality. > >> The pcomplete help functionality is new functionality introduced in >> Emacs 29, but it never worked properly, it seems. > > I think "never worked properly" is a bit of an exaggeration, since I'd > assume it does "mostly" work, otherwise it would not have been > installed. Some parts of the functionality are not working, but I'm > not yet sure how important those parts are, relative to the rest. I just tried again and it seems the annotations work only in Shell but not in Eshell. This is probably the reason why the issue was missed. In Eshell the functionality never worked as intended after it got installed. I didn't mean to exaggerate. - M-x shell -> Type ls - TAB -> Annotations are displayed - M-x eshell -> Type ls - TAB -> No annotations Daniel