From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.devel Subject: Re: Moving kbd to subr.el Date: Sun, 17 Oct 2021 21:20:01 +0000 Message-ID: <31b2f1e9412d60db82df@heytings.org> References: <20211004081724.6281.11798@vcs0.savannah.gnu.org> <87h7dm9en7.fsf@gnus.org> <87czoa9e7p.fsf@gnus.org> <878ryxakv9.fsf@gnus.org> <834k9km5no.fsf@gnu.org> <83k0iflsze.fsf@gnu.org> <874k9jzu7a.fsf@gnus.org> <874k9juy0r.fsf@gnus.org> <87mtnbtimj.fsf@gnus.org> <87wnmd13ny.fsf@gnus.org> <87sfx10xs6.fsf@gnus.org> <87h7dfpjn3.fsf@gnus.org> <31b2f1e94178d73e5f05@heytings.org> <87czo3pgs1.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="TwBygELWDr" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21617"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Kangas , emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Oct 17 23:21:38 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mcDb7-0005Oh-7e for ged-emacs-devel@m.gmane-mx.org; Sun, 17 Oct 2021 23:21:37 +0200 Original-Received: from localhost ([::1]:41372 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mcDb4-0007Hr-UM for ged-emacs-devel@m.gmane-mx.org; Sun, 17 Oct 2021 17:21:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45202) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcDZh-0006Kc-7k for emacs-devel@gnu.org; Sun, 17 Oct 2021 17:20:10 -0400 Original-Received: from heytings.org ([95.142.160.155]:55646) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcDZc-0005ax-Dh for emacs-devel@gnu.org; Sun, 17 Oct 2021 17:20:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1634505602; bh=e0WEetMIc11GtipMig/t4PasqaJZcQYKJxaZ9jE+u9M=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=aij91pTsZIAGwyRLbPSceEYUKevKI0CjzOlp/22OEuR3ZsPxbIAmNtHkN+gdhL8Lv e59uIHh24gTwvLNiVLpm87voeBGp9BsyvAAlKqrTby9OXedwrixBmt7fop6qmq41Bs CiZpaDYJnbB+KqG5foF0F8mYA1thSVKWJ5tUKy9lhwb3w+FJRhPmPkREhYMgS4Jfdr W+aYoSR4NFU409HErObOXROD7Cz9hxKrCmL24efbQFhDM5kShl6ON4H57hOS8d2Sz1 agQbe9H4t1q40oySOj25dHgzI2mfxSp5uV/hwPOnEf7l3DGXMnx49BOIOgbVT1yPcL 5cm3nSEQt88Cg== In-Reply-To: <87czo3pgs1.fsf@gnus.org> Received-SPF: pass client-ip=95.142.160.155; envelope-from=gregory@heytings.org; helo=heytings.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:277237 Archived-At: --TwBygELWDr Content-Type: text/plain; format=flowed; charset=utf-8 Content-Transfer-Encoding: quoted-printable >> A suggestion: >> >> (kbd-valid-p "") >> (kbd-valid-p "") >> >> should return t, and > > Good point. This does make one of the syntax checks either less=20 > effective, or the syntax is ambiguous. I went with the latter, but I'm= =20 > not sure that's the right thing to do here. > > The kbd syntax is > > "C-M-" > > but allowing dashes inside the brackets means that > > "" > > should be parsed as the key named "C-M-return" (which isn't really=20 > possible). > > So I just added some special-casing to disallow the "" form= =20 > in kbd-valid-p. We'll see... > >> (kbd-valid-p "<123>") >> >> should (I think) return nil. IOW, kbd-valid-p should use: > > I'm not sure -- can there be keys named "123"? I don't know what the=20 > rules are here -- is there an authoritative source for the syntax of=20 > these names somewhere? > This is no different from "C-M-return" which you disallow. In theory=20 there could be a key or event whose symbolic name is "C-M-return". In=20 theory there could be a key or event whose symbolic name is "123" (or even= =20 "0", which is different from the key "0"). In theory there could also be= =20 a key or event whose symbolic name is "=C3=BC", IOW, <=C3=BC>. If the point is to introduce a strict syntax, I think it's up to you to=20 decide which key and event names are okay from the point of view of Emacs.= =20 I think the following should be okay: - contains at least two characters - starts with an ASCII letter - is followed by ASCII letters, digits, - or _ - each - must be preceded by at least two letters or digits - ends with an ASCII letter or digit Of course this is rather complex to put in a regexp, which is one of the=20 reasons I chose to use a C function to do that check. --TwBygELWDr--