From mboxrd@z Thu Jan  1 00:00:00 1970
From: Carsten Dominik <carsten.dominik@gmail.com>
Subject: Re: [patch] icalendar extended to define alarm triggers for timed
 events
Date: Fri, 2 Jul 2010 08:53:06 +0200
Message-ID: <31F9B22E-8EA7-48C4-86EB-F24645E4DB2A@gmail.com>
References: <87lj9wta1r.wl%ucecesf@ucl.ac.uk>
Mime-Version: 1.0 (Apple Message framework v936)
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from [140.186.70.92] (port=35180 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OUayh-0006Hs-5K
	for emacs-orgmode@gnu.org; Fri, 02 Jul 2010 03:48:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <carsten.dominik@gmail.com>) id 1OUayf-0002in-UB
	for emacs-orgmode@gnu.org; Fri, 02 Jul 2010 03:48:02 -0400
Received: from mail-ww0-f49.google.com ([74.125.82.49]:49713)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <carsten.dominik@gmail.com>) id 1OUayf-0002ih-Ot
	for emacs-orgmode@gnu.org; Fri, 02 Jul 2010 03:48:01 -0400
Received: by wwi14 with SMTP id 14so2570104wwi.30
	for <emacs-orgmode@gnu.org>; Fri, 02 Jul 2010 00:48:00 -0700 (PDT)
In-Reply-To: <87lj9wta1r.wl%ucecesf@ucl.ac.uk>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Eric S Fraga <e.fraga@ucl.ac.uk>
Cc: org-mode mailing list <emacs-orgmode@gnu.org>

Hi Eric,


On Jul 1, 2010, at 12:44 AM, Eric S Fraga wrote:

> Hello,
>
> attached is a rudimentary patch for org-icalendar.el to add the
> definition of alarm triggers for timed events that are exported to
> icalendar format.  The default is to behave as it does at the moment
> however.
>
> I hope it proves passable (given my less than brilliant elisp
> expertise...).

This looks pretty good!
But can you please

- Make sure that the first line of the docstring of the new variable
   fits into 75 characters (better: 72)?
   You already have made it a stand-alone sentence, which is also  
needed.

- It would also be helpful if if can make git commit and
   include the proper commit message including a ChangeLog-like entry
   as the second paragraph in that message.

Great work!

- Carsten