all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Jan Djärv" <jan.h.d@swipnet.se>
To: Angelo Graziosi <angelo.graziosi@alice.it>
Cc: Juanma Barranquero <lekktu@gmail.com>, 14901@debbugs.gnu.org
Subject: bug#14901: Trunk bootstrap broken
Date: Thu, 18 Jul 2013 23:45:37 +0200	[thread overview]
Message-ID: <31AF9B9D-0584-45DE-AD1D-1DFD8A405A98@swipnet.se> (raw)
In-Reply-To: <51E85990.3010103@alice.it>

Hello.

18 jul 2013 kl. 23:09 skrev Angelo Graziosi <angelo.graziosi@alice.it>:

> Il 18/07/2013 22.24, Juanma Barranquero ha scritto:
>> On Thu, Jul 18, 2013 at 10:07 PM, Angelo Graziosi
>> <angelo.graziosi@alice.it> wrote:
>> 
>>> I guess these changes are the culprit:
>>> 
>>> =========================
>>> 2013-07-18  Juanma Barranquero
>>> 
>>>         * keyboard.c (kbd_buffer_get_event):
>>>         * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to
>>> W32.
>>>         Followup to revno:113431.
>>> =========================
>> 
>> Does it work with the following patch?
>> 
>> 
>> === modified file 'src/keyboard.c'
>> --- src/keyboard.c 2013-07-18 16:50:05 +0000
>> +++ src/keyboard.c 2013-07-18 20:22:48 +0000
>> @@ -4066,7 +4066,7 @@
>>          }
>>        else if (event->kind == FOCUS_OUT_EVENT)
>>          {
>> -#if defined (HAVE_NS) || defined (HAVE_X11) || defined (WINDOWSNT)
>> +#if defined (HAVE_NS) || defined (HAVE_X11) || defined (HAVE_NTGUI)
>> 
>>  #ifdef HAVE_NS
>>            struct ns_display_info *di;
>> @@ -4080,7 +4080,7 @@
>>              focused = FRAME_X_DISPLAY_INFO (di)->x_highlight_frame = 0;
>> 
>>            if (! focused) obj = make_lispy_focus_out (frame);
>> -#endif /* HAVE_NS || HAVE_X11 || WINDOWSNT */
>> +#endif /* HAVE_NS || HAVE_X11 || HAVE_NTGUI */
>> 
>>            kbd_fetch_ptr = event + 1;
>>          }
>> 
> 
> No, it fails...
> 
> Sincerely, I expected the failure. Why changing WINDOWSNT with HAVE_NTGUI should work? Cygwin, ideally, should work as on GNU/Linux. Here I do GTK builds.
> 
> BTW, rev. 113449 bootstraps fine on Cygwin too.

FWIW, trunk compiles fine on GNU/Linux (with Gtk+ 3 on Fedora 18).

	Jan D.







  reply	other threads:[~2013-07-18 21:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-18 20:07 bug#14901: Trunk bootstrap broken Angelo Graziosi
2013-07-18 20:24 ` Juanma Barranquero
2013-07-18 21:09   ` Angelo Graziosi
2013-07-18 21:45     ` Jan Djärv [this message]
2013-07-18 23:02     ` Juanma Barranquero
2013-07-18 23:13     ` Juanma Barranquero
2013-07-18 22:19   ` Angelo Graziosi
2013-07-18 23:17     ` Juanma Barranquero
2013-07-19  9:54       ` Angelo Graziosi
2013-07-19  9:58         ` Juanma Barranquero
2013-07-19 11:02       ` Eli Zaretskii
2013-07-19 11:38         ` Juanma Barranquero
2013-07-19 12:18         ` Angelo Graziosi
2013-07-19 13:45           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=31AF9B9D-0584-45DE-AD1D-1DFD8A405A98@swipnet.se \
    --to=jan.h.d@swipnet.se \
    --cc=14901@debbugs.gnu.org \
    --cc=angelo.graziosi@alice.it \
    --cc=lekktu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.