From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Devon Sean McCullough Newsgroups: gmane.emacs.bugs Subject: bug#10891: bug fix lisp/url/url-http.el Date: Sun, 26 Feb 2012 12:21:04 -0500 Message-ID: <31A11F9D-C4A8-4CD7-9081-EBCCE143744F@jovi.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1330284288 15347 80.91.229.3 (26 Feb 2012 19:24:48 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 26 Feb 2012 19:24:48 +0000 (UTC) To: 10891@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Feb 26 20:24:46 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1S1ji6-0004xK-MY for geb-bug-gnu-emacs@m.gmane.org; Sun, 26 Feb 2012 20:24:42 +0100 Original-Received: from localhost ([::1]:53948 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1ji6-00041n-0K for geb-bug-gnu-emacs@m.gmane.org; Sun, 26 Feb 2012 14:24:42 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:36377) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1iOX-0007Jd-JS for bug-gnu-emacs@gnu.org; Sun, 26 Feb 2012 13:00:26 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S1iOS-00078G-Me for bug-gnu-emacs@gnu.org; Sun, 26 Feb 2012 13:00:25 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56617) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1iOS-00077u-IA for bug-gnu-emacs@gnu.org; Sun, 26 Feb 2012 13:00:20 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1S1iR5-00013r-7e for bug-gnu-emacs@gnu.org; Sun, 26 Feb 2012 13:03:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Devon Sean McCullough Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Feb 2012 18:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 10891 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.13302793394012 (code B ref -1); Sun, 26 Feb 2012 18:03:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 26 Feb 2012 18:02:19 +0000 Original-Received: from localhost ([127.0.0.1]:58512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S1iQN-00012f-1x for submit@debbugs.gnu.org; Sun, 26 Feb 2012 13:02:19 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:57874) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S1hpG-00008E-Mt for submit@debbugs.gnu.org; Sun, 26 Feb 2012 12:23:59 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S1hmY-0001ac-Tg for submit@debbugs.gnu.org; Sun, 26 Feb 2012 12:21:11 -0500 Original-Received: from lists.gnu.org ([140.186.70.17]:52382) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1hmY-0001aY-Q0 for submit@debbugs.gnu.org; Sun, 26 Feb 2012 12:21:10 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:46110) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1hmX-0008B3-HI for bug-gnu-emacs@gnu.org; Sun, 26 Feb 2012 12:21:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S1hmW-0001aL-9A for bug-gnu-emacs@gnu.org; Sun, 26 Feb 2012 12:21:09 -0500 Original-Received: from gateway15.websitewelcome.com ([67.18.72.137]:41487) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1hmW-0001Zo-4R for bug-gnu-emacs@gnu.org; Sun, 26 Feb 2012 12:21:08 -0500 Original-Received: by gateway15.websitewelcome.com (Postfix, from userid 5007) id 2CF92CBBE06D7; Sun, 26 Feb 2012 11:21:05 -0600 (CST) Original-Received: from leaf.websitewelcome.com (leaf.websitewelcome.com [174.121.85.66]) by gateway15.websitewelcome.com (Postfix) with ESMTP id 2303FCBBE06B7 for ; Sun, 26 Feb 2012 11:21:05 -0600 (CST) Original-Received: from [173.66.178.127] (port=56810 helo=ra.home) by leaf.websitewelcome.com with esmtps (TLSv1:AES128-SHA:128) (Exim 4.69) (envelope-from ) id 1S1hmS-0007cY-RM for bug-gnu-emacs@gnu.org; Sun, 26 Feb 2012 11:21:05 -0600 X-Mailer: Apple Mail (2.1084) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - leaf.websitewelcome.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jovi.net X-BWhitelist: no X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: pool-173-66-178-127.washdc.fios.verizon.net (ra.home) [173.66.178.127]:56810 X-Source-Auth: jovinet X-Email-Count: 1 X-Source-Cap: am92aW5ldDtkZXZvbjtsZWFmLndlYnNpdGV3ZWxjb21lLmNvbQ== X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Mailman-Approved-At: Sun, 26 Feb 2012 13:02:17 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-Mailman-Approved-At: Sun, 26 Feb 2012 14:24:40 -0500 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:57261 Archived-At: (let ((url-gateway-unplugged t)) (url-retrieve-synchronously "http://gnu.org")) bombs Wrong type argument: processp, nil should be Could not create connection to gnu.org:80 Peace --Devon PS: Here's the fix --- url-http.el.~1~ 2010-04-03 18:26:11.000000000 -0400 +++ url-http.el 2012-02-26 10:53:27.000000000 -0500 @@ -119,9 +120,7 @@ (url-http-debug "Reusing existing connection: %s:%d" host port) (url-http-debug "Contacting host: %s:%d" host port)) (url-lazy-message "Contacting host: %s:%d" host port) - (url-http-mark-connection-as-busy - host port - (or found + (let ((conn (or found (let ((buf (generate-new-buffer " *url-http-temp*"))) ;; `url-open-stream' needs a buffer in which to do things ;; like authentication. But we use another buffer afterwards. @@ -132,7 +131,9 @@ ;; Drop the temp buffer link before killing the buffer. (set-process-buffer proc nil)) proc) - (kill-buffer buf))))))) + (kill-buffer buf)))))) + (and conn + (url-http-mark-connection-as-busy host port conn))))) ;; Building an HTTP request (defun url-http-user-agent-string ()