all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Devon Sean McCullough <emacs-hacker2012@jovi.net>
To: 10891@debbugs.gnu.org
Subject: bug#10891: bug fix lisp/url/url-http.el
Date: Sun, 26 Feb 2012 12:21:04 -0500	[thread overview]
Message-ID: <31A11F9D-C4A8-4CD7-9081-EBCCE143744F@jovi.net> (raw)

(let ((url-gateway-unplugged t))
  (url-retrieve-synchronously "http://gnu.org"))

bombs
	Wrong type argument: processp, nil

should be
	Could not create connection to gnu.org:80

		Peace
			--Devon

PS: Here's the fix

--- url-http.el.~1~	2010-04-03 18:26:11.000000000 -0400
+++ url-http.el	2012-02-26 10:53:27.000000000 -0500
@@ -119,9 +120,7 @@
 	(url-http-debug "Reusing existing connection: %s:%d" host port)
       (url-http-debug "Contacting host: %s:%d" host port))
     (url-lazy-message "Contacting host: %s:%d" host port)
-    (url-http-mark-connection-as-busy
-     host port
-     (or found
+    (let ((conn (or found
          (let ((buf (generate-new-buffer " *url-http-temp*")))
            ;; `url-open-stream' needs a buffer in which to do things
            ;; like authentication.  But we use another buffer afterwards.
@@ -132,7 +131,9 @@
 		   ;; Drop the temp buffer link before killing the buffer.
 		   (set-process-buffer proc nil))
                  proc)
-             (kill-buffer buf)))))))
+                        (kill-buffer buf))))))
+      (and conn
+	   (url-http-mark-connection-as-busy host port conn)))))
 
 ;; Building an HTTP request
 (defun url-http-user-agent-string ()
 





             reply	other threads:[~2012-02-26 17:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-26 17:21 Devon Sean McCullough [this message]
2012-03-11  9:44 ` bug#10891: bug fix lisp/url/url-http.el Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=31A11F9D-C4A8-4CD7-9081-EBCCE143744F@jovi.net \
    --to=emacs-hacker2012@jovi.net \
    --cc=10891@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.