From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Braun =?UTF-8?Q?G=C3=A1bor?= Newsgroups: gmane.emacs.bugs Subject: bug#34405: bug#26061: 26.0.50; cancel-change-group fails with "unrelated state" error if used after an undo Date: Mon, 16 Aug 2021 14:01:01 +0200 Message-ID: <3177793.ljFpVtCzQm@gabor> References: <1631063.cd5q6Ms6ql@gabor> <87o8a0ruum.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3234"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 34405@debbugs.gnu.org, 26061@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 16 14:02:26 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mFbJy-0000jX-9n for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 16 Aug 2021 14:02:26 +0200 Original-Received: from localhost ([::1]:33166 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mFbJx-00025z-2l for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 16 Aug 2021 08:02:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56120) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFbJa-0001wa-VB for bug-gnu-emacs@gnu.org; Mon, 16 Aug 2021 08:02:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37163) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mFbJa-00021H-Mp for bug-gnu-emacs@gnu.org; Mon, 16 Aug 2021 08:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mFbJa-0002ev-Kb for bug-gnu-emacs@gnu.org; Mon, 16 Aug 2021 08:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Braun =?UTF-8?Q?G=C3=A1bor?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Aug 2021 12:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34405 X-GNU-PR-Package: emacs Original-Received: via spool by 34405-submit@debbugs.gnu.org id=B34405.162911528010136 (code B ref 34405); Mon, 16 Aug 2021 12:02:02 +0000 Original-Received: (at 34405) by debbugs.gnu.org; 16 Aug 2021 12:01:20 +0000 Original-Received: from localhost ([127.0.0.1]:48706 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFbIu-0002dP-6H for submit@debbugs.gnu.org; Mon, 16 Aug 2021 08:01:20 -0400 Original-Received: from mail-wr1-f43.google.com ([209.85.221.43]:34705) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFbIr-0002d2-Aq; Mon, 16 Aug 2021 08:01:19 -0400 Original-Received: by mail-wr1-f43.google.com with SMTP id h13so23285640wrp.1; Mon, 16 Aug 2021 05:01:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4CDZV35rWOi6Ifgh0ml7fLQNmYYMnvAjEBIAH0KxuWs=; b=qCWk9RCsEa0UJUo6UyvW1Sha6OXHdlvJa+muEfRFa+f0E8uwwEScx5rQ2BReS2w7B4 OfP7hHlLtBYXYzICeg+me7WjBvZUEwi5xVeVbbsv6jNM/o24KmnrmPQBP/vnkvudLawn WEAREIanf6Ia26Nd/hGqa+3A3nnblB1Q9z2B8UFQ1IfOuTytDM9xyD3xghmZtB+LaFPw LtWLIXCJsFpOustGQas14k2GVWbe7/f5+GgNqOlnI0jZn0cWn78NflK7vxB17TJLQamz mzQwpTk4xKYsfQ55aGHYvAjR6zNEJpf2R6XDlB3yIT7a6veQz8HT0RYv/+zxEXsAI6zl 132g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4CDZV35rWOi6Ifgh0ml7fLQNmYYMnvAjEBIAH0KxuWs=; b=Ba9BvL3A3+x7ODv0DUU7LtvtolIMNzRmz7n211+tjLTU+d39f//KCsObmHbakCgn2R F4Nd4n6OYtbXmLo5GhlYOx9V79xdZ37vHB9nYFDMbMAGAagR7khXb6QhABmS43ITiMct a2tP6SVFpMg3CCEj7VqZuC5IcLDqs33izQXhsiu7HXdXji8xhR9kq+duyBvugsN0FF8r ZJg9FpFM+mj3YadusmNCW6zE0FHlptPJu3vCXp5bYbiDH11GRrnbhMU58U2hYjP0MNn+ swittk8qchyu+2PhxMKdww3HXuhMIRyFsn81coJkq3NAKjVQy+HL4ryok0nu8DsDYsKO CCxw== X-Gm-Message-State: AOAM531LV41lyqtAamSb+H9PVNT3L7xjLEDic7O8iQ/khH1FT0srbVi9 Nx2TPLAH7qF3jRVmY9PkmL8= X-Google-Smtp-Source: ABdhPJxn4UHxY0tq1MNPR2Pt1OdHQItm8uK1jMRjuh5mXo0XFuCbRLSSMjW5SWXUCy6zV3Ram3wn8A== X-Received: by 2002:adf:e6cc:: with SMTP id y12mr18843120wrm.200.1629115271326; Mon, 16 Aug 2021 05:01:11 -0700 (PDT) Original-Received: from gabor.localnet (dslb-094-222-107-216.094.222.pools.vodafone-ip.de. [94.222.107.216]) by smtp.gmail.com with ESMTPSA id r12sm11547562wrv.96.2021.08.16.05.01.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Aug 2021 05:01:11 -0700 (PDT) In-Reply-To: <87o8a0ruum.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211989 Archived-At: > I can reproduce this problem in Emacs 26.1, but it seems to be gone in > Emacs 27.1 (and 28), so I'm going to go ahead and guess that this has > been fixed I can see the fix in the following snippet of `cancel-change-group' in=20 Emacs 27.1 code. The faulty logic with `last-command' and `undo-start'=20 has been gone. (... denotes omitted code.) (let (... ;; Use `pending-undo-list' temporarily since `undo-more' needs ;; it, but restore it afterwards so as not to mess with an ;; ongoing sequence of `undo's. (pending-undo-list ;; Use `buffer-undo-list' unconditionally (bug#39680). buffer-undo-list)) Thank you for checking in recent Emacs versions. Best wishes, G=C3=A1bor