all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Braun Gábor" <braungb88@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 34405@debbugs.gnu.org, 26061@debbugs.gnu.org
Subject: bug#34405: bug#26061: 26.0.50; cancel-change-group fails with "unrelated state" error if used after an undo
Date: Mon, 16 Aug 2021 14:01:01 +0200	[thread overview]
Message-ID: <3177793.ljFpVtCzQm@gabor> (raw)
In-Reply-To: <87o8a0ruum.fsf@gnus.org>

> I can reproduce this problem in Emacs 26.1, but it seems to be gone in
> Emacs 27.1 (and 28), so I'm going to go ahead and guess that this has
> been fixed

I can see the fix in the following snippet of `cancel-change-group' in 
Emacs 27.1 code.  The faulty logic with `last-command' and `undo-start' 
has been gone.  (... denotes omitted code.)

    (let (...
	      ;; Use `pending-undo-list' temporarily since `undo-more' needs
	      ;; it, but restore it afterwards so as not to mess with an
	      ;; ongoing sequence of `undo's.
	      (pending-undo-list
	       ;; Use `buffer-undo-list' unconditionally (bug#39680).
	       buffer-undo-list))

Thank you for checking in recent Emacs versions.

Best wishes,

	Gábor








      reply	other threads:[~2021-08-16 12:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-09 15:49 bug#34405: 26.1; atomic change group after undo fails to cancel Braun Gábor
2019-11-12 17:05 ` bug#34405: 26.1; patch for cancel-change-group to work after undo Braun Gábor
2019-11-14 12:10   ` Eli Zaretskii
2019-11-14 23:00     ` Braun Gábor
2019-12-20  8:11 ` bug#34405: 26.1; 2-line patch Braun Gábor
2021-08-14 13:58 ` bug#34405: bug#26061: 26.0.50; cancel-change-group fails with "unrelated state" error if used after an undo Lars Ingebrigtsen
2021-08-16 12:01   ` Braun Gábor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3177793.ljFpVtCzQm@gabor \
    --to=braungb88@gmail.com \
    --cc=26061@debbugs.gnu.org \
    --cc=34405@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.