From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: kifer@cs.sunysb.edu (Michael Kifer) Newsgroups: gmane.emacs.devel Subject: Re: your changes to ediff*.el and viper*.el Date: Thu, 10 Jan 2008 02:36:30 -0500 Message-ID: <31298.1199950590@cs.sunysb.edu> References: NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1199950601 31664 80.91.229.12 (10 Jan 2008 07:36:41 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 10 Jan 2008 07:36:41 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 10 08:37:03 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JCryI-0004ij-4z for ged-emacs-devel@m.gmane.org; Thu, 10 Jan 2008 08:37:02 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JCrxu-0001My-G5 for ged-emacs-devel@m.gmane.org; Thu, 10 Jan 2008 02:36:38 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JCrxq-0001IQ-4K for emacs-devel@gnu.org; Thu, 10 Jan 2008 02:36:34 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JCrxp-0001G4-A0 for emacs-devel@gnu.org; Thu, 10 Jan 2008 02:36:33 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JCrxp-0001Fo-6b for emacs-devel@gnu.org; Thu, 10 Jan 2008 02:36:33 -0500 Original-Received: from sbcs.cs.sunysb.edu ([130.245.1.15]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JCrxo-0008N6-M3 for emacs-devel@gnu.org; Thu, 10 Jan 2008 02:36:32 -0500 Original-Received: from localhost (compserv1 [130.245.1.44]) by sbcs.cs.sunysb.edu (8.13.6/8.12.11) with ESMTP id m0A7aSaK015045; Thu, 10 Jan 2008 02:36:28 -0500 (EST) Original-Received: from [127.0.0.1]:10025 (kiferserv [127.0.0.1]) by localhost (Postfix) with ESMTP id E56A58B775; Thu, 10 Jan 2008 02:36:30 -0500 (EST) In-Reply-To: Message from Dan Nicolaescu of "Wed, 09 Jan 2008 00:17:08 PST." <200801090817.m098HBqI006233@oogie-boogie.ics.uci.edu> X-Mailer: MH-E 8.0.3+cvs; nmh 1.1; GNU Emacs 23.0.50 X-detected-kernel: by monty-python.gnu.org: Solaris 10 (1203?) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:86683 Archived-At: ok, thanks. done > Hi, > > Can you please revert these changes: > > * viper*.el: commented out declare-function -- not defined in > XEmacs. > > * ediff*.el: commented out declare-function. "make bootstrap" > stops with an error and emacs does not compile with those things > in. > Besides, declare-function is not defined in XEmacs. > > > Your build fails because it is stale, you need to do a > "make maintainer-clean", it will succeed after that. > > As for compatibility with XEmacs, there already is a standard solution > used by several files in the tree that need XEmacs compatibility: > > (eval-and-compile > (unless (fboundp 'declare-function) (defmacro declare-function (&rest r)))) > > > Thanks > > --dan >