all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* your changes to ediff*.el and viper*.el
@ 2008-01-09  8:17 Dan Nicolaescu
  2008-01-10  7:36 ` Michael Kifer
  0 siblings, 1 reply; 2+ messages in thread
From: Dan Nicolaescu @ 2008-01-09  8:17 UTC (permalink / raw)
  To: Michael Kifer; +Cc: emacs-devel


Hi,

Can you please revert these changes:

       * viper*.el: commented out declare-function -- not defined in
       XEmacs.

       * ediff*.el: commented out declare-function. "make bootstrap"
       stops with an error and emacs does not compile with those things
       in.
       Besides, declare-function is not defined in XEmacs.


Your build fails because it is stale, you need to do a 
"make maintainer-clean", it will succeed after that. 

As for compatibility with XEmacs, there already is a standard solution
used by several files in the tree that need XEmacs compatibility:

(eval-and-compile
  (unless (fboundp 'declare-function) (defmacro declare-function (&rest  r))))


Thanks

        --dan

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: your changes to ediff*.el and viper*.el
  2008-01-09  8:17 your changes to ediff*.el and viper*.el Dan Nicolaescu
@ 2008-01-10  7:36 ` Michael Kifer
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Kifer @ 2008-01-10  7:36 UTC (permalink / raw)
  To: Dan Nicolaescu; +Cc: emacs-devel


ok, thanks. done

> Hi,
> 
> Can you please revert these changes:
> 
>        * viper*.el: commented out declare-function -- not defined in
>        XEmacs.
> 
>        * ediff*.el: commented out declare-function. "make bootstrap"
>        stops with an error and emacs does not compile with those things
>        in.
>        Besides, declare-function is not defined in XEmacs.
> 
> 
> Your build fails because it is stale, you need to do a 
> "make maintainer-clean", it will succeed after that. 
> 
> As for compatibility with XEmacs, there already is a standard solution
> used by several files in the tree that need XEmacs compatibility:
> 
> (eval-and-compile
>   (unless (fboundp 'declare-function) (defmacro declare-function (&rest  r))))
> 
> 
> Thanks
> 
>         --dan
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-01-10  7:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-09  8:17 your changes to ediff*.el and viper*.el Dan Nicolaescu
2008-01-10  7:36 ` Michael Kifer

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.