all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: kifer@cs.sunysb.edu (Michael Kifer)
To: Dan Nicolaescu <dann@ics.uci.edu>
Cc: emacs-devel@gnu.org
Subject: Re: your changes to ediff*.el and viper*.el
Date: Thu, 10 Jan 2008 02:36:30 -0500	[thread overview]
Message-ID: <31298.1199950590@cs.sunysb.edu> (raw)
In-Reply-To: Message from Dan Nicolaescu <dann@ics.uci.edu> of "Wed, 09 Jan 2008 00:17:08 PST." <200801090817.m098HBqI006233@oogie-boogie.ics.uci.edu>


ok, thanks. done

> Hi,
> 
> Can you please revert these changes:
> 
>        * viper*.el: commented out declare-function -- not defined in
>        XEmacs.
> 
>        * ediff*.el: commented out declare-function. "make bootstrap"
>        stops with an error and emacs does not compile with those things
>        in.
>        Besides, declare-function is not defined in XEmacs.
> 
> 
> Your build fails because it is stale, you need to do a 
> "make maintainer-clean", it will succeed after that. 
> 
> As for compatibility with XEmacs, there already is a standard solution
> used by several files in the tree that need XEmacs compatibility:
> 
> (eval-and-compile
>   (unless (fboundp 'declare-function) (defmacro declare-function (&rest  r))))
> 
> 
> Thanks
> 
>         --dan
> 

      reply	other threads:[~2008-01-10  7:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-09  8:17 your changes to ediff*.el and viper*.el Dan Nicolaescu
2008-01-10  7:36 ` Michael Kifer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=31298.1199950590@cs.sunysb.edu \
    --to=kifer@cs.sunysb.edu \
    --cc=dann@ics.uci.edu \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.