all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Jim Porter <jporterbugs@gmail.com>
To: Po Lu <luangruo@yahoo.com>, emacs-devel@gnu.org
Cc: Philip Kaludercic <philipk@posteo.net>
Subject: Re: master 50020d026c: Untabify rcirc.el
Date: Wed, 7 Sep 2022 09:42:54 -0700	[thread overview]
Message-ID: <30b17b67-07c8-4cd6-8b03-78a46c08906c@gmail.com> (raw)
In-Reply-To: <87h71ja0ne.fsf@yahoo.com>

On 9/7/2022 4:23 AM, Po Lu wrote:
> Philip Kaludercic <philipk@posteo.net> writes:
> 
>> branch: master
>> commit 50020d026cda1fdd70d8a08e08185dbb7183646a
>> Author: Philip Kaludercic <philipk@posteo.net>
>> Commit: Philip Kaludercic <philipk@posteo.net>
>>
>>      Untabify rcirc.el
> 
> (There's nothing wrong with tabs, not in Lisp code, not elsewhere.  But
> that's besides the point.)
> 
> Please don't make whitespace changes like this.  It makes vc-annotate
> nonfunctional and is very much unnecessary.

Perhaps we should set 'blame.ignoreRevsFile'[1] in the Emacs repo's Git 
config (and then add this commit SHA to that file)? That should make 
vc-annotate - and anything else that uses "git blame" - ignore this 
commit, along with any other mechanical commits that shouldn't count for 
the purposes of blame.

I believe this was introduced in Git 2.23 (from Aug 2019), so most 
people with relatively-recent Git installs should be able to use this. 
I'm not sure how robust this feature is (i.e. can it properly ignore 
complex changes?), but for changing tabs to spaces, that should be 
pretty trivial for Git to figure out.

[1] 
https://git-scm.com/docs/git-blame#Documentation/git-blame.txt---ignore-revs-fileltfilegt



  reply	other threads:[~2022-09-07 16:42 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <166254232836.24759.17163698181249816742@vcs2.savannah.gnu.org>
     [not found] ` <20220907091848.B4E13C04F04@vcs2.savannah.gnu.org>
2022-09-07 11:06   ` master 50020d026c: Untabify rcirc.el Lars Ingebrigtsen
2022-09-07 11:21     ` Philip Kaludercic
2022-09-07 12:11       ` Philip Kaludercic
2022-09-07 21:50         ` Stefan Kangas
2022-09-07 22:07           ` Philip Kaludercic
2022-09-08  9:07             ` Stefan Kangas
2022-09-08  9:20               ` Robert Pluim
2022-09-08  9:39                 ` Stefan Kangas
2022-09-08  9:36               ` Eli Zaretskii
2022-09-08  9:46                 ` Stefan Kangas
2022-09-08 10:25                   ` Eli Zaretskii
2022-09-08 12:02                     ` Robert Pluim
2022-09-08 12:05                     ` Philip Kaludercic
2022-09-09 23:13                       ` Stefan Kangas
2022-09-08  9:37               ` Philip Kaludercic
2022-09-08 12:04           ` Lars Ingebrigtsen
2022-09-07 12:54       ` Stefan Monnier
2022-09-07 13:22         ` Philip Kaludercic
2022-09-07 11:23   ` Po Lu
2022-09-07 16:42     ` Jim Porter [this message]
2022-09-07 18:21       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30b17b67-07c8-4cd6-8b03-78a46c08906c@gmail.com \
    --to=jporterbugs@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    --cc=philipk@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.