From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#6799: 24.0.50; Please add dired-details.el to Emacs [patch] Date: Sat, 16 Feb 2013 14:58:41 -0800 Message-ID: <309C1F199E484184BCCAB1F685A61C79@us.oracle.com> References: <9C9137560F644E759AD573BBBD8E59EF@us.oracle.com><5EA47A0255F8494DB430B52D46876641@us.oracle.com><65D921448B0644988BE6445A2EF3E021@us.oracle.com><21FFB8EA85964411A9B790386C5DA3AD@us.oracle.com><878v8zow44@ch.ristopher.com> <87k3sj6juj@ch.ristopher.com> <87mwxcx149@ch.ristopher.com><87wqugmcu8@ch.ristopher.com> <87mwvbuus2@ch.ristopher.com> <87k3qeestt@ch.ristopher.com> <87ehgm7hmx@ch.ristopher.com> <87ip5tquwi@ch.ristopher.com> <87halc3tne.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1361055558 22657 80.91.229.3 (16 Feb 2013 22:59:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 16 Feb 2013 22:59:18 +0000 (UTC) To: "'Juri Linkov'" , <6799@debbugs.gnu.org> Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 16 23:59:40 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U6qjL-0000Wl-FJ for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Feb 2013 23:59:39 +0100 Original-Received: from localhost ([::1]:54372 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U6qj1-0004kE-My for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Feb 2013 17:59:19 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:39313) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U6qiy-0004jT-2e for bug-gnu-emacs@gnu.org; Sat, 16 Feb 2013 17:59:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U6qiv-0003EL-7e for bug-gnu-emacs@gnu.org; Sat, 16 Feb 2013 17:59:15 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54110) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U6qiv-0003Dz-33 for bug-gnu-emacs@gnu.org; Sat, 16 Feb 2013 17:59:13 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1U6qji-0004Gu-Ea for bug-gnu-emacs@gnu.org; Sat, 16 Feb 2013 18:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Feb 2013 23:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 6799-submit@debbugs.gnu.org id=B6799.136105558516378 (code B ref 6799); Sat, 16 Feb 2013 23:00:02 +0000 Original-Received: (at 6799) by debbugs.gnu.org; 16 Feb 2013 22:59:45 +0000 Original-Received: from localhost ([127.0.0.1]:59574 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U6qjR-0004G6-Ed for submit@debbugs.gnu.org; Sat, 16 Feb 2013 17:59:45 -0500 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:19133) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U6qjO-0004Fy-VR for 6799@debbugs.gnu.org; Sat, 16 Feb 2013 17:59:44 -0500 Original-Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r1GMwoGj014519 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 16 Feb 2013 22:58:51 GMT Original-Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r1GMwnBY029142 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 16 Feb 2013 22:58:50 GMT Original-Received: from abhmt102.oracle.com (abhmt102.oracle.com [141.146.116.54]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id r1GMwnAm017993; Sat, 16 Feb 2013 16:58:49 -0600 Original-Received: from dradamslap1 (/71.202.147.44) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 16 Feb 2013 14:58:48 -0800 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87halc3tne.fsf@mail.jurta.org> Thread-Index: Ac4MlgzR0+SvE29FSzmR93Gj3/vUcQAAhMDQ X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:71396 Archived-At: > Usually I don't do this but when I called in a dired buffer > `M-x text-mode RET' it unexpectedly removed from display all text > except filenames (i.e. made other text invisible). > > I wonder should such cases be handled e.g. by disabling > `dired-hide-details-mode' in the hook `after-change-major-mode-hook'? They should definitely be handled, one way or another. `dired-hide-details-mode' makes sense only in a mode derived from Dired mode. Your suggested fix sounds like the right approach in general, but I think turning off `dired-hide-details-mode' should somehow be done BEFORE changing to a mode that is not dired-derived, not afterward. Can you use `change-major-mode-hook' instead, to do this before changing the mode? Is it possible at that point to test whether the target mode is (derived-mode-p dired-mode)?