all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Jashy <nanjunjie@gmail.com>
To: Emacs-devel@gnu.org
Subject: Re: Using the ImageMagick backend seems to leak memory
Date: Mon, 10 Jan 2011 05:28:56 -0800 (PST)	[thread overview]
Message-ID: <30633674.post@talk.nabble.com> (raw)
In-Reply-To: <87ipxx2gjl.fsf@member.fsf.org>



Tassilo Horn-5 wrote:
> 
> it seems one must call
>   MagickWandTerminus();
> after destroying the wands.
> Maybe that helps.
> 

Seemly it does not help too much:
diff --git a/src/image.c b/src/image.c
index fd1b921..00f857b 100644
--- a/src/image.c
+++ b/src/image.c
@@ -7539,6 +7539,7 @@ imagemagick_load_image (/* Pointer to emacs frame
structure.  */
       image_error ("Invalid image number `%s' in image `%s'",
 		   image, img->spec);
       DestroyMagickWand (ping_wand);
+      MagickWandTerminus ();
       return 0;
     }
 
@@ -7549,6 +7550,7 @@ imagemagick_load_image (/* Pointer to emacs frame
structure.  */
                     img->data.lisp_val));
 
   DestroyMagickWand (ping_wand);
+  MagickWandTerminus ();
   /* Now, after pinging, we know how many images are inside the
      file. If its not a bundle, just one.  */
 
@@ -7806,10 +7808,12 @@ imagemagick_load_image (/* Pointer to emacs frame
structure.  */
   /* Final cleanup. image_wand should be the only resource left. */
   DestroyMagickWand (image_wand);
 
+  MagickWandTerminus ();
   return 1;
 
  imagemagick_error:
   DestroyMagickWand (image_wand);
+  MagickWandTerminus ();
   /* TODO more cleanup.  */
   image_error ("Error parsing IMAGEMAGICK image `%s'", img->spec, Qnil);
   return 0;


-- 
View this message in context: http://old.nabble.com/Using-the-ImageMagick-backend-seems-to-leak-memory-tp30603180p30633674.html
Sent from the Emacs - Dev mailing list archive at Nabble.com.




  reply	other threads:[~2011-01-10 13:28 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-06  7:51 Using the ImageMagick backend seems to leak memory Tassilo Horn
2011-01-06  9:02 ` joakim
2011-01-06 10:20   ` Tassilo Horn
2011-01-07  4:17 ` Jashy
2011-01-07  4:59   ` Miles Bader
2011-01-07  6:27     ` Stephen J. Turnbull
2011-01-07  7:25       ` Miles Bader
2011-01-07  8:28     ` Tassilo Horn
2011-01-07 22:39       ` Andreas Schwab
2011-01-10 10:34         ` Tassilo Horn
2011-01-10 13:28           ` Jashy [this message]
2011-01-10 13:56             ` Tassilo Horn
2011-01-10 14:36               ` Jashy
2011-01-11 10:14                 ` Jashy
2011-01-11 10:59           ` joakim
2011-01-11 14:17       ` joakim
2011-01-11 14:38         ` joakim
2011-01-11 17:43         ` Tassilo Horn
2011-01-11 18:11           ` joakim
2011-01-11 19:10             ` Tassilo Horn
2011-01-11 19:35               ` joakim
2011-01-11 19:55                 ` Tassilo Horn
2011-01-12  1:47               ` Stefan Monnier
2011-01-12  7:37                 ` Tassilo Horn
2011-01-10 21:47 ` Tassilo Horn
2011-01-11  8:47   ` Tassilo Horn
2011-01-11  9:35     ` joakim
2011-01-11  9:53       ` Tassilo Horn
2011-01-11  9:54       ` joakim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30633674.post@talk.nabble.com \
    --to=nanjunjie@gmail.com \
    --cc=Emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.