all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Eli Zaretskii <eliz@gnu.org>, Drew Adams <drew.adams@oracle.com>
Cc: 33331@debbugs.gnu.org
Subject: bug#33331: 26; doc strings of `tabify' and `untabify'
Date: Sat, 10 Nov 2018 09:08:11 -0800 (PST)	[thread overview]
Message-ID: <3021b990-8bdd-4af7-90cb-a66a259e2ca3@default> (raw)
In-Reply-To: <<83a7mhbbva.fsf@gnu.org>>

> > Please say why there is an unused optional arg ARG.
> 
> ??? The below is from the doc strings of both functions:
> 
>   If called interactively with prefix ARG, convert for the entire
>   buffer.
> 
> What am I missing?

Sorry, I missed that somehow.  Might have
been tripped up by the use of `_arg'; dunno.
I'll close the bug.

That said...

AFAICT there's no need to add that optional
arg.  This would have been sufficient, and
it is what I would have expected:

(defun untabify (start end)
  "..."
  (interactive
    (if current-prefix-arg
        (list (point-min) (point-max))
      (list (region-beginning) (region-end))))
  ...)

Am I missing something?  Does adding that arg,
and using it only in `interactive', help?

Seems like when someone added the prefix-arg
behavior (Emacs 24, apparently) they went
overboard a bit.  Not a problem; just a bit
weird, to my eyes.





       reply	other threads:[~2018-11-10 17:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <<2ca24662-70af-4b28-81d1-ee2d63ea531a@default>
     [not found] ` <<83a7mhbbva.fsf@gnu.org>
2018-11-10 17:08   ` Drew Adams [this message]
2018-11-10 17:54     ` bug#33331: 26; doc strings of `tabify' and `untabify' Eli Zaretskii
     [not found] <<<2ca24662-70af-4b28-81d1-ee2d63ea531a@default>
     [not found] ` <<<83a7mhbbva.fsf@gnu.org>
     [not found]   ` <<3021b990-8bdd-4af7-90cb-a66a259e2ca3@default>
     [not found]     ` <<83zhugakcv.fsf@gnu.org>
2018-11-10 19:36       ` Drew Adams
2018-11-10 19:54         ` Eli Zaretskii
2018-11-10  5:48 Drew Adams
2018-11-10  8:00 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3021b990-8bdd-4af7-90cb-a66a259e2ca3@default \
    --to=drew.adams@oracle.com \
    --cc=33331@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.