From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Tree-sitter navigation time grows as sqrt(line-number) Date: Thu, 17 Aug 2023 18:01:19 +0300 Message-ID: <2fe95bcd-c3b5-09de-067d-fe986b01f890@gutov.dev> References: <87v8ddsqwe.fsf@web.de> <797b4f1c-222e-14c0-c802-6f23090c9c1f@gutov.dev> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------2gna7GsZ14y3LBH1D3iSLRJD" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6254"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: emacs-devel To: Felix Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Aug 17 17:02:35 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qWeW8-0001QO-Q6 for ged-emacs-devel@m.gmane-mx.org; Thu, 17 Aug 2023 17:02:33 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qWeV5-0007US-1m; Thu, 17 Aug 2023 11:01:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWeV3-0007U6-Em for emacs-devel@gnu.org; Thu, 17 Aug 2023 11:01:25 -0400 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWeV0-0004jO-Sj for emacs-devel@gnu.org; Thu, 17 Aug 2023 11:01:25 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id CC46C5C015A; Thu, 17 Aug 2023 11:01:21 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 17 Aug 2023 11:01:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1692284481; x=1692370881; bh=Lz LhxcYXszfxycy8mk5psYiBV3ilKjgHKTbkpExgN04=; b=LElk/kvANx2E+gD+cX oiiGyeOxpE00F9h3BWJSwowroC7UknDbANOJoAi3F1orr3hpoAHLCUZUdjcafOFD QhiBRKOHD4ZvlUfdRl2g19HkBgIzWFrF+PSQVJErgJ939WQ4KFwyU9ovVE17oNeM o4UU43vzHGFsZLRSb5npyPAV8u0PB2cngeDVevEKLMg4nHssL3P60Tx2WeHXvRby iCrXuMAolwuJ5er8S3lVhS5KqabrHinCzTmT2lCD2Qv4KeJ8RBMMEWizJNm5M/Jz FW63ct2g7d4BciMPJQKO3LQQZcGyRGAE5pjz309oKR6O4GKc/ZX8A31Y+n8ekfd7 tKXA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1692284481; x=1692370881; bh=LzLhxcYXszfxy cy8mk5psYiBV3ilKjgHKTbkpExgN04=; b=MQxeTTz7pCmCZ+4S/9Hft+ZL8oiPB 76znmTltkEc4dBKLEUtVVFsfPZXZL6BzZ90b7FG7DMGJi/M9faEGMg8lGSTBp4jn TXe7Ra109ISkEHys1i35oqAxWcd7+fiHIejCB9TABu7L2HSmjeSQngXgv+/34cqT /suC05IqgDqySU96u4YfAzP6rTBAjKhxROlEkaJz1oj8oG4w6KjPI7MfdXaI3UOd pzmHHgmB+ZOWrQz16Hj+iGe2yWMXsBrOneCEy01gg5QVo2M80XpG4ncvFyb0OjyE 1AtW2S0BgGjpXGYF6RAuv39Ma/xwzZOFZUtYvxlYltL3eTioPMgdLWJzA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudduuddgkeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpegtkfffgggfuffhvfevfhgjsehmtd erredtfeejnecuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegumhhithhrhiesghhu thhovhdruggvvheqnecuggftrfgrthhtvghrnhepieehgeektefggfehhfegieevueduge dvueetfffhtedtleelheekffelvddutdelnecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 17 Aug 2023 11:01:20 -0400 (EDT) Content-Language: en-US In-Reply-To: Received-SPF: pass client-ip=66.111.4.25; envelope-from=dmitry@gutov.dev; helo=out1-smtp.messagingengine.com X-Spam_score_int: -67 X-Spam_score: -6.8 X-Spam_bar: ------ X-Spam_report: (-6.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-4.01, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308873 Archived-At: This is a multi-part message in MIME format. --------------2gna7GsZ14y3LBH1D3iSLRJD Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 17/08/2023 17:36, Dmitry Gutov wrote: > On 17/08/2023 17:25, Dmitry Gutov wrote: >> On 17/08/2023 17:08, Felix wrote: >>> Hi, >>> >>> I tried that patch, and it crashes emacs whenever i try to scroll inside >>> a tree-sitter managed buffer. >>> >>> GNU Emacs 30.0.50 (build 22, x86_64-pc-linux-gnu, GTK+ Version >>> 3.24.38, cairo version 1.17.8) of 2023-08-17 >>> >>> compiled with pgtk running on wayland. >> >> Thanks for testing. Does that happen in any ts mode, or some >> particular ones? >> >> If you run Emacs from the terminal, could you post the error backtrace? >> >> (Please keep emacs-devel in Cc). > > For my part, I don't see it crash when scrolling (in ruby-ts-mdoe or > js-ts-mode, including larges files), but the test scenario by JD does > make it crash. > > When running under GDB, the backtrace simply looks like this: > > #0  0x00007ffff63bf93d in ts_tree_root_node (self=0x0) at lib/src/tree.c:36 > #1  0x00007ffff63a54e5 in ts_node_parent (self=...) at lib/src/node.c:462 > #2  0x00005555557f0d17 in Ftreesit_node_parent > (node=XIL(0x5555574908c5)) at treesit.c:1906 > #3  0x000055555576f62b in eval_sub (form=) at eval.c:2511 > #4  0x000055555576f987 in Fsetq (args=) at eval.c:483 > #5  0x000055555576f368 in eval_sub (form=) at eval.c:2462 > #6  0x000055555576ff75 in Fprogn (body=XIL(0)) at eval.c:436 > ... Try this one. I've read the tree-sitter docs a bit more, and also dropped the "else" case because it was unreachable anyway. I doesn't crash anymore here. --------------2gna7GsZ14y3LBH1D3iSLRJD Content-Type: text/x-patch; charset=UTF-8; name="treesit-node-parent.diff" Content-Disposition: attachment; filename="treesit-node-parent.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL3NyYy90cmVlc2l0LmMgYi9zcmMvdHJlZXNpdC5jCmluZGV4IDFmNjk0 ZTQ3MjAxLi40NmZiYWNhZWZlMyAxMDA2NDQKLS0tIGEvc3JjL3RyZWVzaXQuYworKysgYi9z cmMvdHJlZXNpdC5jCkBAIC01Miw2ICs1Miw3IEBAIENvcHlyaWdodCAoQykgMjAyMS0yMDIz IEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwgSW5jLgogI3VuZGVmIHRzX25vZGVfbmFtZWRf ZGVzY2VuZGFudF9mb3JfYnl0ZV9yYW5nZQogI3VuZGVmIHRzX25vZGVfbmV4dF9uYW1lZF9z aWJsaW5nCiAjdW5kZWYgdHNfbm9kZV9uZXh0X3NpYmxpbmcKKyN1bmRlZiB0c19ub2RlX3Bh cmVudAogI3VuZGVmIHRzX25vZGVfcHJldl9uYW1lZF9zaWJsaW5nCiAjdW5kZWYgdHNfbm9k ZV9wcmV2X3NpYmxpbmcKICN1bmRlZiB0c19ub2RlX3N0YXJ0X2J5dGUKQEAgLTE4OTUsMjEg KzE4OTYsMTUgQEAgREVGVU4gKCJ0cmVlc2l0LW5vZGUtcGFyZW50IiwKICAgdHJlZXNpdF9j aGVja19ub2RlIChub2RlKTsKICAgdHJlZXNpdF9pbml0aWFsaXplICgpOwogCi0gIExpc3Bf T2JqZWN0IHJldHVybl92YWx1ZSA9IFFuaWw7Ci0KICAgVFNOb2RlIHRyZWVzaXRfbm9kZSA9 IFhUU19OT0RFIChub2RlKS0+bm9kZTsKICAgTGlzcF9PYmplY3QgcGFyc2VyID0gWFRTX05P REUgKG5vZGUpLT5wYXJzZXI7Ci0gIFRTVHJlZUN1cnNvciBjdXJzb3I7Ci0gIGlmICghdHJl ZXNpdF9jdXJzb3JfaGVscGVyICgmY3Vyc29yLCB0cmVlc2l0X25vZGUsIHBhcnNlcikpCi0g ICAgcmV0dXJuIHJldHVybl92YWx1ZTsKIAotICBpZiAodHNfdHJlZV9jdXJzb3JfZ290b19w YXJlbnQgKCZjdXJzb3IpKQotICB7Ci0gICAgVFNOb2RlIHBhcmVudCA9IHRzX3RyZWVfY3Vy c29yX2N1cnJlbnRfbm9kZSAoJmN1cnNvcik7Ci0gICAgcmV0dXJuX3ZhbHVlID0gbWFrZV90 cmVlc2l0X25vZGUgKHBhcnNlciwgcGFyZW50KTsKLSAgfQotICB0c190cmVlX2N1cnNvcl9k ZWxldGUgKCZjdXJzb3IpOwotICByZXR1cm4gcmV0dXJuX3ZhbHVlOworICBUU05vZGUgcGFy ZW50ID0gdHNfbm9kZV9wYXJlbnQgKHRyZWVzaXRfbm9kZSk7CisKKyAgaWYgKHRzX25vZGVf aXNfbnVsbCAocGFyZW50KSkKKyAgICByZXR1cm4gUW5pbDsKKworICByZXR1cm4gbWFrZV90 cmVlc2l0X25vZGUgKHBhcnNlciwgcGFyZW50KTsKIH0KIAogREVGVU4gKCJ0cmVlc2l0LW5v ZGUtY2hpbGQiLAo= --------------2gna7GsZ14y3LBH1D3iSLRJD--