From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#16969: Isearch: lazy-highlight face sometimes has foreground and background the same colour. Date: Sun, 9 Mar 2014 15:20:48 -0700 (PDT) Message-ID: <2fe64fe3-c241-46a9-87d3-2c80b8bc1d9e@default> References: <20140308183550.GA2726@acm.acm> <871tycfj8e.fsf@mail.jurta.org> <531BB993.6060507@dancol.org> <87siqroxnr.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1394403742 3567 80.91.229.3 (9 Mar 2014 22:22:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 9 Mar 2014 22:22:22 +0000 (UTC) Cc: Alan Mackenzie , 16969@debbugs.gnu.org To: Juri Linkov , Daniel Colascione Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 09 23:22:29 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WMm71-0004jp-2z for geb-bug-gnu-emacs@m.gmane.org; Sun, 09 Mar 2014 23:22:27 +0100 Original-Received: from localhost ([::1]:45720 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WMm70-0004mH-Lw for geb-bug-gnu-emacs@m.gmane.org; Sun, 09 Mar 2014 18:22:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54762) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WMm6p-0004b4-8h for bug-gnu-emacs@gnu.org; Sun, 09 Mar 2014 18:22:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WMm6g-0007fu-Ma for bug-gnu-emacs@gnu.org; Sun, 09 Mar 2014 18:22:15 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57264) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WMm6g-0007fq-Ja for bug-gnu-emacs@gnu.org; Sun, 09 Mar 2014 18:22:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WMm6c-0001jv-B9 for bug-gnu-emacs@gnu.org; Sun, 09 Mar 2014 18:22:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Mar 2014 22:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16969 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16969-submit@debbugs.gnu.org id=B16969.13944036666585 (code B ref 16969); Sun, 09 Mar 2014 22:22:02 +0000 Original-Received: (at 16969) by debbugs.gnu.org; 9 Mar 2014 22:21:06 +0000 Original-Received: from localhost ([127.0.0.1]:58446 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WMm5i-0001i9-2I for submit@debbugs.gnu.org; Sun, 09 Mar 2014 18:21:06 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:20507) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WMm5f-0001hw-OP for 16969@debbugs.gnu.org; Sun, 09 Mar 2014 18:21:04 -0400 Original-Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s29MKoJr018772 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 9 Mar 2014 22:20:51 GMT Original-Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s29MKkrF011798 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 9 Mar 2014 22:20:47 GMT Original-Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s29MKkDe020764; Sun, 9 Mar 2014 22:20:46 GMT In-Reply-To: <87siqroxnr.fsf@mail.jurta.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:86697 Archived-At: > We need to guarantee that default faces don't produce > illegible combinations of foreground and background colors. Yes, that is the _only_ *need* here. It is the need raised by the bug. And the simplest and most foolproof way to fulfill that need and fix the bug is to simply give face `lazy-highlight', by default, a black/white foreground for a light/dark background mode. Just as we do already for face `isearch', and just as we have always done. That should have been done for `lazy-highlight' long ago. End of story. Any user who wants to fiddle with the new "feature" that lets other highlighting show through and tries to adjust colors automatically can always customize these search-hit faces to get that new effect. There is no reason to impose this gimmick on Emacs users now by _default_. Today's flashy new feature is too often tomorrow's out-of-fashion annoyance. Just stick with what is simple and has always worked well. If, after a few years, we find that _most users choose_ to customize to get the new effect, we can then turn it on by default. There is no reason to jump to that now. It amazes me that it took so long and was such a bloody battle to get something like `transient-mark-mode' turned on by default, even though users commonly customized Emacs for decades to turn it on, and yet you are ready to willy nilly change longstanding default behavior such as this before the new behavior has even been offered as a possibility for users to _choose_. It hasn't even been released yet, and you already want to make it the default. First things first: turn on `delete-selection-mode' by default, why dontcha? And offer this new highlighting style as an _option_ for now: opt in, not opt out, for the new. Consider making it the default behavior only later, after you have had a chance to see how many users actually choose it. Don't get carried away by your enthusiasm for your shiny new object.