From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#23377: 25.0.93; Completion is extremely slow for insert-char Date: Mon, 25 Apr 2016 18:04:43 -0700 Organization: UCLA Computer Science Department Message-ID: <2fd9a9b4-fb49-da6e-f13b-0fce4708159a@cs.ucla.edu> References: <87wpnlnrlz.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------CEE9D42AF49F2C8097EB4061" X-Trace: ger.gmane.org 1461632724 6103 80.91.229.3 (26 Apr 2016 01:05:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 26 Apr 2016 01:05:24 +0000 (UTC) Cc: 23377@debbugs.gnu.org, Stefan Monnier To: "N. Jackson" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 26 03:05:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aurR8-0006oP-5h for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Apr 2016 03:05:10 +0200 Original-Received: from localhost ([::1]:35767 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aurR7-0006Iu-AO for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 Apr 2016 21:05:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33910) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aurR4-0006Fc-0I for bug-gnu-emacs@gnu.org; Mon, 25 Apr 2016 21:05:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aurQz-0007pc-WA for bug-gnu-emacs@gnu.org; Mon, 25 Apr 2016 21:05:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34863) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aurQz-0007pM-Sf for bug-gnu-emacs@gnu.org; Mon, 25 Apr 2016 21:05:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1aurQz-0007fT-Mt for bug-gnu-emacs@gnu.org; Mon, 25 Apr 2016 21:05:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <87wpnlnrlz.fsf@gmail.com> Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Apr 2016 01:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23377 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23377-submit@debbugs.gnu.org id=B23377.146163269529457 (code B ref 23377); Tue, 26 Apr 2016 01:05:01 +0000 Original-Received: (at 23377) by debbugs.gnu.org; 26 Apr 2016 01:04:55 +0000 Original-Received: from localhost ([127.0.0.1]:47200 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aurQt-0007f3-3H for submit@debbugs.gnu.org; Mon, 25 Apr 2016 21:04:55 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:39424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aurQr-0007eo-AQ for 23377@debbugs.gnu.org; Mon, 25 Apr 2016 21:04:53 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 4FF5D16124C; Mon, 25 Apr 2016 18:04:47 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Axs08wcxQiao; Mon, 25 Apr 2016 18:04:46 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 98B2616125C; Mon, 25 Apr 2016 18:04:46 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id k9LgsTZjrmKm; Mon, 25 Apr 2016 18:04:46 -0700 (PDT) Original-Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 7E5EC16124C; Mon, 25 Apr 2016 18:04:46 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:116844 Archived-At: This is a multi-part message in MIME format. --------------CEE9D42AF49F2C8097EB4061 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Thanks, I reproduced the problem and yes, it is wayyy too slow. Also, the code in question has some FIXMEs that have not been fixed. Since we're trying to push out a new release, at this point we should probably revert the relevant change and think about how to do this sort of thing in a better way in a later release. Proposed patch attached. --------------CEE9D42AF49F2C8097EB4061 Content-Type: application/x-patch; name="0001-Do-not-show-chars-in-C-x-8-RET-completions.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Do-not-show-chars-in-C-x-8-RET-completions.patch" RnJvbSA2ZTA0MmRhYTU3YmUwMTNiYzU2OWU5YTU2ZjlhY2I5NGVlNmU5NDg3IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QHBlbmd1aW4uY3Mu dWNsYS5lZHU+CkRhdGU6IE1vbiwgMjUgQXByIDIwMTYgMTc6NTQ6MzYgLTA3MDAKU3ViamVj dDogW1BBVENIXSBEbyBub3Qgc2hvdyBjaGFycyBpbiBDLXggOCBSRVQgY29tcGxldGlvbnMK Ckl0IGlzIHdheSB0b28gc2xvdyBpbiB0aGUgY29tbW9uIHVzZSBjYXNlIG9mIEMteCA4IFJF VCBUQUIuClByb2JsZW0gcmVwb3J0ZWQgYnkgTi4gSmFja3NvbiAoQnVnIzIzMzc3KS4KKiBs aXNwL2ludGVybmF0aW9uYWwvbXVsZS1jbWRzLmVsIChtdWxlLS11Y3MtbmFtZXMtYW5ub3Rh dGlvbik6ClJlbW92ZS4gIEFsbCB1c2VzIHJlbW92ZWQuClRoaXMgcmV2ZXJ0cyAyMDE1LTAz LTI1VDE3OjQ1OjM0WiFtb25uaWVyQGlyby51bW9udHJlYWwuY2EuCi0tLQogbGlzcC9pbnRl cm5hdGlvbmFsL211bGUtY21kcy5lbCB8IDEyICstLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5n ZWQsIDEgaW5zZXJ0aW9uKCspLCAxMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNw L2ludGVybmF0aW9uYWwvbXVsZS1jbWRzLmVsIGIvbGlzcC9pbnRlcm5hdGlvbmFsL211bGUt Y21kcy5lbAppbmRleCBkYmYxMjI0Li5jMGEwMzU1IDEwMDY0NAotLS0gYS9saXNwL2ludGVy bmF0aW9uYWwvbXVsZS1jbWRzLmVsCisrKyBiL2xpc3AvaW50ZXJuYXRpb25hbC9tdWxlLWNt ZHMuZWwKQEAgLTI5NzAsMTQgKzI5NzAsNiBAQCB1Y3MtbmFtZXMKIAk7OyBjaGFyIHdpdGgg dGhhdCBuYW1lLgogCShzZXRxIHVjcy1uYW1lcyBgKCgiQkVMTCAoQkVMKSIgLiA3KSAsQG5h bWVzKSkpKSkKIAotKGRlZnVuIG11bGUtLXVjcy1uYW1lcy1hbm5vdGF0aW9uIChuYW1lKQot ICA7OyBGSVhNRTogSXQgd291bGQgYmUgbXVjaCBiZXR0ZXIgdG8gYWRkIHRoaXMgYW5ub3Rh dGlvbiBiZWZvcmUgcmF0aGVyIHRoYW4KLSAgOzsgYWZ0ZXIgdGhlIGNoYXIgbmFtZSwgc28g dGhlIGFubm90YXRpb25zIGFyZSBhbGlnbmVkLgotICA7OyBGSVhNRTogVGhlIGRlZmF1bHQg YmVoYXZpb3Igb2YgZGlzcGxheWluZyBhbm5vdGF0aW9ucyBpbiBpdGFsaWNzCi0gIDs7IGRv ZXNuJ3Qgd29yayB3ZWxsIGhlcmUuCi0gIChsZXQgKChjaGFyIChhc3NvYyBuYW1lIHVjcy1u YW1lcykpKQotICAgICh3aGVuIGNoYXIgKGZvcm1hdCAiICglYykiIChjZHIgY2hhcikpKSkp Ci0KIChkZWZ1biByZWFkLWNoYXItYnktbmFtZSAocHJvbXB0KQogICAiUmVhZCBhIGNoYXJh Y3RlciBieSBpdHMgVW5pY29kZSBuYW1lIG9yIGhleCBudW1iZXIgc3RyaW5nLgogRGlzcGxh eSBQUk9NUFQgYW5kIHJlYWQgYSBzdHJpbmcgdGhhdCByZXByZXNlbnRzIGEgY2hhcmFjdGVy IGJ5IGl0cwpAQCAtMzAwMSw5ICsyOTkzLDcgQEAgcmVhZC1jaGFyLWJ5LW5hbWUKIAkgICBw cm9tcHQKIAkgICAobGFtYmRhIChzdHJpbmcgcHJlZCBhY3Rpb24pCiAJICAgICAoaWYgKGVx IGFjdGlvbiAnbWV0YWRhdGEpCi0JCSAnKG1ldGFkYXRhCi0JCSAgIChhbm5vdGF0aW9uLWZ1 bmN0aW9uIC4gbXVsZS0tdWNzLW5hbWVzLWFubm90YXRpb24pCi0JCSAgIChjYXRlZ29yeSAu IHVuaWNvZGUtbmFtZSkpCisJCSAnKG1ldGFkYXRhIChjYXRlZ29yeSAuIHVuaWNvZGUtbmFt ZSkpCiAJICAgICAgIChjb21wbGV0ZS13aXRoLWFjdGlvbiBhY3Rpb24gKHVjcy1uYW1lcykg c3RyaW5nIHByZWQpKSkpKQogCSAoY2hhcgogCSAgKGNvbmQKLS0gCjIuNS41Cgo= --------------CEE9D42AF49F2C8097EB4061--