From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#71450: [PATCH] Wrong eww-history-position after desktop restore if within history Date: Sun, 9 Jun 2024 14:20:56 -0700 Message-ID: <2fd89234-fab9-a0a3-3bc1-f193983e2cd4@gmail.com> References: <86h6e21f0e.fsf@outlook.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30724"; mail-complaints-to="usenet@ciao.gmane.io" To: James Thomas , 71450@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 09 23:41:36 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sGQIB-0007uH-Sj for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Jun 2024 23:41:35 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sGQHQ-00081E-EB; Sun, 09 Jun 2024 17:40:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGQHO-0007zo-JT for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2024 17:40:46 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sGQHO-00030A-Ah for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2024 17:40:46 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sGQHe-0000Kh-ST for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2024 17:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Jun 2024 21:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71450 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71450-submit@debbugs.gnu.org id=B71450.17179692311151 (code B ref 71450); Sun, 09 Jun 2024 21:41:02 +0000 Original-Received: (at 71450) by debbugs.gnu.org; 9 Jun 2024 21:40:31 +0000 Original-Received: from localhost ([127.0.0.1]:34445 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGQH9-0000IQ-4W for submit@debbugs.gnu.org; Sun, 09 Jun 2024 17:40:31 -0400 Original-Received: from mail-qv1-f43.google.com ([209.85.219.43]:53322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGQ63-00088H-Bl for 71450@debbugs.gnu.org; Sun, 09 Jun 2024 17:29:05 -0400 Original-Received: by mail-qv1-f43.google.com with SMTP id 6a1803df08f44-6afbbc87967so24571006d6.2 for <71450@debbugs.gnu.org>; Sun, 09 Jun 2024 14:28:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717968460; x=1718573260; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=Ha864EUr7cuK03oR6ERahNFKaRnhAA3Q5laEd0FiVso=; b=QgyZZC2VPB4Uqh3e5HyaAHo5IbVickwG3JQgKkSlqbOs3OcIbo4Sg2KVdsRPNdJkOz JjKEDQ3jR2C5rF0ZeA0ngjiIWusQZYYkPmTfaeVLzAqNuC+ec46c7Okgvv/Qfs8N4RVB Q3QEs7jFCFtZnl2+kA4ycEsPnqoKMpy+VVaSwznbFSqtdTzZEdgjLZxGqudDiMc1Wgw9 mRbQEZRPxh4dMGp3pAUXHs9yWHqJWagEQjYULFAMPC+w3KyZAuQrfJQRww3OSHCHJI7g DHVIF2tSJPjhtlseWh4witUZ6ra25L6dRx2Ei/Ux/oCanbAb9DYjdy7SMZHM8p0RaaAh SJ5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717968460; x=1718573260; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ha864EUr7cuK03oR6ERahNFKaRnhAA3Q5laEd0FiVso=; b=ZyxDREUsgwfvEjba+Qx9Hk04z954jZojGruK69OsGFC09Jv58wlUGUF9mR+PemuLR2 Y6ME3kzCHK6SL8MBJPzEjwVNecL7LDkL8r70lHvgkVpKKLx5vOF2kelfNvgW/UYGFbJs rHno7XIXicLyFOf/YWq1Q6pYfhWaLBp/QESRE3utb6Yolwd3pDexzhpjdk70gu8L0Bcs YodUDRmHlsqyofjCrrNvPHh0NrkcBT90c0StpG/nRLZ7kQHyagnmhL9VzvyHuEZtzjDF djTx5K5qL3MrdNcDRTkvLyU+NKITHZZFko/2qPgvzoosJDn+wK1Z2xIzS5YLDHTmVTB8 jN3g== X-Forwarded-Encrypted: i=1; AJvYcCXWxH1WI2+KAwIZJQyYlwvyNKOgMMd6LwAseNJTu2tx1tcklfQkjW3+GiemkGeqLu64gfw1b4FfWPZJJ6oHNlpc6kWEtxo= X-Gm-Message-State: AOJu0YyVA4WzBNDp78S1uxkbz00Gd2s+WdHot3shfEcxlYclVSH2Hj9I p7Vk7qtQyhWYY49YMYcq71otZ+lci+hbB5Fb1Hwpte5/Mcxz+RJBNvBt+Q== X-Google-Smtp-Source: AGHT+IG/ItrnMqi+BmBmqdPJZ6VECRYBvzd+mrjRBZr/5h0LA2WnnUxEDbQYcxod9JC8jITVqyxO9w== X-Received: by 2002:a05:6a00:2e9b:b0:704:32f6:8986 with SMTP id d2e1a72fcca58-70432f6ac4amr3002567b3a.17.1717968056936; Sun, 09 Jun 2024 14:20:56 -0700 (PDT) Original-Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-70428c93f30sm2571664b3a.37.2024.06.09.14.20.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 09 Jun 2024 14:20:56 -0700 (PDT) Content-Language: en-US In-Reply-To: <86h6e21f0e.fsf@outlook.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286987 Archived-At: On 6/9/2024 5:23 AM, James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > This is a patch that I think is simple enough to forgo the extensive > testing which it hasn't been subjected to. Thanks for the patch. > + :history-position > + (cl-position > + (elt history eww-history-position) > + rval :test #'eww-desktop-history-duplicate)))) Two questions here: 1. Is that the right test function? I'd have expected 'eq', since we want to find the position where our history index has moved to, right? 2. Should this part check for 'eww-desktop-remove-duplicates' too? If that option is nil, I think we could avoid the 'cl-position' call. Or maybe lift the 'eww-desktop-remove-duplicates' call outside of the 'list' and just construct two totally different lists in the THEN/ELSE blocks.