all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Artur Malabarba <bruce.connor.am@gmail.com>
Cc: emacs-devel@gnu.org
Subject: RE: sea-level rise of byte-compilation warnings  [was: Fixing...byte-compilation warnings...]
Date: Mon, 16 Nov 2015 15:52:17 -0800 (PST)	[thread overview]
Message-ID: <2f908b2b-7e0c-462e-bfe8-75dff515b3b7@default> (raw)
In-Reply-To: <87y4dxy096.fsf@gmail.com>

> In my experience, 90% of the superfluous warnings are silenced by a
> `defvar' or a `declare-function'. Finally, with-no-warnings should cover
> the last 10. If this isn't well documented it really should be.

Those are not supported in all Emacs versions.  That is the reason
I don't use them in some libraries.

> > The degree of warning is now overkill in many contexts
> > (even for novices, it could be argued).
> 
> I don't usually feel overwhelmed by the warnings. Most of my elisp files
> have 0 to 3 of these warning-suppressing forms. Only the really large
> projects with 10+ files end up having a lot.

Different users will get different floods of warnings.  The older
the Emacs versions your libraries support, the deeper the flood,
other things being equal.

The warnings don't really bother me.  What bothers me somewhat
are the fact that they bother users of my libraries.  I need to
let them know that there is no problem.

> I'm curious what are your contexts. I guess you're supporting Emacs
> versions < 24.1?

I am, for many of my libraries, but not for all.  If a new library
makes use of constructs from Emacs N then I generally support only
N and greater.

> > What is needed is to:
> >
> > * be able to notice the important ones, while also
> >   showing ones that are less important
> 
> Different warning levels might be nice, but (looking at
> `byte-compile-warnings') the only warnings that don't immediately mean
> “this code might break” are the `cl-functions', `obsolete', and
> `mapcar'. So I don't know how much it would help your warning flood.

`obsolete' certainly does.  I continue to (and will continue to) use
"obsolete" constructs.

But the topic is not about me or my use.  It's a general topic.

> > * be able to have the code itself easily (and
> >   conditionally) inhibit them - as a whole or by type
> 
> Like I said, with-no-warnings inhibits them locally, but I perfectly
> agree there should be a way to suppress warnings on a file-local (and
> maybe dir-local) basis.

(FWIW, `with-no-warnings' is not available in Emacs 20.
Lots of my code works also in Emacs 20, intentionally.)

> > FWIW, my crystal ball whispers that just analyzing
> > the code for sexps that are protected by `fboundp'
> > might go a long way toward eliminating many spurious
> > warnings.
> 
> My psychic senses agree.



  reply	other threads:[~2015-11-16 23:52 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-13  1:47 Fixing compilation and byte-compilation warnings before 25.1 John Wiegley
2015-11-13 12:18 ` Juanma Barranquero
2015-11-13 14:40 ` Andreas Röhler
2015-11-13 15:37   ` Artur Malabarba
2015-11-14  8:34     ` Andreas Röhler
2015-11-13 15:46   ` John Wiegley
2015-11-13 16:22     ` Paul Eggert
2015-11-13 23:00       ` John Wiegley
2015-11-14  5:54         ` daniel sutton
2015-11-14 10:58           ` Michael Heerdegen
2015-11-14 18:22             ` daniel sutton
2015-11-15 12:41               ` Michael Heerdegen
2015-11-16 14:15                 ` daniel sutton
2015-11-16 23:24                   ` Artur Malabarba
2015-11-15 16:07               ` sea-level rise of byte-compilation warnings [was: Fixing...byte-compilation warnings...] Drew Adams
2015-11-15 16:42                 ` daniel sutton
2015-11-15 17:38                   ` Drew Adams
2015-11-15 17:47                     ` daniel sutton
2015-11-15 22:39                       ` Drew Adams
2015-11-16 23:48                 ` Artur Malabarba
2015-11-16 23:52                   ` Drew Adams [this message]
2015-11-17  0:09                     ` Artur Malabarba
2015-11-17 15:45                       ` Drew Adams
2015-11-17  3:59                   ` Ivan Andrus
2015-11-14 15:23           ` Fixing compilation and byte-compilation warnings before 25.1 Andy Moreton
2015-11-14 10:55 ` Stephen Leake
2015-11-14 16:00   ` John Wiegley
2015-11-14 18:01     ` Stephen Leake
2015-11-15  9:08     ` David Engster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f908b2b-7e0c-462e-bfe8-75dff515b3b7@default \
    --to=drew.adams@oracle.com \
    --cc=bruce.connor.am@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.