From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Daniel Colascione" Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 1072155: Avoid duplicate entries in process-environment after re-dumping Date: Wed, 3 Apr 2019 09:58:35 -0700 Message-ID: <2f59c1ff3d4ad006c09634813e6724b8.squirrel@dancol.org> References: <20190321155613.6127.22574@vcs0.savannah.gnu.org> <20190321155614.E6343209B2@vcs0.savannah.gnu.org> <892097f7bc3f5e0ac88d31c60e0bed59.squirrel@dancol.org> <834l7gfbxn.fsf@gnu.org> <369aae77db760bfe079e47254470001d.squirrel@dancol.org> <83h8bfe94g.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="65151"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: SquirrelMail/1.4.23 [SVN] Cc: Daniel Colascione , emacs-devel@gnu.org To: "Eli Zaretskii" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 03 18:59:22 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hBjEP-000Go1-JD for ged-emacs-devel@m.gmane.org; Wed, 03 Apr 2019 18:59:22 +0200 Original-Received: from localhost ([127.0.0.1]:32980 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBjEO-0007zy-Gg for ged-emacs-devel@m.gmane.org; Wed, 03 Apr 2019 12:59:20 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37873) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBjDn-0007zi-Ng for emacs-devel@gnu.org; Wed, 03 Apr 2019 12:58:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hBjDm-0003a1-Nx for emacs-devel@gnu.org; Wed, 03 Apr 2019 12:58:43 -0400 Original-Received: from dancol.org ([2600:3c01::f03c:91ff:fedf:adf3]:35248) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hBjDg-00036s-8u; Wed, 03 Apr 2019 12:58:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:To:From:Subject:Date:References:In-Reply-To:Message-ID; bh=5/h87AHqEV1qkj0l0qrsTPepBB6KPUURSLGr1KTP63Y=; b=cap7605qrm5PV0MAN7ZRoYGc4kWnwHuvka4khC3Rk6M36NU5gOSP74J6aWBAQBAcfJGuy2asXjpuiEHJgKbBa+hsFJMXwN3XdvSn7j5EpqjPpzDLTtvFFDudklTninr7ScJQT7XFiwhwQR42dgh2zdXlerdPwMZiYKXN4NIW47EShrbtlImZxidW0w70XwWqtzB5wI5xYkVniJ4ajxwt8aadqcTExY190Tp8rkH5EMTDFDNGfCCyzD3Oea4QW7JrBBH1nXh7/v6zUZkcV5yLhuySBftEiuTRlOfuguiRVGgj8QmfYwbmXMj0DqnkpSdbr9YzthANX1yaG7syUQvsbg==; Original-Received: from localhost ([127.0.0.1] helo=dancol.org) by dancol.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBjDf-0003Pf-29; Wed, 03 Apr 2019 09:58:35 -0700 Original-Received: from 127.0.0.1 (SquirrelMail authenticated user dancol) by dancol.org with HTTP; Wed, 3 Apr 2019 09:58:35 -0700 In-Reply-To: <83h8bfe94g.fsf@gnu.org> X-Priority: 3 (Normal) Importance: Normal X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2600:3c01::f03c:91ff:fedf:adf3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234922 Archived-At: >> Date: Tue, 2 Apr 2019 13:11:53 -0700 >> From: "Daniel Colascione" >> Cc: "Daniel Colascione" , >> emacs-devel@gnu.org >> >> >> Don't we want to reset process-environment to its old value in >> >> dump_unwind_cleanup? >> > >> > You are thinking about re-dumping from an interactive session? >> >> Yes >> >> > In >> > that case, probably yes. But currently we only support dumping from >> > batch sessions, and in that case I don't see a need to restore >> > process-environment, am I missing something? >> >> We "support" dumping only from dedicated batch instances in that for now >> we should consider only bugs in that use case release-blocking, but I >> don't want to gratuitously break other use cases like dumping >> interactive >> sessions without killing them, since these use cases are meant to work >> and >> we'll give them the same level of support someday soon. > > OK, but is there any reason dump_unwind_cleanup doesn't restore > post-gc-hook? Omission? Not restoring post-gc-hook is a bug. Thanks for spotting that!