Re: Reformat all of src/

["Phillip Lord" <phillip.lord@russet.org.uk>]

On Thu, December 29, 2016 4:17 pm, Eli Zaretskii wrote:
>> Date: Thu, 29 Dec 2016 13:18:59 -0000
>> From: "Phillip Lord" <phillip.lord@russet.org.uk>
>> Cc: Phillip Lord <phillip.lord@russet.org.uk>, emacs-devel@gnu.org,
>> Dmitry Gutov <dgutov@yandex.ru>
>>
>>
>> I just checked and I think that comparing git diff --numstat output
>> with and without -b should identify when whitespace-only changes have
>> happened; this could be caught in the commit hook.
>
> Every mandatory check in the commit hook is a potential annoyance
> (think of someone, such as myself, who needs to push changes for
> others), so I'd prefer not to add any, unless we really must

When you say "push" changes, I guess you mean commit patches? AFAICT,
commit hooks do not run on pushes, so there should be no problem. But,
yes, for patches, then indeed if it is you applying them, then you will be
affected by the commit hook.

On the other hand, if the person who creates the patch uses git to do so,
the commit hook should affect their local commit when creating the patch.
Likewise with pull requests.

But, I agree, it is a small additional hassle.

Phil