From: "Phillip Lord" <phillip.lord@russet.org.uk>
To: "Eli Zaretskii" <eliz@gnu.org>
Cc: emacs-devel@gnu.org, eggert@cs.ucla.edu, dgutov@yandex.ru,
Phillip Lord <phillip.lord@russet.org.uk>
Subject: Re: Reformat all of src/
Date: Fri, 30 Dec 2016 10:30:23 -0000 [thread overview]
Message-ID: <2ef9531effde4d1639e69c7520af2bc0.squirrel@cloud103.planethippo.com> (raw)
In-Reply-To: <83zijeu2tu.fsf@gnu.org>
On Thu, December 29, 2016 4:17 pm, Eli Zaretskii wrote:
>> Date: Thu, 29 Dec 2016 13:18:59 -0000
>> From: "Phillip Lord" <phillip.lord@russet.org.uk>
>> Cc: Phillip Lord <phillip.lord@russet.org.uk>, emacs-devel@gnu.org,
>> Dmitry Gutov <dgutov@yandex.ru>
>>
>>
>> I just checked and I think that comparing git diff --numstat output
>> with and without -b should identify when whitespace-only changes have
>> happened; this could be caught in the commit hook.
>
> Every mandatory check in the commit hook is a potential annoyance
> (think of someone, such as myself, who needs to push changes for
> others), so I'd prefer not to add any, unless we really must
When you say "push" changes, I guess you mean commit patches? AFAICT,
commit hooks do not run on pushes, so there should be no problem. But,
yes, for patches, then indeed if it is you applying them, then you will be
affected by the commit hook.
On the other hand, if the person who creates the patch uses git to do so,
the commit hook should affect their local commit when creating the patch.
Likewise with pull requests.
But, I agree, it is a small additional hassle.
Phil
next prev parent reply other threads:[~2016-12-30 10:30 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-28 0:59 Reformat all of src/ Chris Gregory
2016-12-28 3:43 ` Stefan Monnier
2016-12-28 4:45 ` John Wiegley
2016-12-28 4:52 ` Chris Gregory
2016-12-28 5:01 ` Chris Gregory
2016-12-28 12:58 ` Phillip Lord
2016-12-28 15:35 ` John Yates
2016-12-28 15:39 ` Lars Ingebrigtsen
2016-12-28 16:01 ` John Yates
2016-12-28 16:27 ` Lars Ingebrigtsen
2016-12-28 16:17 ` Phillip Lord
2016-12-28 17:19 ` Stefan Monnier
2016-12-28 17:35 ` Phillip Lord
2016-12-28 17:52 ` Stefan Monnier
2016-12-28 17:59 ` Eli Zaretskii
2016-12-28 16:32 ` Yuri Khan
2016-12-28 16:37 ` Lars Ingebrigtsen
2016-12-28 16:56 ` Yuri Khan
2016-12-28 16:59 ` John Wiegley
2016-12-28 17:12 ` Yuri Khan
2016-12-28 17:20 ` Phillip Lord
2016-12-28 18:38 ` Paul Eggert
2016-12-29 1:10 ` Dmitry Gutov
2016-12-29 5:53 ` Paul Eggert
2016-12-29 11:28 ` Dmitry Gutov
2016-12-30 1:07 ` Paul Eggert
2016-12-30 10:34 ` Phillip Lord
2017-01-01 1:14 ` Dmitry Gutov
2016-12-29 13:18 ` Phillip Lord
2016-12-29 16:17 ` Eli Zaretskii
2016-12-29 17:18 ` John Covici
2016-12-29 17:19 ` John Covici
2016-12-30 10:30 ` Phillip Lord [this message]
2016-12-28 17:23 ` John Yates
2016-12-31 10:23 ` Philippe Vaucher
2016-12-29 1:36 ` Richard Stallman
2016-12-29 3:41 ` Eli Zaretskii
2016-12-29 12:04 ` Tino Calancha
2016-12-29 16:15 ` Eli Zaretskii
2016-12-30 0:09 ` Richard Stallman
2016-12-30 8:21 ` Eli Zaretskii
2016-12-29 14:39 ` Stefan Monnier
2016-12-28 10:27 ` hector
-- strict thread matches above, loose matches on Subject: below --
2016-12-29 2:08 Chris Gregory
2016-12-29 3:38 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ef9531effde4d1639e69c7520af2bc0.squirrel@cloud103.planethippo.com \
--to=phillip.lord@russet.org.uk \
--cc=dgutov@yandex.ru \
--cc=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.