From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Date: Tue, 21 Jan 2020 00:42:16 +0300 Message-ID: <2ee975cb-1d9c-dd1c-b696-fb463b906e33@yandex.ru> References: <288610218.111246.1578330546916@office.mailbox.org> <7293f6ca-b11d-3d2a-ad71-831135434e75@yandex.ru> <780526337.114357.1578556168662@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="63203"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: 38992@debbugs.gnu.org, waah@yellowfrog.io, Stefan Monnier To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 20 22:43:15 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1itepG-000GMt-6c for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Jan 2020 22:43:14 +0100 Original-Received: from localhost ([::1]:44424 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itepF-00048a-5o for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Jan 2020 16:43:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49301) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itep5-00047l-6B for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2020 16:43:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1itep4-0006Cn-5y for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2020 16:43:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40214) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1itep4-0006Ci-2F for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2020 16:43:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1itep4-0000J3-02 for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2020 16:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Jan 2020 21:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs Original-Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.15795565461124 (code B ref 38992); Mon, 20 Jan 2020 21:43:01 +0000 Original-Received: (at 38992) by debbugs.gnu.org; 20 Jan 2020 21:42:26 +0000 Original-Received: from localhost ([127.0.0.1]:46187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iteoU-0000I4-C2 for submit@debbugs.gnu.org; Mon, 20 Jan 2020 16:42:26 -0500 Original-Received: from mail-lj1-f177.google.com ([209.85.208.177]:40815) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iteoS-0000Hr-2k for 38992@debbugs.gnu.org; Mon, 20 Jan 2020 16:42:24 -0500 Original-Received: by mail-lj1-f177.google.com with SMTP id u1so584717ljk.7 for <38992@debbugs.gnu.org>; Mon, 20 Jan 2020 13:42:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ryWcxwmlZmql5U7Gk09hHwqb73Aee/GaRukm8SElLCw=; b=FAAWifI9+NYARr+jHqI3SPy0HEaJRux+KQyAHOU6+Iw9gBm9GWksHsMCEGr+ICI8uh B8FkQWeEtNw+N5hkCXM8yxvJ+KuGduXRCCe5O1HwN2kFjJaDg0iIze4PTwJpOI326K2s bRz8+KXMTCTO4CgR7+aBHj3fxFDssTyNkav+5Z5zvlRJT2arzpcVm7tVcWrFRhDevsZu dczJcAd+Xa6zcGhjmaSEYv4pAXk5sVIsvG1P/S+0rCnsyLdSXNRXc+DefXliK6psNMHu 6ljHPW0ZEqZblZAahFGhPEYK2NPUG5hVOu1MimE6vZFQtrlIGhsx7VJQTsu1jz3WHwsu PybA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ryWcxwmlZmql5U7Gk09hHwqb73Aee/GaRukm8SElLCw=; b=DYJ6lxQLoj+vQGTneArcezvtE5SmqfOs24g0HLIKRupbpe7w9XVvDwNKphuaKLtg6F wPPJQC2DpDuVl1HajnhSBFzFGrNxO1m5pSk2Wu6OHtPKcHvmwWc3YoFgwoKQNN4adWP7 3WjhwdXGlpnBCRIqVfa5qICsz9o4Z8xbimb8EM/iBEEKM2sEydBEznySzbwPclkXXWKi nxzzaThxe9UAPMcMUQ5kKchXB8hgFj0gQXoFWsMWugKtxVhUzETkBv+AtXhsrgoPHKLB LN5Adnw5QGiUVubx+bgWNiA9K0DosicgsAbYPuBLIE7fQejrSn1evpsBuE9B2gMHOOvP iepQ== X-Gm-Message-State: APjAAAVO8nQAgtuaWNkHIVO8GLBOgb7Fgob/c4VXjwNHyUbcuqNNuI9U HBwqmCOdbR9WNskYUnUCIiE= X-Google-Smtp-Source: APXvYqzcjyBITo/hTkY76kB2R10HdCkBueYll+TkoSRR/1gizsT1Bcy6D5xlztNco4pUALP6C8Jbow== X-Received: by 2002:a2e:9942:: with SMTP id r2mr14324952ljj.182.1579556538070; Mon, 20 Jan 2020 13:42:18 -0800 (PST) Original-Received: from [192.168.1.142] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id z205sm491853lfa.52.2020.01.20.13.42.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Jan 2020 13:42:17 -0800 (PST) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:174962 Archived-At: On 20.01.2020 17:58, João Távora wrote: > I can't tell right now. But do you need to remove it to add the message > or is this a refactoring that you are thinking about? Maybe do both > changes separately so that either can be reverted individually? Or > are they somehow connected? It's a "remove this call that exists for no reason I can think of" kind of thing. Also, if we don't use it, we won't need the progn. IIUC, what minibuffer-force-complete does here is expand the input wherever possible. But if that results in an input that has no matches (and that should be the only reason for completion--complete-and-exit, called subsequently, to fail), why even do that? And if completion--complete-and-exit succeeds, the minibuffer-force-complete shouldn't matter at all. So a second opinion would help. BTW, looks like this change will leave minibuffer-force-complete-and-exit entirely unused. > I *think* the "[Matched]" message is shown. Right. In that case, the change should be easy. OTOH, I'm not sure we should display this very prominent reminder whenever the user has a single match. Someone should try it on and experiment.