From: Daniel Mendler <mail@daniel-mendler.de>
To: Liu Hui <liuhui1610@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
Stefan Monnier <monnier@iro.umontreal.ca>,
61283@debbugs.gnu.org
Subject: bug#61283: 29.0.60; pcomplete-completions-at-point loses text properties, breaking pcomplete-from-help annotations
Date: Tue, 16 May 2023 08:19:52 +0200 [thread overview]
Message-ID: <2eb987c6-0aec-55df-db4e-ef95557ab809@daniel-mendler.de> (raw)
In-Reply-To: <CAOQTW-O2F3x+0Yrs63B99_0B2W=Dw=SKjYt0Neo_AAQ0E+yWnw@mail.gmail.com>
On 5/16/23 03:49, Liu Hui wrote:
> I agree that completion-table-with-quoting is responsible.
> pcomplete-annotation and pcomplete-help text properties can be
> successfully shown by the completion UI (corfu/company) by applying
> the following patch:
>
> It just re-adds text properties to completions produced by
> `completion-table-with-quoting', but I'm not sure it is the proper
> fix. What do you think?
I wonder when the regression was introduced. Maybe this could help to
pin down the problem and give a hint at the proper fix. I cc'ed Stefan,
since he can judge better if the proposed fix is good. I would at least
add a comment, explaining why the properties are copied.
Eli, are you okay with adding a fix for this problem to emacs-29? The
pcomplete help functionality is new functionality introduced in Emacs
29, but it never worked properly, it seems.
Daniel
next prev parent reply other threads:[~2023-05-16 6:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-05 0:23 bug#61283: 29.0.60; pcomplete-completions-at-point loses text properties, breaking pcomplete-from-help annotations Daniel Mendler
2023-05-16 1:49 ` Liu Hui
2023-05-16 6:19 ` Daniel Mendler [this message]
2023-05-16 10:30 ` Eli Zaretskii
2023-05-16 10:44 ` Daniel Mendler
2023-05-16 21:37 ` Gregory Heytings
2023-05-17 6:15 ` Daniel Mendler
2023-05-17 7:24 ` Daniel Mendler
2023-05-17 5:45 ` Jim Porter
2023-05-17 6:31 ` Daniel Mendler
2023-05-17 14:55 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-17 21:20 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-18 2:01 ` Daniel Mendler
2023-05-18 5:39 ` Eli Zaretskii
2023-05-18 6:44 ` Jim Porter
2023-05-18 6:58 ` Eli Zaretskii
2023-05-18 8:29 ` Daniel Mendler
2023-05-18 13:37 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-18 7:11 ` Jim Porter
2023-05-18 8:37 ` Daniel Mendler
2023-05-18 13:30 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-23 4:16 ` Jim Porter
2023-05-16 14:04 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-16 7:50 ` Gregory Heytings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2eb987c6-0aec-55df-db4e-ef95557ab809@daniel-mendler.de \
--to=mail@daniel-mendler.de \
--cc=61283@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=liuhui1610@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.