From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#67171: 30.0.50; (At least) some VC commands fail with project-prefix-or-any-command Date: Thu, 7 Dec 2023 02:01:39 +0200 Message-ID: <2db0d197-cbc7-6946-dfaf-ba7160a8b0ab@gutov.dev> References: <87y1f0cwbj.fsf@melete.silentflame.com> <874jgwff35.fsf@melete.silentflame.com> <90011c72-b18f-5868-2430-66eee97f454e@gutov.dev> <86msunbegc.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21122"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: 67171@debbugs.gnu.org, sbaugh@catern.com, Sean Whitton To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 07 01:03:11 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rB1rC-0005DQ-Gn for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Dec 2023 01:03:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rB1qw-0002nJ-1q; Wed, 06 Dec 2023 19:02:54 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rB1qs-0002mu-97 for bug-gnu-emacs@gnu.org; Wed, 06 Dec 2023 19:02:50 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rB1qs-0003tw-0D for bug-gnu-emacs@gnu.org; Wed, 06 Dec 2023 19:02:50 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rB1r3-0000qz-KV for bug-gnu-emacs@gnu.org; Wed, 06 Dec 2023 19:03:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Dec 2023 00:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67171 X-GNU-PR-Package: emacs Original-Received: via spool by 67171-submit@debbugs.gnu.org id=B67171.17019073283203 (code B ref 67171); Thu, 07 Dec 2023 00:03:01 +0000 Original-Received: (at 67171) by debbugs.gnu.org; 7 Dec 2023 00:02:08 +0000 Original-Received: from localhost ([127.0.0.1]:40682 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rB1qB-0000pa-JP for submit@debbugs.gnu.org; Wed, 06 Dec 2023 19:02:07 -0500 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:50371) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rB1q6-0000ox-EO for 67171@debbugs.gnu.org; Wed, 06 Dec 2023 19:02:06 -0500 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 9030B5C0274; Wed, 6 Dec 2023 19:01:44 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 06 Dec 2023 19:01:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1701907304; x=1701993704; bh=xANkbhVvhFmXS6E9pvJHwCFDNrK3nz0VCB4 4VaEUkGw=; b=T+E2gIh6HJW0ycceAGbMT5Qzv3LNleJ8RZx8BwpRTcaiJl0rvt6 siY9ocLOWZJMB9t2ugZBsDbHrueulh5MxBf988V3PFG1SGRCcmscKFztJDY4UXlL eO44r9Rxpyp5G4xVrQjYPFA0gigSSCs8DznQAPUl906NFQxoKfds46i5l3Pk0TSj TYQtjTSl6Aa64a5nxgEnVK8JOEsKD5QGFhXX3ezn8cqHeGtoaOQs9wlTetFZWW0R LrHHWQPGSHvXTncmZ0vuFOj8CFJx5VK8uf1LgMAsPIW1TDcsetZSP5xM8AkEpUHy k+EteJwJ8NHGmV8WR/d/8fOknqo+HIBpVpg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1701907304; x=1701993704; bh=xANkbhVvhFmXS6E9pvJHwCFDNrK3nz0VCB4 4VaEUkGw=; b=Gr+Pht4Hm5UDIknj+58dVmkNjuR0s/5p75rSjcdYvan0H4MIxRc mR9t8I7pQdZrH1NK7w+Rgrmfo206AdrbPskKDBzX7OJASPL+kQb4yGzbIR4N1uGM RJivlyX4X2X8NAgkxjWo1jGm4Qd5l9ZvXR3hoVUCtxngTJwqfRgkPBM3KH1DFN+c tfcfpoccxgcKKVT3M7eGarri2l1AyGvK8kcPOv6achORoupLd7vQaLGUvsYYSdeW dyMGKkHfwt9CX46+L4k2vev8ZdcoR63AB2VCMSiA/EGQDRXVDH3KG0K17A/T/Tu1 81l/9OLJJjpteUn3+0muW0+mGDpvCqNV71w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudekuddgudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 6 Dec 2023 19:01:42 -0500 (EST) Content-Language: en-US In-Reply-To: <86msunbegc.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275634 Archived-At: On 06/12/2023 19:10, Juri Linkov wrote: >> So... something like this? >> >> @@ -1861,9 +1861,10 @@ project-any-command >> (when command >> ;; We could also check the command name against "\\`project-", >> ;; and/or (get command 'project-command). >> - (map-keymap >> - (lambda (_evt cmd) (if (eq cmd command) (setq found t))) >> - project-prefix-map) >> + (unless (get command 'project-switch-with-default-directory) >> + (map-keymap >> + (lambda (_evt cmd) (if (eq cmd command) (setq found t))) >> + project-prefix-map)) >> (if found >> (let ((project-current-directory-override root)) >> (call-interactively command)) > Why not let-bind both variables for all commands: > 'project-current-directory-override' and 'default-directory'? > > Then project commands will pick up the first: > > (or project-current-directory-override default-directory) > > And non-project commands will just ignore > 'project-current-directory-override'. I think that would still regress bug#58784. And project-current-directory-override was really only added to benefit such rare cases.