From: Dmitry Gutov <dgutov@yandex.ru>
To: Juri Linkov <juri@linkov.net>
Cc: 47012@debbugs.gnu.org
Subject: bug#47012: xref copies keymap properties to minibuffer
Date: Fri, 2 Apr 2021 01:43:24 +0300 [thread overview]
Message-ID: <2da88387-25ad-c615-922d-718e1b7a49d1@yandex.ru> (raw)
In-Reply-To: <87o8exsv1p.fsf@mail.linkov.net>
On 01.04.2021 21:45, Juri Linkov wrote:
>> Additionally, what do you think about toning down 'match''s background
>> color? Maybe use some subtler yellow like "lemon chiffon" or "khaki1"? Or
>> "light goldenrod".
>
> Such toning down is welcome since currently match's background is too intense.
> Actually, I customized it long ago to "#ffff88" on one display,
> and to "#ffffbb" on another display. I guess "#ffffbb" is too radical,
> but "#ffff88" should be fine and close to "khaki1" that is nicely looking as well.
> Another variant is to update gradually, i.e. start with "#ffff66",
> then after some time to "#ffff88".
I like either of these, just not #ffff66 (still too bright). Perhaps
some darker variant would be a better option if being easy-to-notice
becomes a problem (as Eli's response seems to indicate). Maybe we should
ask others as well.
Anyway, let's hold off on this part of the change until further discussion.
>>>> Please try (setq xref-file-name-display 'project-relative).
>>> Thanks, I didn't know about this. Shouldn't this be the default value
>>> since this is what's displayed by grep and ripgrep.
>>
>> I wouldn't mind, personally.
>
> This is added to the patch below too.
LGTM.
>>> Actually, there is no exact option for what grep and ripgrep do,
>>> because they display file names relative to the search directory.
>>> But currently there is no xref option to display file names
>>> relative to the subdirectory specified by 'C-u C-x p g'.
>>
>> This issue is tricky because xref-find-definitions does not assume the
>> presence of a project, or even of any kind of containing directory. And
>> yet, it's handy to show its results with relative file names when possible,
>> too. So I picked "relative to the project" as the option value, and the
>> corresponding logic.
>>
>> I think what you're talking about is only a problem when the directory has
>> no containing project at all. In that case we could probably default to the
>> value of default-directory as the reference.
>
> Maybe it would be nice to default to default-directory even when
> 'C-u C-x p g' is used in a project.
That's not the question, though. The question is whether we default to
default-directory when outside of recognizable projects. Or how to
differentiate 'C-u C-x p g' from other cases, such as xref-find-definitions.
If this is not urgent, let's leave it for a separate bug report.
> What is the real problem for me is that after navigating to
> a project's subdirectory (with e.g. dired) and typing 'C-u C-x p g',
> it doesn't provide the current directory as the default value.
> It inserts the project root by default, not its subdirectory:
>
> Base directory: /project/root/
>
> whereas 'M-x rgrep' conveniently provides default-directory as default.
Makes sense, fixed in 4798dc0c51, please check it out.
> BTW, is it possible to make 'project-find-regexp' more compatible with 'rgrep'
> in other features too? What is missing is a way to modify the constructed
> command line. For example, often I need to add "-w" to the constructed command
> to match words only. In 'C-u M-x rgrep', this is easy to do,
> but not in 'C-u C-x p g'.
That's not so easy to do: the exact command is concealed inside the
helper function in another package (xref). I suppose it's possible to
rearrange things such that command creation and its execution are two
different phases, but TBH I wouldn't love the result. Though I agree it
might be handy.
What I've been thinking we should have instead, is some kind of
graphical prompt with multiple fields, where you can by default input
the regexp and press RET, but you can also see the other options (like
the file name glob to filter by, whether to search the "external roots"
or not, whether to search only a particular directory, whether to ignore
case, whether to search in the project-ignored files as well; options
which modify the regexp or matching logic like your -w could be added too).
Note that several of the options enumerated above are not something we
could expose in the "edit the command" interface, because the command
gets the list of files from stdin.
Maybe it would be presented like one-line prompt where you can reach
further fields using TAB, and maybe expand into some multiline pane
(still inside the minibuffer) if some options can't fit on the same
line, and you reach the end of that line by TAB-bing.
To sum up, if we managed to create some visual interface for specifying
the options that project-find-regexp has control over, maybe it would
both result in a less complex interaction between packages, as well as
in a more powerful UI which more people will be happy with.
next prev parent reply other threads:[~2021-04-01 22:43 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 20:03 bug#47012: xref copies keymap properties to minibuffer Juri Linkov
2021-03-09 2:08 ` Dmitry Gutov
2021-03-11 20:58 ` Juri Linkov
2021-03-24 20:38 ` Juri Linkov
2021-03-24 21:57 ` Dmitry Gutov
2021-03-25 9:40 ` Juri Linkov
2021-03-25 10:57 ` Dmitry Gutov
2021-03-25 21:28 ` Juri Linkov
2021-03-25 22:12 ` Dmitry Gutov
2021-03-30 19:16 ` Juri Linkov
2021-03-31 15:47 ` Dmitry Gutov
2021-03-31 15:59 ` Eli Zaretskii
2021-03-31 16:10 ` Dmitry Gutov
2021-03-31 16:57 ` Eli Zaretskii
2021-04-01 0:25 ` Dmitry Gutov
2021-04-01 7:17 ` Eli Zaretskii
2021-03-31 17:05 ` Juri Linkov
2021-04-01 1:16 ` Dmitry Gutov
2021-04-01 8:43 ` Juri Linkov
2021-04-01 14:13 ` Dmitry Gutov
2021-04-01 18:45 ` Juri Linkov
2021-04-01 19:06 ` Eli Zaretskii
2021-04-01 21:28 ` Dmitry Gutov
2021-04-02 6:08 ` Eli Zaretskii
2021-04-02 23:50 ` Dmitry Gutov
2021-04-03 7:24 ` Eli Zaretskii
2021-04-03 18:12 ` Dmitry Gutov
2021-04-03 18:19 ` Eli Zaretskii
2021-04-02 8:20 ` Juri Linkov
2021-04-01 22:43 ` Dmitry Gutov [this message]
2021-04-02 8:25 ` Juri Linkov
2021-04-02 23:23 ` Dmitry Gutov
2021-04-04 22:55 ` Juri Linkov
2021-04-05 2:15 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2da88387-25ad-c615-922d-718e1b7a49d1@yandex.ru \
--to=dgutov@yandex.ru \
--cc=47012@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.