From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Patches for Emacs 25.2 Date: Mon, 7 Nov 2016 11:36:22 +0200 Message-ID: <2d749ac6-636b-14f2-e5a9-dcc0e9ba7541@yandex.ru> References: <877f96t9oc.fsf@gmx.de> <837f96xgp5.fsf@gnu.org> <87zim2rtck.fsf@gmx.de> <9181f38b-8d6c-c61e-90b0-d44a9e048c9e@gmail.com> <87wph6qd1d.fsf@gmx.de> <831szexb54.fsf@gnu.org> <83shrtx5dv.fsf@gnu.org> <752ec49c-da5b-bf86-e31d-294c362c04cb@gmail.com> <877f95deig.fsf@gmx.de> <6f656e32-a44c-f874-3290-f47b8828078e@yandex.ru> <87oa1r64vg.fsf@gmx.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1478511591 26643 195.159.176.226 (7 Nov 2016 09:39:51 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 7 Nov 2016 09:39:51 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Thunderbird/50.0 Cc: Eli Zaretskii , Nikolay Kudryavtsev , emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 07 10:39:47 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c3gOV-0001Ir-Tx for ged-emacs-devel@m.gmane.org; Mon, 07 Nov 2016 10:39:12 +0100 Original-Received: from localhost ([::1]:52516 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3gOT-0005F2-NO for ged-emacs-devel@m.gmane.org; Mon, 07 Nov 2016 04:39:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45696) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3gLu-0003kV-Me for emacs-devel@gnu.org; Mon, 07 Nov 2016 04:36:32 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c3gLp-0001Gj-QL for emacs-devel@gnu.org; Mon, 07 Nov 2016 04:36:30 -0500 Original-Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:33321) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c3gLp-0001GY-IC; Mon, 07 Nov 2016 04:36:25 -0500 Original-Received: by mail-wm0-x244.google.com with SMTP id u144so15412424wmu.0; Mon, 07 Nov 2016 01:36:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=AtwSrefkhl/Ad83kA+0yrDRxxaABPMn6DSxJAXYjb4I=; b=rToeVu4IC5UCB/Gq3jtGVrvrrXztlwg/wm06m/oTGD2qaG9mXcOPuSsrkRQXtXnixj znW6FjeviJjiaNF1+Ay6YpaSCWJk5DTuUG+pw+O448LtkfhtCNZZ3C41WV8NtT7O2ngg WWOhS482GxN5QMolMGaKFx+nQxBvIEl6fF0MJZ81ISS5PZYywCHZ/5ov7LXcQQPFVQos a2SlaPkSl8idk5VQHe8Yk1t934J/ca3tC4WW0RwB7621MohdXw1YdY8VU4UXQRr3rWp0 +pWA4I7dYeVRDjh9M97MELe1Fu2OKTu793qvgzNbQ8P4m5ULzJ1LYdFsZex7cUBL8jSq PH7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=AtwSrefkhl/Ad83kA+0yrDRxxaABPMn6DSxJAXYjb4I=; b=kT1fL/qI+MPu0YjUQU/u21E4wKwkaOzQgRhD5UKXhmay+1Gfq4V1Eumjz4Tn6hj8HE iIGJZWFSMRz75Id+Z10dq5A97rCwTHXX2ECSnQ17LWbmoc2aBLmLqXPRTCtsAxl88xTq imjvU6m1qruihkQtbAFLbfsMPTThLYHYtzSChFtC5go7sCU7BgDF85KGJct2OSdeOaLa Q8bbUpXnQQAlQY5UxREqGaqu7hixo6ab56RnLir2lJoQ/5NoR6xrTsOZiLrY+2xOoHXO OmRNLCpkRlfs5hMOc4uYbgYHXFRl+EUncpneQdHnWdbxH8wnwoVlBeO9/vvWtZ9hwNxe aHPA== X-Gm-Message-State: ABUngvec62ooU2wB3TjKDlacYXfH4PP5yOM3D/qFqH42iSNKzPitNvqqtwg9oy8Sk5dGew== X-Received: by 10.194.172.100 with SMTP id bb4mr4331971wjc.53.1478511384349; Mon, 07 Nov 2016 01:36:24 -0800 (PST) Original-Received: from [192.168.1.3] ([185.105.173.41]) by smtp.googlemail.com with ESMTPSA id di9sm530321wjc.37.2016.11.07.01.36.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Nov 2016 01:36:23 -0800 (PST) In-Reply-To: <87oa1r64vg.fsf@gmx.de> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::244 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209239 Archived-At: On 07.11.2016 11:01, Michael Albinus wrote: >> Can't we move the (file-remote-p ... 'localname) call to the first >> hunk here? Then the patch will only change one place, and we get rid >> of the added `or' here. > > I let it to Nikolay. Not sure I understand. > However, given that this construct > > (or (file-remote-p FILE 'localname) FILE) > > happens several times in the lisp sources, I wonder whether we shall > give it an own defmacro or defsubst (in master, of course). I have no strong opinion either way, but your commit in master fixing this problem does not have this construct.