From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#23451: 25.0.93; Clarify the dependency on find/grep for platforms not having those tools Date: Mon, 29 May 2017 03:07:01 +0300 Message-ID: <2d674c13-6626-bbd6-e461-c4de963167c4@yandex.ru> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1496016495 14095 195.159.176.226 (29 May 2017 00:08:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 29 May 2017 00:08:15 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Thunderbird/54.0 To: Kaushal Modi , 23451@debbugs.gnu.org, drew.adams@oracle.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 29 02:08:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dF8EF-0003Yx-6i for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 May 2017 02:08:11 +0200 Original-Received: from localhost ([::1]:46178 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dF8EK-0007BI-MD for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 May 2017 20:08:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dF8EC-00079o-5K for bug-gnu-emacs@gnu.org; Sun, 28 May 2017 20:08:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dF8E8-0003Oi-O4 for bug-gnu-emacs@gnu.org; Sun, 28 May 2017 20:08:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39611) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dF8E8-0003OW-KC for bug-gnu-emacs@gnu.org; Sun, 28 May 2017 20:08:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dF8E5-0007ug-OL for bug-gnu-emacs@gnu.org; Sun, 28 May 2017 20:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 May 2017 00:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23451 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23451-submit@debbugs.gnu.org id=B23451.149601643230359 (code B ref 23451); Mon, 29 May 2017 00:08:01 +0000 Original-Received: (at 23451) by debbugs.gnu.org; 29 May 2017 00:07:12 +0000 Original-Received: from localhost ([127.0.0.1]:42288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dF8DI-0007tb-3O for submit@debbugs.gnu.org; Sun, 28 May 2017 20:07:12 -0400 Original-Received: from mail-wm0-f41.google.com ([74.125.82.41]:38391) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dF8DG-0007tO-Di for 23451@debbugs.gnu.org; Sun, 28 May 2017 20:07:10 -0400 Original-Received: by mail-wm0-f41.google.com with SMTP id e127so38560032wmg.1 for <23451@debbugs.gnu.org>; Sun, 28 May 2017 17:07:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=SzIFSj++78+y8jHrkEdoAEbpX3nrrkJttC8nXnUzDlI=; b=FBqHo/Zi3YZ+cHx0gMcckJD/R0MZ1y8/fQ6CUs8JzlHHLfIybzJoGR5A8BcQYguEr1 K4Um6heJGxDXluBQTrSs4/MUtb0XvfOvhrfze1yMOxZZZBkdY4sGEE++UFHy5UOaMlXA WbnKeS9jsZ8vC3rHmI9d66/sotA/gxnCJh3eZvLpqYYFoHAa6f0cYRwyGDMXWsJuYCUE SCFDxG5NuDLPBLvgcG/7Xd6e8ByVEntGAOm5bv/AhgsztWUJDBdWXg0DpscI/haaT+E1 q213J6zLF0qsujWjf9YveoYuC+r0j2nD9QRvaAfnycPWNo7t7++LQU73WJzIYT3hziyN jOsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=SzIFSj++78+y8jHrkEdoAEbpX3nrrkJttC8nXnUzDlI=; b=fCV14PIC79ZkkJNdkWvmzae4/8om9umeGItC/wQXTEriNywgP3QTGmfTI5Kpf90KHm Ft3YiSL70GHROFZVKr3USJtaZDDGQmMOdYwPDSyQyDe9KGoZ4rsfihAhhqrGSp/xRjbV VPGzx/4ctx76rzMnDI1tvIJFLfhj/BXlzt4Y4ZYa76VyOeX9cRdpgK9iVz3UoaziMvhX V0CscRBuebHn/3T4Bx8xZj0xNwamwiFaHTHh5QvpNo95rF7aVwRdQtfT01RrxNMfNiL4 D5xQJLbqYwWT2f2c0naMwiw2QrQ5joAogesS6w5gti363x9BKTBKlaDvBDS7sHuzIs4N HGUA== X-Gm-Message-State: AODbwcA8CeYALy9NtQ3uUwPOdU0vbZvzsoHgu3PkZQaAaCA/YRrSg916 ByPykTAcaQHG5A== X-Received: by 10.28.140.74 with SMTP id o71mr20911163wmd.90.1496016424710; Sun, 28 May 2017 17:07:04 -0700 (PDT) Original-Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id s29sm6713990wrb.21.2017.05.28.17.07.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 28 May 2017 17:07:03 -0700 (PDT) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:132973 Archived-At: On 5/4/16 9:02 PM, Kaushal Modi wrote: > Another alternative would be (if we want to keep A/Q bindings) that a > user-error or error be thrown if the correct external dependencies are not > installed. The user should be let known that they need to install the GNU > find/grep executables for their platform in order to use those commands. I've made a step toward this in commit 3bc3dc4: if the status is not zero and the process made some output, we signal a user error with whatever output we have. It's not exactly installation instructions, but it will at least tell the user that something is wrong. Previously, I had some problems using this approach, but failed to document them properly. Let's see if someone manages to find them again. Hopefully, the only thing missing before was the (/= (point-min) (point-max)) check.