From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Andreas =?UTF-8?Q?R=C3=B6hler?= Newsgroups: gmane.emacs.bugs Subject: bug#35708: [27.0.50]: thingatpt.el, thing-at-point-looking-at redundant Date: Tue, 14 May 2019 12:49:07 +0200 Message-ID: <2d6578ec-8d7c-d3d0-7d1c-08eab22cae79@easy-emacs.de> References: <8a73a0c9-5b38-4089-2780-28e62a1e162b@easy-emacs.de> <87ftpih6hs.fsf@gmail.com> <1bbebe25-9c4e-2563-701b-9bed85fcabb0@easy-emacs.de> <8536lixikt.fsf@gmail.com> <364b372e-7896-d92c-f848-0e7abc152a20@easy-emacs.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="20405"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux i686; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 Cc: 35708@debbugs.gnu.org To: npostavs@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 14 12:49:26 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hQUzu-0005AM-ED for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 May 2019 12:49:26 +0200 Original-Received: from localhost ([127.0.0.1]:45290 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQUzt-00037F-9H for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 May 2019 06:49:25 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38423) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQUzZ-00035Q-AN for bug-gnu-emacs@gnu.org; Tue, 14 May 2019 06:49:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQUzY-0005d8-7k for bug-gnu-emacs@gnu.org; Tue, 14 May 2019 06:49:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33968) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hQUzY-0005ck-4W for bug-gnu-emacs@gnu.org; Tue, 14 May 2019 06:49:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hQUzV-0000LH-Nd for bug-gnu-emacs@gnu.org; Tue, 14 May 2019 06:49:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andreas =?UTF-8?Q?R=C3=B6hler?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 May 2019 10:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35708 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.15578309121273 (code B ref -1); Tue, 14 May 2019 10:49:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 14 May 2019 10:48:32 +0000 Original-Received: from localhost ([127.0.0.1]:47512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQUz2-0000KS-2v for submit@debbugs.gnu.org; Tue, 14 May 2019 06:48:32 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52065) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQUz1-0000KG-23 for submit@debbugs.gnu.org; Tue, 14 May 2019 06:48:31 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:55981) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hQUyu-0004dy-Vn for submit@debbugs.gnu.org; Tue, 14 May 2019 06:48:25 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38212) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQUyt-0002Ss-Qs for bug-gnu-emacs@gnu.org; Tue, 14 May 2019 06:48:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQUyq-0004Wz-V0 for bug-gnu-emacs@gnu.org; Tue, 14 May 2019 06:48:23 -0400 Original-Received: from mout.kundenserver.de ([212.227.126.134]:37617) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hQUyq-0004RA-L8 for bug-gnu-emacs@gnu.org; Tue, 14 May 2019 06:48:20 -0400 Original-Received: from [192.168.178.39] ([87.123.193.177]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MJmX3-1h72Hz0cFF-00KAwX; Tue, 14 May 2019 12:48:18 +0200 In-Reply-To: <364b372e-7896-d92c-f848-0e7abc152a20@easy-emacs.de> Content-Language: en-US X-Provags-ID: V03:K1:1duAwDAw3WkykydU+VOOr0SBh+w0B7uQZ7U/0F0apfGwUssifIQ 5Zs9foUTyPU1t9GdhsOHhqtvbvUjqIhsNIu4oPAN03GW2RvIbL3fHLabhXfzssPJKk1xtiD Ow8NRnpNzYmssxjGrOfdWQGnH0+hsiuDMWaKDTGa63vUZu7WqUCQQsLLfqYznxIMeq13iXm GogTIzndgzMmQzgxltQEA== X-UI-Out-Filterresults: notjunk:1;V03:K0:gmZpekJkENU=:4wTUV3jupYK72pmlZPYisF 8vnePmaeq4Tk0UqiinEbZclO/PmL7lQvWhQsVKcxgJ24MU/oWQN38T03lIIuonHkCvMOGKXI1 +6tLRi92tBMg/NPinZN+hXXreGw7ePq8LLXsVsjuKwJxDbP292SeMW/ogLlYchT5jaUn7vjyg wqM2Pb26GZWGhHbf9OZTCw2Aaxmpi/O+kzQr9eB4QQshcZxuvA0yHj1DDLpilCMA9meXKfAj1 JL3s1sgat2mxacy6Ftwl1YJEfxRr4K/JJdRxYGhOuGYiRyy6LV8E6ZyzcNdml07BIzTCGNejV MnT8TowDjjrHKgdyBIPDBpQt0aS1l2VkSKEj6zhOjagSY705AkjNbxmW+qgS7e2B7gASeM1ym JQuseugJ3n0put8ZwoDOdgOZtRWTDtzQhqv/Up9ryPHGMUeWbGIJ7s7F2mp3q4rU/1RTrBf9a WlD0H3PtmrBkGh3KQWbrQFKcZaXjrY0e3gimzdEnzjIV/esLJ5XcUSW72TZnExVcuDxf0X02P CNCBI2qhAvhsG0gK1q2wSccinQYv4oorz10eR0yzbawWyM3qJapefnqeGqUuLUJEMlW4qlg2g jUAOAxBHrROqJxaa4VyOUlhhoko7T/UZtcCenfC/qfxC4Jawz1zhDahb3w4moo7l4rVKKFXdN qW8l/4KaXlB5DxiAn+t8IrwGI2FSf82qWzCKsq9lmYup/7/z9a1bnk5pildgcYKOioXmYe3sT PBKEQRVsfOlVuJKimmfY2ttz5khaR/GIIXBDJ6JA2oDpiJoDkf4zB79PJyQDOOKfprCEnw9b X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159268 Archived-At: On 14.05.19 12:02, Andreas Röhler wrote: > > On 13.05.19 21:25, npostavs@gmail.com wrote: >> Andreas Röhler writes: >> >>> Thought at something like below, which should pass the test: >>> >>> (defun ar-thing-at-point-looking-at (regexp) >>>    "Return t if regexp matches at or before point, nil otherwise." >>>    (save-excursion >>>        (while (not (or (looking-at regexp)(bolp))) >>>        (forward-char -1)) >>>        (looking-at regexp))) >> I think it's an optimization to use re-search-backward instead of moving >> on character at a time and calling looking-at in lisp. >> >> > > Hmm, current thing-at-point-looking-at might be slow with large > buffers. The slightly modified test should reveal it: > > (ert-deftest thing-at-point-looking-at-2 () >   (with-temp-buffer >     (insert "1abcd 222abcd") >     (dotimes (_ 99999) (insert " asdf ")) >     (goto-char (point-min)) >     (let ((m2 (progn (search-forward "2abcd") >                      (match-data)))) >       (goto-char (point-min)) >       (search-forward "2ab") >       (should (thing-at-point-looking-at "2abcd")) >       (should (equal (match-data) m2))))) > > But let me correct the alternative delivered, as it didn't match > before point: > > (defun ar-regexp-atpt (regexp) > > "Return t if REGEXP matches at or before point, nil otherwise. > > Changes match-data" >   (save-excursion >     (if (looking-at regexp) >     (while >         (save-excursion >           (and (not (bobp)) >            (progn (backward-char) (looking-at regexp))))) >       (while (not (or (bobp) (backward-char) (looking-at regexp)))) >       (ar-regexp-atpt regexp)) >     (looking-at regexp))) > > > > Another fix, as a bug showed up when testing (ar-regexp-atpt "[a-z]+"): (defun ar-regexp-atpt (regexp)   "Return t if REGEXP matches at or before point, nil otherwise. Changes match-data"   (save-excursion     (if (looking-at regexp)     (while         (and (not (bobp))          (or (progn (backward-char) (looking-at regexp))              (forward-char 1))))       (while (not (or (bobp) (backward-char) (looking-at regexp))))       (ar-regexp-atpt regexp))     (looking-at regexp)))