From: "Andreas Röhler" <andreas.roehler@easy-emacs.de>
To: npostavs@gmail.com
Cc: 35708@debbugs.gnu.org
Subject: bug#35708: [27.0.50]: thingatpt.el, thing-at-point-looking-at redundant
Date: Tue, 14 May 2019 12:49:07 +0200 [thread overview]
Message-ID: <2d6578ec-8d7c-d3d0-7d1c-08eab22cae79@easy-emacs.de> (raw)
In-Reply-To: <364b372e-7896-d92c-f848-0e7abc152a20@easy-emacs.de>
On 14.05.19 12:02, Andreas Röhler wrote:
>
> On 13.05.19 21:25, npostavs@gmail.com wrote:
>> Andreas Röhler <andreas.roehler@easy-emacs.de> writes:
>>
>>> Thought at something like below, which should pass the test:
>>>
>>> (defun ar-thing-at-point-looking-at (regexp)
>>> "Return t if regexp matches at or before point, nil otherwise."
>>> (save-excursion
>>> (while (not (or (looking-at regexp)(bolp)))
>>> (forward-char -1))
>>> (looking-at regexp)))
>> I think it's an optimization to use re-search-backward instead of moving
>> on character at a time and calling looking-at in lisp.
>>
>>
>
> Hmm, current thing-at-point-looking-at might be slow with large
> buffers. The slightly modified test should reveal it:
>
> (ert-deftest thing-at-point-looking-at-2 ()
> (with-temp-buffer
> (insert "1abcd 222abcd")
> (dotimes (_ 99999) (insert " asdf "))
> (goto-char (point-min))
> (let ((m2 (progn (search-forward "2abcd")
> (match-data))))
> (goto-char (point-min))
> (search-forward "2ab")
> (should (thing-at-point-looking-at "2abcd"))
> (should (equal (match-data) m2)))))
>
> But let me correct the alternative delivered, as it didn't match
> before point:
>
> (defun ar-regexp-atpt (regexp)
>
> "Return t if REGEXP matches at or before point, nil otherwise.
>
> Changes match-data"
> (save-excursion
> (if (looking-at regexp)
> (while
> (save-excursion
> (and (not (bobp))
> (progn (backward-char) (looking-at regexp)))))
> (while (not (or (bobp) (backward-char) (looking-at regexp))))
> (ar-regexp-atpt regexp))
> (looking-at regexp)))
>
>
>
>
Another fix, as a bug showed up when testing (ar-regexp-atpt "[a-z]+"):
(defun ar-regexp-atpt (regexp)
"Return t if REGEXP matches at or before point, nil otherwise.
Changes match-data"
(save-excursion
(if (looking-at regexp)
(while
(and (not (bobp))
(or (progn (backward-char) (looking-at regexp))
(forward-char 1))))
(while (not (or (bobp) (backward-char) (looking-at regexp))))
(ar-regexp-atpt regexp))
(looking-at regexp)))
next prev parent reply other threads:[~2019-05-14 10:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 7:19 bug#35708: [27.0.50]: thingatpt.el, thing-at-point-looking-at redundant Andreas Röhler
2019-05-13 12:41 ` Noam Postavsky
2019-05-13 18:31 ` Andreas Röhler
2019-05-13 19:25 ` npostavs
2019-05-14 10:02 ` Andreas Röhler
2019-05-14 10:49 ` Andreas Röhler [this message]
2019-05-14 14:34 ` npostavs
2019-05-15 6:59 ` Andreas Röhler
2019-05-15 10:11 ` Andreas Röhler
2019-05-20 17:17 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d6578ec-8d7c-d3d0-7d1c-08eab22cae79@easy-emacs.de \
--to=andreas.roehler@easy-emacs.de \
--cc=35708@debbugs.gnu.org \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.