From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#23453: 25.0.93; dired-do-find-regexp does not work on Windows even after installing GNU find and grep Date: Thu, 5 May 2016 04:18:28 +0300 Message-ID: <2d5fca36-dee6-9c4b-6c7b-7ea50501ea62@yandex.ru> References: <834madioy0.fsf@gnu.org> <48af9fd9-2b0a-7c67-9141-c2236c62e318@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1462411182 6859 80.91.229.3 (5 May 2016 01:19:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 5 May 2016 01:19:42 +0000 (UTC) Cc: 23453@debbugs.gnu.org To: Kaushal Modi , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 05 03:19:31 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ay7wx-0001P9-Cm for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 May 2016 03:19:31 +0200 Original-Received: from localhost ([::1]:51088 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ay7wt-0002ON-2M for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 May 2016 21:19:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40952) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ay7wk-0002Cc-Qm for bug-gnu-emacs@gnu.org; Wed, 04 May 2016 21:19:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ay7wZ-0005ZZ-5v for bug-gnu-emacs@gnu.org; Wed, 04 May 2016 21:19:13 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54465) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ay7wX-0005Wu-VZ for bug-gnu-emacs@gnu.org; Wed, 04 May 2016 21:19:07 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ay7wU-0007Az-HN for bug-gnu-emacs@gnu.org; Wed, 04 May 2016 21:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 May 2016 01:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23453 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23453-submit@debbugs.gnu.org id=B23453.146241111727553 (code B ref 23453); Thu, 05 May 2016 01:19:02 +0000 Original-Received: (at 23453) by debbugs.gnu.org; 5 May 2016 01:18:37 +0000 Original-Received: from localhost ([127.0.0.1]:38569 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ay7w5-0007AL-KM for submit@debbugs.gnu.org; Wed, 04 May 2016 21:18:37 -0400 Original-Received: from mail-wm0-f66.google.com ([74.125.82.66]:36072) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ay7w4-0007A9-7t for 23453@debbugs.gnu.org; Wed, 04 May 2016 21:18:36 -0400 Original-Received: by mail-wm0-f66.google.com with SMTP id w143so641221wmw.3 for <23453@debbugs.gnu.org>; Wed, 04 May 2016 18:18:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=gw7dc0Cj542O+eeIPLJ03Kj6X82n9l6oKPrPcTPg4IA=; b=CINZA7m1gJMAgSAsSdsa8gJUNnPKgAEYZ/pmAEgxAZ2CeGWtT6DZhnLhqrxTkLot5H WgY1ihjqcxSLUBF+HFFI6hUpogw6y/ZPIXD38WhtyYJtsdm+jZw7D2dIoeMeeLCuX9ZV Mx+3d/EeVpUcDY1yQzC6SxKraC+ebEw7mdAmskKBoQA73r6SfoyuD3Im0CLgPP16+zUP d9kSWZxtjCE8URscKCCMTFvGql0xRRPhdXX+ApNmtTxdH3fU8nt9mrZY55tS4iHkcrsw B3lju2NXHAYAHD1ZtsSLMQjrJa7/uEbVEFaSTGYbeU67ZZ+8kAA7wYCyscUd84lWlYop +HSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=gw7dc0Cj542O+eeIPLJ03Kj6X82n9l6oKPrPcTPg4IA=; b=T+eWFyZkShBHYmBb3c/Y/2SdEsE0P/W4NNn5x8eZoAW1//bK4YsZjHtr7YjiK7FGYL T0T4gjuOVXjNUImZIgrqpj1dauVBP8vSrVpS6yleGmXm6hE9z2AF/znjXiHyldcwdE9J OVgU2nVRyHMyqf9Y+4UYbJmmZDPLMUBZzN4u97iE+a9Cw1Lz+CnfmbiHtLAfFRpB9tYg 3xXWGCkCvT68NJ+2LYCAquZ7+xJAObjw5X7qiHeKAz0V9husP5LoM6/ncdAQ9G0WSaaD 7um3AZp3uLGS2fBGfS4/5uRG+CwQDhBVz9XE1wbvTlhWGpDSWEsOMO3L+ayPKccuhFEU nVvA== X-Gm-Message-State: AOPr4FWjVSXMku0QgKj4OaIkpxVb4bIXzjRieiskzOlO5DVVa5eHmi/J2xkviUBkyvFvbg== X-Received: by 10.28.45.216 with SMTP id t207mr421522wmt.40.1462411110512; Wed, 04 May 2016 18:18:30 -0700 (PDT) Original-Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id a200sm466051wme.8.2016.05.04.18.18.29 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 04 May 2016 18:18:29 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:117827 Archived-At: On 05/05/2016 01:30 AM, Kaushal Modi wrote: > Convert IGNORES and DIR to a list of arguments for ’find’. > IGNORES is a list of glob patterns. DIR is an absolute > directory, used as the root of the ignore globs. > > If DIR is going to be an argument to `find', it should be shell quoted > too, right? That doesn't mean that it isn't being quoted now, in the function in question. > Or how about this 3rd version of the patch: It's functionally equivalent to the second one, I believe. > It feels untidy to shell-quote dir separately; once in the > grep-expand-template form and second time inside > xref--find-ignores-arguments. Also it could get confusing keeping track > of if dir was already shell-quoted by the time it entered > xref--find-ignores-arguments or not. shell-quoting is the last thing you do to an argument. Quoting an then transforming it rarely makes sense. > A comment in that last function also says: > > ;; `shell-quote-argument' quotes the tilde as well. > (cl-assert (not (string-match-p "\\`~" dir))) > > So looks like dir is expected to be shell-quoted before it entered that > function. Actually, this comment means the opposite: we would want ~ in the command line unquoted, but that won't happen because DIR is quoted later. So we require DIR to be non-abbreviated. Anyway, let's leave that off until you find a definite case where it's a problem. I've pushed the other change now in ab3ba91. Please see if it fixes the problem, and if so, close the bug.