From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#33335: 26; Doc strings of `trash-directory' and `move-file-to-trash' Date: Sat, 10 Nov 2018 11:12:40 -0800 (PST) Message-ID: <2d3e93b9-5fd4-418f-afe5-b14df2476fe6@default> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1541877130 7160 195.159.176.226 (10 Nov 2018 19:12:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 10 Nov 2018 19:12:10 +0000 (UTC) To: 33335@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 10 20:12:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gLYfs-0001i1-OQ for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Nov 2018 20:12:05 +0100 Original-Received: from localhost ([::1]:39668 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gLYhy-0003jD-QU for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Nov 2018 14:14:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38431) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gLYhs-0003ix-KH for bug-gnu-emacs@gnu.org; Sat, 10 Nov 2018 14:14:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gLYhm-00053w-Ul for bug-gnu-emacs@gnu.org; Sat, 10 Nov 2018 14:14:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40717) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gLYhm-000531-Pd for bug-gnu-emacs@gnu.org; Sat, 10 Nov 2018 14:14:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gLYhm-0000vY-Ja for bug-gnu-emacs@gnu.org; Sat, 10 Nov 2018 14:14:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Nov 2018 19:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 33335 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.15418771903497 (code B ref -1); Sat, 10 Nov 2018 19:14:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 10 Nov 2018 19:13:10 +0000 Original-Received: from localhost ([127.0.0.1]:44975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gLYgv-0000uL-Gs for submit@debbugs.gnu.org; Sat, 10 Nov 2018 14:13:09 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:56714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gLYgt-0000tu-3r for submit@debbugs.gnu.org; Sat, 10 Nov 2018 14:13:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gLYgn-0003SY-AG for submit@debbugs.gnu.org; Sat, 10 Nov 2018 14:13:02 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:44709) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gLYgl-0003Rx-I9 for submit@debbugs.gnu.org; Sat, 10 Nov 2018 14:13:00 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38090) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gLYgk-0002pD-IP for bug-gnu-emacs@gnu.org; Sat, 10 Nov 2018 14:12:59 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gLYgd-0003N3-Px for bug-gnu-emacs@gnu.org; Sat, 10 Nov 2018 14:12:57 -0500 Original-Received: from userp2130.oracle.com ([156.151.31.86]:37368) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gLYgb-0003LO-R7 for bug-gnu-emacs@gnu.org; Sat, 10 Nov 2018 14:12:51 -0500 Original-Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wAAJ9f52133053 for ; Sat, 10 Nov 2018 19:12:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=7qzbW5vei+HPtMbnGuubTSM8UUD/70vVdbN9o+eHtRc=; b=Wp/HyROkIVIe2Do2LD71Tovy44kWi+JR4bXRSzSS6QGRutgmrK1kxlisJsuOEO8xBiyZ HCGDBvJY1UdBiTNsPc2+sxfEkKWfviHqmPFQWA3+/TKiJXw552Nl4A39A6RoSzbJwI2s g46SDWb1RCWpxRJuEI/btPA8xUfj5S2eyyYMKJj4ZV4paAQWmgdh0Nw/g2k4Ow8g7WdM Md94uGZPR6Zk3TzDsVTXY6HVldYGMMSWSFF+ED51gUmb5pW1aGAlSfZD1b9lmL5PxIHj IFN72z0oeOxKB+lnXmRPuLzI+Y4v0ajyt3xL2I1lfOrAJObnPx52A/TcqE0YysXrOSj1 3g== Original-Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2130.oracle.com with ESMTP id 2nnwg10nnr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sat, 10 Nov 2018 19:12:47 +0000 Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id wAAJCfWG015956 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sat, 10 Nov 2018 19:12:42 GMT Original-Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id wAAJCfnu020087 for ; Sat, 10 Nov 2018 19:12:41 GMT X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4756.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9073 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1811100146 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152263 Archived-At: Both of these doc strings seem to say that if function `system-move-file-to-trash' is defined then it is used, regardless of the value of option `trash-directory'. A cursory look at the code defining `move-file-to-trash' suggests otherwise. And that would seem to make sense, giving users a way to customize the directory in all cases. Are the doc strings wrong, or am I misreading the code? (cond (trash-directory ;; If `trash-directory' is non-nil, move the file there. ...) ;; If `system-move-file-to-trash' is defined, use it. ((fboundp 'system-move-file-to-trash) (system-move-file-to-trash filename)) ...) In GNU Emacs 26.1 (build 1, x86_64-w64-mingw32) of 2018-05-30 Repository revision: 07f8f9bc5a51f5aa94eb099f3e15fbe0c20ea1ea Windowing system distributor `Microsoft Corp.', version 10.0.16299 Configured using: `configure --without-dbus --host=3Dx86_64-w64-mingw32 --without-compress-install 'CFLAGS=3D-O2 -static -g3''