all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 38213@debbugs.gnu.org, juri@linkov.net
Subject: bug#38213: 27.0.50; add tooltip move-frame handling to mouse-avoidance-mode
Date: Fri, 15 Nov 2019 17:35:42 +0100	[thread overview]
Message-ID: <2cd747bd-a2b6-c42b-c051-9ea35225c079@gmx.at> (raw)
In-Reply-To: <83o8xd31v1.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 439 bytes --]

 > But the normal frame which hosts the tooltip is not moved in this
 > scenario.  To reproduce, turn on mouse-avoidance-mode (I used 'jump'
 > as the avoidance technique), then start Dired, and move the mouse to
 > the file name under cursor.  Here, the tooltip appears and immediately
 > disappears, and I see no movement of the "hosting" frame anywhere.

Hmm...  So you think that something like the attached should be
applied?

martin

[-- Attachment #2: move-frame.diffs --]
[-- Type: text/plain, Size: 969 bytes --]

diff --git a/src/w32term.c b/src/w32term.c
index d0537c67e9..17bf408c20 100644
--- a/src/w32term.c
+++ b/src/w32term.c
@@ -5314,7 +5314,8 @@ w32_read_socket (struct terminal *terminal,
 	case WM_MOVE:
 	  f = w32_window_to_frame (dpyinfo, msg.msg.hwnd);
 
-	  if (f && FRAME_VISIBLE_P (f) && !FRAME_ICONIFIED_P(f))
+	  if (f && FRAME_VISIBLE_P (f) && !FRAME_ICONIFIED_P(f)
+	      && !FRAME_TOOLTIP_P (f))
 	    {
 	      w32_real_positions (f, &f->left_pos, &f->top_pos);
 	      inev.kind = MOVE_FRAME_EVENT;
diff --git a/src/xterm.c b/src/xterm.c
index f7005804f0..d55bc3890d 100644
--- a/src/xterm.c
+++ b/src/xterm.c
@@ -9032,7 +9032,8 @@ handle_one_xevent (struct x_display_info *dpyinfo,
 		  unblock_input ();
 		}
 
-	      if (old_left != f->left_pos || old_top != f->top_pos)
+	      if (!FRAME_TOOLTIP_P (f)
+		  && (old_left != f->left_pos || old_top != f->top_pos))
 		{
 		  inev.ie.kind = MOVE_FRAME_EVENT;
 		  XSETFRAME (inev.ie.frame_or_window, f);


  reply	other threads:[~2019-11-15 16:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-14 23:32 bug#38213: 27.0.50; add tooltip move-frame handling to mouse-avoidance-mode Juri Linkov
2019-11-15  8:13 ` martin rudalics
2019-11-15  8:26 ` Eli Zaretskii
2019-11-15  8:53   ` martin rudalics
2019-11-15  9:50     ` Eli Zaretskii
2019-11-15 16:35       ` martin rudalics [this message]
2019-11-15 16:57         ` Eli Zaretskii
2019-11-16  8:19           ` martin rudalics
2019-11-21 21:31             ` Juri Linkov
2019-11-22  8:09               ` martin rudalics
2019-11-26 22:12                 ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2cd747bd-a2b6-c42b-c051-9ea35225c079@gmx.at \
    --to=rudalics@gmx.at \
    --cc=38213@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.