all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* allout patch to workaround discrepancies with new pgg interface (gpg-agent provisions)
@ 2006-12-23 18:02 Ken Manheimer
  2006-12-24  1:09 ` Chong Yidong
  2006-12-24  1:35 ` Richard Stallman
  0 siblings, 2 replies; 5+ messages in thread
From: Ken Manheimer @ 2006-12-23 18:02 UTC (permalink / raw)


[-- Attachment #1: Type: text/plain, Size: 1007 bytes --]

the attached patch works around problems with the new version of pgg's
use of pgg-agent.  when the agent is active, passphrases passed in to
pgg are effectively ignored, such that pgg-agent continues to prompt
(via pinentry) for the passphrase.   the patch inhibits use of the
agent just in the scope that allout does its encryption, and
acknowledges that inhibition in various relevant module commentaries.

though it would be best to have allout defer to gpg-agent, via pgg, it
may be complicated  to do that and preserve allout's full current
encryption features.  a simpler intermediate fix would be to have pgg
respect passed in passphrases, and not resort to pgg-agent.
-- 
ken
http://myriadicity.net


2006-12-22  Ken Manheimer  <ken.manheimer@gmail.com>

	* allout.el (allout-encrypt-string): Inhibit use of agent within
	body of let form where encryption happens.  Acknowledge non-use of
	gpg-agent in docstring.
	(allout-toggle-subtree-encryption): Acknowledge non-use of
	gpg-agent in docstring.

[-- Attachment #2: allout-patch.txt --]
[-- Type: text/plain, Size: 2326 bytes --]

Index: allout.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/allout.el,v
retrieving revision 1.90
diff -u -u -r1.90 allout.el
--- allout.el	3 Dec 2006 21:37:33 -0000	1.90
+++ allout.el	23 Dec 2006 17:52:34 -0000
@@ -45,7 +45,9 @@
 ;;  - Symmetric-key and key-pair topic encryption, plus symmetric passphrase
 ;;    mnemonic support, with verification against an established passphrase
 ;;    (using a stashed encrypted dummy string) and user-supplied hint
-;;    maintenance.  (See allout-toggle-current-subtree-encryption docstring.)
+;;    maintenance.  (See allout-toggle-current-subtree-encryption docstring.
+;;    Currently only GnuPG encryption is supported, and integration
+;;    with gpg-agent is not yet implemented.)
 ;;  - Automatic topic-number maintenance
 ;;  - "Hot-spot" operation, for single-keystroke maneuvering and
 ;;    exposure control (see the allout-mode docstring)
@@ -5748,7 +5750,8 @@
 passphrase cache.  With no universal argument, the appropriate passphrase
 is obtained from the cache, if available, else from the user.
 
-Currently only GnuPG encryption is supported.
+Currently only GnuPG encryption is supported, and integration
+with gpg-agent is not yet implemented.
 
 \**NOTE WELL** that the encrypted text must be ascii-armored.  For gnupg
 encryption, include the option ``armor'' in your ~/.gnupg/gpg.conf file.
@@ -5820,7 +5823,8 @@
 passphrase cache.  With no universal argument, the appropriate passphrase
 is obtained from the cache, if available, else from the user.
 
-Currently only GnuPG encryption is supported.
+Currently only GnuPG encryption is supported, and integration
+with gpg-agent is not yet implemented.
 
 \**NOTE WELL** that the encrypted text must be ascii-armored.  For gnupg
 encryption, include the option ``armor'' in your ~/.gnupg/gpg.conf file.
@@ -5996,7 +6000,9 @@
          (rejected (or rejected 0))
          (rejections-left (- allout-encryption-ciphertext-rejection-ceiling
                              rejected))
-         result-text status)
+         result-text status
+         ;; Inhibit use of gpg-agent in the scope of this let:
+         (pgg-gpg-use-agent nil))
 
     (if (and fetch-pass (not passphrase))
         ;; Force later fetch by evicting passphrase from the cache.

[-- Attachment #3: ChangeLog-entry.txt --]
[-- Type: text/plain, Size: 298 bytes --]

2006-12-22  Ken Manheimer  <ken.manheimer@gmail.com>

	* allout.el (allout-encrypt-string): Inhibit use of agent within
	body of let form where encryption happens.  Acknowledge non-use of
	gpg-agent in docstring.
	(allout-toggle-subtree-encryption): Acknowledge non-use of
	gpg-agent in docstring.

[-- Attachment #4: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2006-12-28 16:50 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-23 18:02 allout patch to workaround discrepancies with new pgg interface (gpg-agent provisions) Ken Manheimer
2006-12-24  1:09 ` Chong Yidong
2006-12-24  1:35 ` Richard Stallman
2006-12-25 18:23   ` Ken Manheimer
2006-12-28 16:50     ` Ken Manheimer

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.