icomplete.el patch to accommodate addition of internal-complete-buffer

* icomplete.el patch to accommodate addition of internal-complete-buffer
@ 2006-09-22 20:07 Ken Manheimer
  2006-09-23 18:41 ` Chong Yidong
  2006-09-23 23:37 ` Ken Manheimer
  0 siblings, 2 replies; 4+ messages in thread
From: Ken Manheimer @ 2006-09-22 20:07 UTC (permalink / raw)


[-- Attachment #1: Type: text/plain, Size: 1056 bytes --]

the attached patch reenables icomplete operation during interactive
buffer selection.  the ChangeLog entry is included below my signature,
and it's also attached along with the patch.

i would like to know about any other specialized completion
tables/functions that would be appropriate - and trivial - to include
among those that icomplete accepts.  i would even more like some way
for icomplete to automatically recognize those functions, but don't
know the territory well enough to be able to say whether that's even a
reasonable possibility.

in any case, would someone check this in?
-- 
ken
ken.manheimer@gmail.com
http://myriadicity.net

2006-09-22  Ken Manheimer  <ken.manheimer@gmail.com>

	* icomplete.el (icomplete-with-completion-tables): List of
	specialized completion tables with which icomplete should
	operate.  Include the new `internal-complete-buffer', so icomplete
	works with interactive buffer selection.
	(icomplete-simple-completing-p): Add acceptance of specialized
	completion tables listed in icomplete-with-completion-tables.

[-- Attachment #2: icomplete-patch.txt --]
[-- Type: text/plain, Size: 1201 bytes --]

--- icomplete.el	17 Feb 2006 16:54:35 -0500	1.38
+++ icomplete.el	22 Sep 2006 15:52:47 -0400	
@@ -157,6 +157,12 @@
 					 (< (length x) (length y))))
 			       ", ")
 		    ">"))))))
+;;;_  = icomplete-with-completion-tables
+(defvar icomplete-with-completion-tables '(internal-complete-buffer)
+  "Specialized completion tables with which icomplete should operate.
+
+Icomplete does not operate with any specialized completion tables
+except those on this list.")
 
 ;;;_ > icomplete-mode (&optional prefix)
 ;;;###autoload
@@ -184,8 +190,9 @@
   (and (window-minibuffer-p (selected-window))
        (not executing-kbd-macro)
        minibuffer-completion-table
-       ;; (or minibuffer-completing-file-name
-       (not (functionp minibuffer-completion-table)))) ;; )
+       (or (not (functionp minibuffer-completion-table))
+           (member minibuffer-completion-table
+                   icomplete-for-completion-tables))))
 
 ;;;_ > icomplete-minibuffer-setup ()
 (defun icomplete-minibuffer-setup ()
@@ -326,6 +333,7 @@
 ;;;_* Local emacs vars.
 ;;;Local variables:
 ;;;allout-layout: (-2 :)
+;;;allout-widgets-mode-inhibit: t
 ;;;End:
 
 ;; arch-tag: 339ec25a-0741-4eb6-be63-997532e89b0f

[-- Attachment #3: icomplete-ChangeLog.txt --]
[-- Type: text/plain, Size: 410 bytes --]

2006-09-22  Ken Manheimer  <ken.manheimer@gmail.com>

	* icomplete.el (icomplete-with-completion-tables): List of
	specialized completion tables with which icomplete should
	operate.  Include the new `internal-complete-buffer', so icomplete
	works with interactive buffer-selection.
	(icomplete-simple-completing-p): Add acceptance of specialized
	completion tables listed in icomplete-with-completion-tables.

[-- Attachment #4: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread