From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.bugs Subject: bug#36154: 26.2; read-passwd function creates a security issue Date: Thu, 10 Oct 2019 16:01:47 +1300 Message-ID: <2caa617d3aa54a8f441b5a0fa080c899@webmail.orcon.net.nz> References: <384906f0-1cfb-f813-3d2d-093ef65a1e69@itu.edu.tr> <87k19dtsag.fsf@gnus.org> <87v9sx77bf.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="38364"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Orcon Webmail Cc: Ahmet BASTUG , 36154@debbugs.gnu.org, Lars Ingebrigtsen To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 10 05:02:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iIOiQ-0009pL-Rd for geb-bug-gnu-emacs@m.gmane.org; Thu, 10 Oct 2019 05:02:10 +0200 Original-Received: from localhost ([::1]:33552 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIOiP-0000he-2r for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Oct 2019 23:02:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56343) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIOiJ-0000hW-RA for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 23:02:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIOiI-0002HU-QG for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 23:02:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46057) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iIOiI-0002HQ-Mr for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 23:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iIOiI-0000WB-4C for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 23:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Phil Sainty Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Oct 2019 03:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36154 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: security wontfix Original-Received: via spool by 36154-submit@debbugs.gnu.org id=B36154.15706765181980 (code B ref 36154); Thu, 10 Oct 2019 03:02:02 +0000 Original-Received: (at 36154) by debbugs.gnu.org; 10 Oct 2019 03:01:58 +0000 Original-Received: from localhost ([127.0.0.1]:54878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIOiD-0000Vs-Kv for submit@debbugs.gnu.org; Wed, 09 Oct 2019 23:01:57 -0400 Original-Received: from smtp-3.orcon.net.nz ([60.234.4.44]:55839) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIOiA-0000Vf-JB for 36154@debbugs.gnu.org; Wed, 09 Oct 2019 23:01:55 -0400 Original-Received: from [10.253.37.70] (port=43514 helo=webmail.orcon.net.nz) by smtp-3.orcon.net.nz with esmtpa (Exim 4.90_1) (envelope-from ) id 1iIOi3-00084C-Tk; Thu, 10 Oct 2019 16:01:48 +1300 Original-Received: from wlgwil-nat-office.catalyst.net.nz ([202.78.240.7]) via [10.253.37.253] by webmail.orcon.net.nz with HTTP (HTTP/1.1 POST); Thu, 10 Oct 2019 16:01:47 +1300 In-Reply-To: <87v9sx77bf.fsf@gmail.com> X-Sender: psainty@orcon.net.nz X-GeoIP: -- X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168833 Archived-At: On 2019-10-10 13:49, Noam Postavsky wrote: > Phil Sainty writes: >> A potential solution to this would to make the low-level kill >> functions >> respect a new `inhibit-kill-ring' variable, such that nothing would be >> added to the kill ring if that was non-nil. > > IMO, it would be bettter to rebind the kill commands to corresponding > delete commands in read-passwd-map. My main argument against that (at least as a complete solution) is that is necessitates *knowing* what all the kill commands are, and what their corresponding delete commands would be. This would also mean maintaining that moving forwards for standard commands; but that still wouldn't account for arbitrary third-party and custom commands which call `kill-new'. I think such remapping of standard commands would be entirely reasonable as an *additional* step (particularly if it was wrapped into a minor mode), but personally I think there is a greater benefit (with wider application) in the `inhibit-kill-ring' notion. -Phil