From: Dmitry Gutov <dmitry@gutov.dev>
To: Spencer Baugh <sbaugh@janestreet.com>, 71179@debbugs.gnu.org
Subject: bug#71179: [PATCH] In rgrep, check matching files before excluding files
Date: Fri, 24 May 2024 23:45:00 +0300 [thread overview]
Message-ID: <2c88f75b-6407-4eab-a5a5-0c16f005cd9f@gutov.dev> (raw)
In-Reply-To: <ierle3zotlc.fsf@janestreet.com>
Hi Spencer,
On 24/05/2024 23:14, Spencer Baugh wrote:
> If find checks the files glob first and then the excluding glob, it has
> to do much less checking (since the files glob will substantially narrow
> down the set of files on its own), and find performance is much better.
>
> In my benchmarking, this takes (rgrep "foo" "*.el" "~/src/emacs/trunk/")
> from ~410ms to ~130ms.
I can confirm improvement here (though not exactly 3x).
1.9s to 1.3s in a Linux checkout, for example. Nice.
Moving the files exclude instructions to the <F> placeholder is a slight
incompatibility, but I wonder if there are any custom grep-find-template
values which would be bothered by it (that's the only incompatibility I
could think of). Perhaps those that currently don't include <X> at all?
next prev parent reply other threads:[~2024-05-24 20:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-24 20:14 bug#71179: [PATCH] In rgrep, check matching files before excluding files Spencer Baugh
2024-05-24 20:45 ` Dmitry Gutov [this message]
2024-05-24 20:54 ` Spencer Baugh
2024-05-25 12:31 ` Dmitry Gutov
2024-05-26 6:50 ` Juri Linkov
2024-05-26 12:48 ` Spencer Baugh
2024-05-26 12:56 ` Dmitry Gutov
2024-05-25 6:36 ` Eli Zaretskii
2024-05-25 12:26 ` Dmitry Gutov
2024-05-25 12:51 ` Eli Zaretskii
2024-05-25 13:03 ` Dmitry Gutov
2024-05-25 13:45 ` Eli Zaretskii
2024-05-25 13:58 ` Dmitry Gutov
2024-05-25 13:36 ` Spencer Baugh
2024-05-25 13:56 ` Eli Zaretskii
2024-05-25 14:02 ` Spencer Baugh
2024-05-25 14:13 ` Eli Zaretskii
2024-05-25 14:47 ` Dmitry Gutov
2024-05-25 15:07 ` Eli Zaretskii
2024-05-26 13:42 ` Spencer Baugh
2024-06-01 14:15 ` Eli Zaretskii
2024-06-02 10:46 ` Stefan Kangas
2024-05-25 14:51 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c88f75b-6407-4eab-a5a5-0c16f005cd9f@gutov.dev \
--to=dmitry@gutov.dev \
--cc=71179@debbugs.gnu.org \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.