From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#64735: 29.0.92; find invocations are ~15x slower because of ignores Date: Sun, 23 Jul 2023 22:44:23 +0300 Message-ID: <2c03fa11-6c97-cbdd-567e-b5dba85b7f77@gutov.dev> References: <1fd5e3ed-e1c3-5d6e-897f-1d5d55e379fa@gutov.dev> <87wmyupvlw.fsf@localhost> <5c4d9bea-3eb9-b262-138a-4ea0cb203436@gutov.dev> <87tttypp2e.fsf@localhost> <87r0p030w0.fsf@yahoo.com> <83sf9f6wm0.fsf@gnu.org> <83sf9eub9d.fsf@gnu.org> <2d844a34-857d-3d59-b897-73372baac480@gutov.dev> <83bkg2tsu6.fsf@gnu.org> <83a5vmtrog.fsf@gnu.org> <1ff691d6-67fe-7aa5-75bc-435438e59152@gutov.dev> <837cqqtolx.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24213"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: luangruo@yahoo.com, sbaugh@janestreet.com, yantar92@posteo.net, 64735@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 23 21:45:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qNf16-00061W-CA for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 Jul 2023 21:45:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qNf0p-00061T-Jl; Sun, 23 Jul 2023 15:45:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qNf0o-00061K-IZ for bug-gnu-emacs@gnu.org; Sun, 23 Jul 2023 15:45:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qNf0o-0000LT-9O for bug-gnu-emacs@gnu.org; Sun, 23 Jul 2023 15:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qNf0n-0005LI-Mg for bug-gnu-emacs@gnu.org; Sun, 23 Jul 2023 15:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Jul 2023 19:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64735 X-GNU-PR-Package: emacs Original-Received: via spool by 64735-submit@debbugs.gnu.org id=B64735.169014147720493 (code B ref 64735); Sun, 23 Jul 2023 19:45:01 +0000 Original-Received: (at 64735) by debbugs.gnu.org; 23 Jul 2023 19:44:37 +0000 Original-Received: from localhost ([127.0.0.1]:41259 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNf0P-0005KT-2b for submit@debbugs.gnu.org; Sun, 23 Jul 2023 15:44:37 -0400 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:42355) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNf0K-0005KA-28 for 64735@debbugs.gnu.org; Sun, 23 Jul 2023 15:44:35 -0400 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 052885C00BF; Sun, 23 Jul 2023 15:44:26 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sun, 23 Jul 2023 15:44:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1690141466; x=1690227866; bh=AkWN7gpo2ZAb/gBv8GCIY3kbasv77uvb2RK T2gVvpQY=; b=h259HOPBWiGLsDZPiomiGJulL0HdMHEhCQFpblSkvy3Xeu7VXUu XoKxuTlSnuSsL5jLIDe9UOsNlYptSQ2EZqUzotqgwNHoV05AF1sBvTPfStuYhviW 96znj/wvQHPGxe1n0nUFDeUR8iOKikd+kaxxz2ritjkIDd6ySfRQdi8rZZbCtEtz 0aXQASYl3plwdA8yj4A3jsQ9THUQaOHEyZ6EhdrMNWhi1MQ1wWDTgO1o4/naGF1u dxqj29ATu31mn/JHIP4F2k/dQfMuGdYgPOCYSU2ghdUJPyoH8U0jAOWtBO87R97L 7kz7v+wKPyK9w5QStDu3878e52NU9uSsiBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1690141466; x=1690227866; bh=AkWN7gpo2ZAb/gBv8GCIY3kbasv77uvb2RK T2gVvpQY=; b=SwUOVS2kD8RASWGsyNzymKyjYF60PHZ20cx0ju7hMreeYfEzk1g 1TgVJEVqUkPtz+a3iIRFSmNeg7XanRBhj0w28VbnT0q0k7Ca3yJf2jBsn9XZYICD JhYItvs6bgIhmNLp0AROcLmEKaNHjncBJfdUWFZ5Msd9hmW1ewpV4AZfF+kqImc0 ZZ4ZFHx6NGHVMWIuy9MXIRoOo9ip7dagoeGLSCEFwRFVp5vZWGRbPoFt7l56yUCM xB67TgLKv5JnDK/7+DYoEspc9WtPSXCMk1+DGSa10Cp9lyrmwai2CndhZPJoiUA5 19wsoSH7nR6UTFlbbbX+BJQcTr3vKBQ04Ww== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrheeigddufeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 23 Jul 2023 15:44:24 -0400 (EDT) Content-Language: en-US In-Reply-To: <837cqqtolx.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265926 Archived-At: On 23/07/2023 22:27, Eli Zaretskii wrote: >> Far be it from me to insist, though, but if we indeed reimplemented all >> the good parts of 'find', that would make the new function a suitable >> replacement/improvement, at least on local hosts (instead of it just >> being used as a fallback). > The basic problem here is this: the regexp or pattern to filter out > ignorables is specified as a Lisp string, which is in the internal > Emacs representation of characters. So to compare file names we > receive either from Find or from a C API, we need either to decode the > file names we receive (which in practice means they should be Lisp > strings), or encode the regexp and use its C string payload. Yes, the latter sounds more fiddly, but it seems to be *the* way toward find's performance levels. But only the benchmarks can tell whether the hassle is worthwhile.