From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#36618: 26.2; Misnamed `*-hooks' variables Date: Sat, 13 Jul 2019 10:23:23 -0700 (PDT) Message-ID: <2b8f5747-6d20-494a-b727-fdd0b9245299@default> References: <87d0ievxm5.fsf@mouse.gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="236938"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36618@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 13 19:24:08 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hmLkl-000zSd-V3 for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 Jul 2019 19:24:08 +0200 Original-Received: from localhost ([::1]:57454 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmLkk-0006P0-AF for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 Jul 2019 13:24:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37320) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmLkh-0006NT-6w for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2019 13:24:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hmLkg-0003B1-7c for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2019 13:24:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34472) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hmLkg-0003Al-0T for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2019 13:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hmLkf-0005NQ-Qr for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2019 13:24:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Jul 2019 17:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36618 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 36618-submit@debbugs.gnu.org id=B36618.156303861520632 (code B ref 36618); Sat, 13 Jul 2019 17:24:01 +0000 Original-Received: (at 36618) by debbugs.gnu.org; 13 Jul 2019 17:23:35 +0000 Original-Received: from localhost ([127.0.0.1]:43293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmLkF-0005Mi-8k for submit@debbugs.gnu.org; Sat, 13 Jul 2019 13:23:35 -0400 Original-Received: from aserp2120.oracle.com ([141.146.126.78]:55462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmLkD-0005MU-8O for 36618@debbugs.gnu.org; Sat, 13 Jul 2019 13:23:33 -0400 Original-Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x6DHJD4S083104; Sat, 13 Jul 2019 17:23:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=OF6wSNmIwlGVmA7JP7eVgYGPDFWULhGGiVKS59BPKsk=; b=SWnnuFqnyhxPUrqUTzy7X1iIZupgaSEMXHN5xmt3/aaymT/UNB9W2XyAdYh80BGY9sMv qJswU0kaTibfC7acaAh46ZuPjucJ+bXCwD/PU9wIQvnJa5slRtLat1bMhqgxKqR2PWez 8iIll/YBrPF9GrOqiKRCkTwDc146ziBqn6HYy8S47Cokgpdp93sUBATMZ/283BI49WDU wkULl8Xtm8cGDq2Cxgw1/Y+54l8MwUBMq37u4mG4oRYV5llqTpyIfmaZoSNmSyEUCWIx 0AW7+Geh73Pc7tl03KWvXvl5kG3E6y7e4EMh3KfpXlD6joRPQjpGPsJDxk9GfuufM/ui yQ== Original-Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 2tq78p9ba1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 13 Jul 2019 17:23:27 +0000 Original-Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x6DHMtCI053286; Sat, 13 Jul 2019 17:23:26 GMT Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3020.oracle.com with ESMTP id 2tq741xqy9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 13 Jul 2019 17:23:26 +0000 Original-Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x6DHNO03032612; Sat, 13 Jul 2019 17:23:25 GMT In-Reply-To: <87d0ievxm5.fsf@mouse.gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4861.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9317 signatures=668688 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907130212 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9317 signatures=668688 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907130211 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162924 Archived-At: > > The following variable names end in `-hooks', instead of `-hook' or > > `-functions' (there may be more - just noticed these in one of my > > sessions): > > > > bookmark-exit-hooks (OBS) >=20 > As you say, there's nothing to be done about obsolete -hooks variables. >=20 > > delay-mode-hooks (Bool) >=20 > These bool variables have logical names -- they say whether to do > something or other about the hooks, so I don't think they should change > names. >=20 > > delayed-mode-hooks XXX >=20 > That's not really a -hook variable, but list of hook variables to run, > so it's fine: >=20 > (defvar-local delayed-mode-hooks nil > "List of delayed mode hooks waiting to be run.") >=20 > > ediff-before-session-group-setup-hooks XXX >=20 > This is a variable that's never used, apparently? I'll just mark it as > obsolete. >=20 > > recentf-used-hooks XXX >=20 > It's a list of hooks, not a hook, so has a correct name. >=20 > > unload-feature-special-hooks (aliased) >=20 > Same. >=20 > Nothing to be done for the rest; closing. IOW, "won't fix". Lists of hooks are not hooks. Boolean variables that control behavior of hooks are not hooks. A user looking for hooks will fall upon these misleading names of non-hooks using completion (e.g. substring). We can help her or mislead her. Currently we throw noise in her face. Not much noise - there are only a few such anomalies cited here.