From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#64347: 30.0.50; Some customize faces shown as edited with -Q Date: Fri, 30 Jun 2023 08:33:39 -0300 Message-ID: <2b6de9de-f33f-0547-eaa0-1f9d24f70115@gmail.com> References: <87jzvmd17f.fsf@gmx.net> <83cz1etpdm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20760"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Cc: Stephen Berman , 64347@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 30 13:34:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qFCOK-0005Cj-Le for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Jun 2023 13:34:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qFCO4-0002Kt-Ri; Fri, 30 Jun 2023 07:34:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qFCO2-0002KQ-RD for bug-gnu-emacs@gnu.org; Fri, 30 Jun 2023 07:34:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qFCO2-0008OE-IT for bug-gnu-emacs@gnu.org; Fri, 30 Jun 2023 07:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qFCO2-0002bR-0E for bug-gnu-emacs@gnu.org; Fri, 30 Jun 2023 07:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Jun 2023 11:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64347 X-GNU-PR-Package: emacs Original-Received: via spool by 64347-submit@debbugs.gnu.org id=B64347.16881248329983 (code B ref 64347); Fri, 30 Jun 2023 11:34:01 +0000 Original-Received: (at 64347) by debbugs.gnu.org; 30 Jun 2023 11:33:52 +0000 Original-Received: from localhost ([127.0.0.1]:54602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qFCNr-0002aw-LL for submit@debbugs.gnu.org; Fri, 30 Jun 2023 07:33:52 -0400 Original-Received: from mail-oa1-f43.google.com ([209.85.160.43]:57800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qFCNp-0002ah-AH for 64347@debbugs.gnu.org; Fri, 30 Jun 2023 07:33:49 -0400 Original-Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-1b060bce5b0so1616222fac.3 for <64347@debbugs.gnu.org>; Fri, 30 Jun 2023 04:33:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688124823; x=1690716823; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iCmxn53HWQTYZwCJrap439wu7pdS4POI6fjBn8m0vr8=; b=lApE5cATdiBjV/vu6q/+5kovv/4d+LwlzvxmXbL8TM22xgInF64SvLbdMKo5DASiY/ HsL/m+MDxHsw1BimRCg1acJwSS4a2dZ0tccWgvzkNQHd6v7swkri9z6B2v9F8gCw6ShN sVOeBjvfnsmaAoShYcAlbwL/U8DRE7C2FsWr6JSxqKJUcLMfokiu4IKuavYgaAS1QcVR M6/0xMjbmD3IvTKt+HkY3vx+u5NEQCoFOf6EL+4OfoODmaWsUOGl2WlAIkjpRUUcKiE2 5Ja+FiLOcdveTg3V3622Ef0RSprSEU2RwUujFp/T44psxHkgBK4NyImY2K5bbTqcVspr rjUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688124823; x=1690716823; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iCmxn53HWQTYZwCJrap439wu7pdS4POI6fjBn8m0vr8=; b=A3aUmpBjwVuQHH8IgIg7o72T1z+u0EMG8J3jSCMsIhqAOIzMUAXejUa2l+YLXXLCRZ oEmHVgLoo8tv7tKuDFeS+BKLz6oMAb/ItO3HVV0waIgLLYrUW4AaKnIDpSGO6UIzA6/l jXWx+w+K4TvySvIBNtG2Y5An1pr4kQXH0/syENdd0POgkz1zHNcoLtm7ocrN0GAMz0fC qlZvw0ZBGKlwIm1+oDcXNqgaoEbsLxLi/ffvgeylI9TztlviX5EnE4Bs90trxoP3TjS1 vHNWvjMfCBiaP4EpXG5kT8vds5gXuiw/cdAR+AntggHUs0eE9YuFK5SprLQE+atjqaLf ia5g== X-Gm-Message-State: ABy/qLaEmYl3BpohxR/jvYO9/ujs05IMw6GIg4atce1/kQwR9EYBzCkd XMPDO2i+415pSZhNPiL23ig= X-Google-Smtp-Source: APBJJlH3p8QEaM/fGwrylcCyCnZSG8gCTZzdd33Eo13XrU8imJnGcVFUz5iJKEQtTvmKP1OrXy+l/Q== X-Received: by 2002:a05:6871:288:b0:1b0:4ee7:a753 with SMTP id i8-20020a056871028800b001b04ee7a753mr3407199oae.37.1688124823334; Fri, 30 Jun 2023 04:33:43 -0700 (PDT) Original-Received: from [192.168.0.234] ([186.127.128.249]) by smtp.gmail.com with ESMTPSA id l10-20020a056870f14a00b001b011efb1ebsm8349377oac.0.2023.06.30.04.33.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Jun 2023 04:33:42 -0700 (PDT) Content-Language: en-US In-Reply-To: <83cz1etpdm.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264312 Archived-At: Eli Zaretskii writes: >> From: Stephen Berman >> Date: Thu, 29 Jun 2023 12:15:00 +0200 >> >> 0. emacs -Q >> 1. M-x customize-face RET RET >> 2. Toggle all face entries in the buffer *Customize Faces* (e.g. by >>    creating this keyboard macro: C-s C-q C-j S RET C-f and then >>    executing it 164 times) and search for the string "EDITED" in the >>    buffer. >>    => The following faces show the State "EDITED, shown value does not >>    take effect until you set or save it.": >>    confusingly-reordered >>    custom-button >>    custom-button-mouse >>    custom-button-pressed >>    mode-line >>    mode-line-highlight >>    mode-line-inactive >>    tab-bar-tab >>    tool-bar >>    All other faces show the State "STANDARD". >> 3. Clicking the State button of these faces and selecting either "Undo >>    Edits" or "Revert This Session's Customization" does not change the >>    State shown. >> 4. Clicking the State button of, e.g., mode-line and selecting "Set for >>    Current Session" changes the State shown to "SET for current session >>    only."  I see no difference in the appearance of the mode line before >>    and after this State change. >> 5. Clicking the State button of mode-line again and selecting "Revert >>    This Session's Customization" changes the State shown back to >>    "EDITED, shown value does not take effect until you set or save it.", >>    and again the appearance of the mode-line is unchanged. > > This is a regression between Emacs 27.2 and Emacs 28.1. Bisecting > will be welcome. I tried to bisect but I'm finding build errors on older commits: CC       sysdep.o sysdep.c:1784:22: error: variably modified ‘sigsegv_stack’ at file scope  1784 | static unsigned char sigsegv_stack[SIGSTKSZ]; So I did some debugging.  I noted that all the faces posted by Stephen (except confusingly-reordered) have a Horizontal Width widget.  So something like this is enough to get Custom confused: (defface test   '((t :box (:line-width 2 :style released-button)))   "...") M-x customize-face RET test Shows the EDITED State. So that points to Custom fiddling with the real value, i.e., what face-attribute would return, but not with the "customized value", the value that holds the Widget. Looking at the changes in custom-face-attributes, I see this commit: commit 34ae2d0c220c945443e94a43d043a4a63c444bf4 Author: Alexandre Adolphe Date:   Sat Aug 10 22:57:24 2019 +0200     Allow negative line width for :box face attribute And I noticed that it modified the real-value filter, but not the customized-value filter.  So I suspect that might be the problem. Maybe someone that is able to build Emacs for that and previous commits can confirm. In the meantime, I'll read the documentation on :line-width, since I'm pretty sure a changed in the customized value filter is required. (And I don't know what's wrong with the confusingly-reordered face yet)