From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Date: Fri, 19 May 2023 09:31:48 +0200 Message-ID: <2b1dade6-740f-6add-b6f0-4677a1c09789@gmx.at> References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> <83cz4u9uz1.fsf@gnu.org> <86jzz2f8si.fsf@mail.linkov.net> <83sfdq86pi.fsf@gnu.org> <835yal82ta.fsf@gnu.org> <86a5zuw5oo.fsf@mail.linkov.net> <87cz4oq485.fsf@fastmail.com> <86pm8nfoja.fsf@mail.linkov.net> <867cuukuvj.fsf@mail.linkov.net> <86lejajex8.fsf@mail.linkov.net> <86h6t3q3nt.fsf@mail.linkov.net> <86ttwckwqf.fsf@mail.linkov.net> <861qjgkvui.fsf@mail.linkov.net> <0c52f6ed-c3e2-6d9e-6d57-6f3779257b25@gmx.at> <86ilcqnbsp.fsf@mail.linkov.net> <3a021a53-814d-3721-31fb-b77f4087a455@gmx.at> <86wn153b43.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2067"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62427@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 19 09:32:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pzubB-0000Jv-Ib for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 May 2023 09:32:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pzuat-0004qy-9r; Fri, 19 May 2023 03:32:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzuao-0004px-EY for bug-gnu-emacs@gnu.org; Fri, 19 May 2023 03:32:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pzuao-0002S0-6b for bug-gnu-emacs@gnu.org; Fri, 19 May 2023 03:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pzuao-0004fZ-1H for bug-gnu-emacs@gnu.org; Fri, 19 May 2023 03:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 May 2023 07:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs Original-Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.168448151817938 (code B ref 62427); Fri, 19 May 2023 07:32:01 +0000 Original-Received: (at 62427) by debbugs.gnu.org; 19 May 2023 07:31:58 +0000 Original-Received: from localhost ([127.0.0.1]:55318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzuak-0004fG-32 for submit@debbugs.gnu.org; Fri, 19 May 2023 03:31:58 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:51981) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzuah-0004f0-Qh for 62427@debbugs.gnu.org; Fri, 19 May 2023 03:31:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1684481509; i=rudalics@gmx.at; bh=iuRGeu5fgduyVA1D+gXNGkGTQNms3fU1G5eMqaiI+r4=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=VvdxBg6CgF/iGg6GDPTG9/PwTmBZ38EbLat1kRlfpPgkHcwvIpcSmgYXIPSJfedlG uDNOAaqXEUIsP86jVipSy5xA7sh9bi6l0Gm3XvvWrYLGQ/AsqEckmXWD2qmxZWezzj bFu3Xo0rgDwWRHNlF/b/AJmQ3RLeynuPjZi7uFt/bFVH4m/C17vxksapgozoHM7SLD sdRAvCIhuXHqPVWyHz2E9W7ffSoVAL+p/b2oc81Bf+Rtb//sSqsN2BoEytKvdDVClJ ZS1lr0fvgfAhmhhRUOyhp3+cC+Wgpq0zQ8NhdR6NNnBKwD34soqNoMjXF9WFEdvBTN 2Afbo1UQB3vjw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from [192.168.1.100] ([46.125.249.114]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N3KPq-1q8Kmt2LZa-010OKo; Fri, 19 May 2023 09:31:49 +0200 Content-Language: en-US In-Reply-To: <86wn153b43.fsf@mail.linkov.net> X-Provags-ID: V03:K1:E4gaV8BknpeDCfV+4CIpvrVw9ByNoYUm6cTE1RzCiar5IwvoTUo hnVAIxwBRZSDNFvH5yJNwbgcfQNLE3rUSfnsNMf/IRRXLA57b/ImSWmdh5MEDK5Ohtk335B wk8YBEb8ZwAzKsH9Yoky05ZQPzSzfEBNiTAlowsQw8m9S6JJP0VTLBCed538bGQ5mjwmOku OR13s9gc1sc71m3HKrWlg== UI-OutboundReport: notjunk:1;M01:P0:IZvRlICM9hk=;J0ekZdH5D/LDYxhL634TKuY/bK7 MN5tw8gogno53/ji3fRzsZN9CpUq+TdAJ50cvbmX5/npwPd6alXagNltsT+aawoWNT6McOSUY fw+FWo4cN0TkQPTWzMnDcHAznnIcNX2XJ0jDNCf7FpoVR58bDD+vbIWFHgRwaKYhc3Qz1Cu5b SWqLbq75jbccPvpXNVrZZaepGrUTbyVJ2U84ZzypFTikiBCO37Da9g+Q7J8Rz1bP5EEwVksGC 9BX/abheQG6eEy4815szZjPC0BSP14lieTq2rHw86pD8dBFQt8mG0hzfIpO9/jbBOh2ksp9si VrMNo0vORBIs2k1JgPf0OpneF1EjtB4unDzD0+3pCxxJ2oZOGYMtaur8m2bfgqmb8R8xK4dhu cMapF7jVRg4utoJL8U4GBF8NUbAKz99efKe1cOAMH1fbkW7rtUA+liEgT2mI8SfGLNkNuyRQz +gW97KYqPDGZR3iumxr4JMGiJpZ1FPDaREs6ksfy6tgA5IXNqRHTqk3XHmiamDIZHKvHZ2X5o RSr9B1X0qZDDO6HpZjPJk8J2kgoZU0i72EDKleWw8uWA5LIJ5DLxrTk9+ziLu3w8RbuiIrU+F 6DuSqJhAS5hAEZOPAWD5XgCl7VHS23XNxkZB/HnhwRRRnYO4r/dfve4kLiyuoygU7KKCQ289i Ur8YfZ3vn5XyEC5CKlnF0PKRgqiIx+JT7mMJu+Sw1ytoq18MiFZKIoQFeI1BNUKwZkBr+tvb+ 7+obutDembqHcpLVVlFHlRLg9z3kRWINwkqmv0tvSxfvb1pvoWjKWIK4UePvucLiWbO0SwHL X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261987 Archived-At: > + (when (minibufferp) (select-window (get-mru-window))) Here and below I'd use (when (window-minibuffer-p) because it more clearly demonstrates the idea and also handles the (unlikely) case where a minibuffer is shown in a normal window. > (window-state-put ws nil 'safe))) > > ;; Select the minibuffer when it was active before switching tabs > @@ -1575,8 +1575,7 @@ tab-bar-new-tab-to > > (when tab-bar-new-tab-choice > ;; Handle the case when it's called in the active minibuffer. > - (when (minibuffer-selected-window) > - (select-window (minibuffer-selected-window))) > + (when (minibufferp) (select-window (get-mru-window))) > (let ((ignore-window-parameters t) > (window--sides-inhibit-check t)) > (if (eq tab-bar-new-tab-choice 'clone) You might want to try this with multiple frames (some of them without their own minibuffer window) jumping from one frame to another within the scope of 'read-from-minibuffer'. martin