From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master d20acfe: Fix Gnus registry pruning and sorting, and rename file Date: Fri, 19 Dec 2014 02:39:23 -0500 Message-ID: <2aioh8hyvo.fsf@fencepost.gnu.org> References: <20141218112235.14020.81034@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1418974794 27497 80.91.229.3 (19 Dec 2014 07:39:54 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 19 Dec 2014 07:39:54 +0000 (UTC) Cc: Eric Abrahamsen , Katsumi Yamaoka To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 19 08:39:46 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Y1sA6-0004ls-AS for ged-emacs-devel@m.gmane.org; Fri, 19 Dec 2014 08:39:46 +0100 Original-Received: from localhost ([::1]:57136 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1sA5-0002PG-QJ for ged-emacs-devel@m.gmane.org; Fri, 19 Dec 2014 02:39:45 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47843) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1s9q-0002OD-Kv for emacs-devel@gnu.org; Fri, 19 Dec 2014 02:39:31 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y1s9m-0002Bb-JQ for emacs-devel@gnu.org; Fri, 19 Dec 2014 02:39:30 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36585) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1s9m-0002BX-Fh for emacs-devel@gnu.org; Fri, 19 Dec 2014 02:39:26 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Y1s9j-0007Dm-UX; Fri, 19 Dec 2014 02:39:24 -0500 X-Spook: tempest ANDVT Mole ASIO codes halcon diwn Maple X-Ran: C]Qft?w'*`*[2X`<8pVk}weeM-a'-1UpFV:IM/A$;Eyp,tNOHqIz\,}l@7]B+L|M#(YC-6 X-Hue: green X-Attribution: GM User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:180313 Archived-At: Some small comments on this change: > +(make-obsolete-variable 'gnus-registry-max-pruned-entries nil "24.4") I think you meant 25.1. Also, you haven't made it obsolete, you've removed it entirely: > -(defcustom gnus-registry-max-pruned-entries nil > - "Maximum number of pruned entries in the registry, nil for unlimited." > - :version "24.1" > +(defcustom gnus-registry-prune-factor 0.1 [...] > + :version "24.4" Again, 25.1. > +(defcustom gnus-registry-default-sort-function > + #'gnus-registry-sort-by-creation-time > + "Sort function to use when pruning the registry. > + > +Entries which sort to the front of the list will be pruned > +first. > + > +This can slow pruning down. Set to nil to perform no sorting." > + :version "24.4" > + :group 'gnus-registry > + :type 'symbol) Again, 25.1. Also, a better :type would be: (choice (const :tag "No sorting" nil) function) Also, as a general comment, Gnus changes almost never seem to get NEWS (or GNUS-NEWS) entries.