Replace deprecated org-set-local by setq-local in the documentation

Replace deprecated org-set-local by setq-local in the documentation

[Loïc Estève]

Hi,

looks like org-set-local does not exist any more but it is still 
featured in the documentation.

I have the change in a branch on github:
https://github.com/lesteve/org-mode/compare/remove-org-set-local-from-doc

Cheers,
Loïc

Re: Replace deprecated org-set-local by setq-local in the documentation

[Nicolas Goaziou]

Hello,

Loïc Estève <loic.esteve@ymail.com> writes:

> looks like org-set-local does not exist any more but it is still
> featured in the documentation.
>
> I have the change in a branch on github:
> https://github.com/lesteve/org-mode/compare/remove-org-set-local-from-doc

Thank you.

Could you send the patch on this ML so that I can apply it?

You will need to add TINYCHANGE at the end of the commit message if you
haven't signed FSF papers yet.

Regards,

-- 
Nicolas Goaziou

Re: Replace deprecated org-set-local by setq-local in the documentation

[Loïc Estève]

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]


> Could you send the patch on this ML so that I can apply it?
>
> You will need to add TINYCHANGE at the end of the commit message if you
> haven't signed FSF papers yet.

Thanks for your prompt reply, I attached the patch. I tried my best to 
follow the instructions in http://orgmode.org/worg/org-contribute.html. 
Let me know if I need to change something.

Cheers,
Loïc

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: replace-org-set-local.patch --]
[-- Type: text/x-patch; name="replace-org-set-local.patch", Size: 1293 bytes --]

commit ce1d662c4a8647cf9c01dd5a2e661e937964741d
Author: Loïc Estève <loic.esteve@ymail.com>
Date:   Wed Feb 1 09:44:05 2017 +0100

    Replace org-set-local by setq-local in the documentation
    
    * contrib/orgmanual.org (Conflicts): Update yasnippet instructions.
    
    * doc/org.texi (Packages that conflict with Org mode): Update
      yasnippet instructions
    
    TINYCHANGE

diff --git a/contrib/orgmanual.org b/contrib/orgmanual.org
index d2275af..21011cd 100644
--- a/contrib/orgmanual.org
+++ b/contrib/orgmanual.org
@@ -16760,7 +16760,7 @@ region even if the cursor moves across a special context.
   #+begin_src emacs-lisp
   (add-hook 'org-mode-hook
             (lambda ()
-              (org-set-local 'yas/trigger-key [tab])
+              (setq-local yas/trigger-key [tab])
               (define-key yas/keymap [tab] 'yas/next-field-or-maybe-expand)))
   #+end_src
 
diff --git a/doc/org.texi b/doc/org.texi
index f68ef6e..4c3e140 100644
--- a/doc/org.texi
+++ b/doc/org.texi
@@ -17661,7 +17661,7 @@ fixed this problem:
 @lisp
 (add-hook 'org-mode-hook
           (lambda ()
-            (org-set-local 'yas/trigger-key [tab])
+            (setq-local yas/trigger-key [tab])
             (define-key yas/keymap [tab] 'yas/next-field-or-maybe-expand)))
 @end lisp
 

Re: Replace deprecated org-set-local by setq-local in the documentation

[Nicolas Goaziou]

Loïc Estève <loic.esteve@ymail.com> writes:

>> Could you send the patch on this ML so that I can apply it?
>>
>> You will need to add TINYCHANGE at the end of the commit message if you
>> haven't signed FSF papers yet.
>
> Thanks for your prompt reply, I attached the patch. I tried my best to
> follow the instructions in
> http://orgmode.org/worg/org-contribute.html. Let me know if I need to
> change something.

I applied your patch. Thank you.

Unfortunately, I realized too late this was a plain patch and not
something generated by git format-patch. Therefore, I appear as the
author of the patch. Sorry about that.


Regards,

Re: Replace deprecated org-set-local by setq-local in the documentation

[Loïc Estève]

> I applied your patch. Thank you.
>
> Unfortunately, I realized too late this was a plain patch and not
> something generated by git format-patch. Therefore, I appear as the
> author of the patch. Sorry about that.

Great, thanks a lot ! I don't care too much about authorship to be 
honest. I did try to use git format-patch but failed to get anywhere in 
less than two minutes so I eventually gave up ...

Cheers,
Loïc