Support text-shadow on for Emacs face

Support text-shadow on for Emacs face

[stardiviner]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256


I found an patch (https://github.com/ksqsf/emacsmoe/pull/1/files) for Emacs on macOS.

Is it possible to let Emacs support this by default for Linux system?

I hope Emacs can implement this feature. It make Emacs more feasible of looks awesome.

- -- 
[ stardiviner ]
       I try to make every word tell the meaning that I want to express.

       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner, Matrix: stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
      
-----BEGIN PGP SIGNATURE-----

iQFIBAEBCAAyFiEE8J9lDX1nSBmJJZFAG13xyVromsMFAl7Hua4UHG51bWJjaGls
ZEBnbWFpbC5jb20ACgkQG13xyVromsMdIQgA0ieA+w6elXPPguDWqWDk1SH9qhZG
P9j+dqBfg7FHrAg5AM9vdIX2xjlfXPdQI1Urlo7YKZp3QfW9sNMXg2genTR7WzRw
abugMYGtD5XaMA7Qi+jZ71sgqjiuywmMEdYuG3d4yXKVXBTObWRhtvS+rUl+GoQf
L60V1fxfAiICrOumr9UBdbMfI/WND9VijZiQbOk0dz9tR1CYql5hgR5dmQW9MWAx
UPzxMuckZGT8POErHSMvNHaGJsvWRMvM5gyLpZZIPCjMKNRiPRikLuVKSC3Ii/zb
GmD0xHMvE8AIlyOQgnM0oQC+yDfYYRGnQyAJh6aHTQpzfVMnxfxIKyeSWg==
=MUx1
-----END PGP SIGNATURE-----

Re: Support text-shadow on for Emacs face

[Dmitry Gutov]

On 22.05.2020 14:38, stardiviner wrote:
> I found an patch (https://github.com/ksqsf/emacsmoe/pull/1/files) for Emacs on macOS.
> 
> Is it possible to let Emacs support this by default for Linux system?
> 
> I hope Emacs can implement this feature. It make Emacs more feasible of looks awesome.

Looks pretty fun.

Here's a picture for anybody curious:

https://repository-images.githubusercontent.com/184457193/69dcff00-14d2-11ea-90e1-4bdf6fef80ca

Re: Support text-shadow on for Emacs face

[Eli Zaretskii]

> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Fri, 22 May 2020 15:28:12 +0300
> 
> On 22.05.2020 14:38, stardiviner wrote:
> > I found an patch (https://github.com/ksqsf/emacsmoe/pull/1/files) for Emacs on macOS.
> > 
> > Is it possible to let Emacs support this by default for Linux system?
> > 
> > I hope Emacs can implement this feature. It make Emacs more feasible of looks awesome.
> 
> Looks pretty fun.
> 
> Here's a picture for anybody curious:
> 
> https://repository-images.githubusercontent.com/184457193/69dcff00-14d2-11ea-90e1-4bdf6fef80ca

What should I be looking at?  I don't think I see any "shadow" there.

Re: Support text-shadow on for Emacs face

[Dmitry Gutov]

On 22.05.2020 15:40, Eli Zaretskii wrote:
>> Looks pretty fun.
>>
>> Here's a picture for anybody curious:
>>
>> https://repository-images.githubusercontent.com/184457193/69dcff00-14d2-11ea-90e1-4bdf6fef80ca
> What should I be looking at?  I don't think I see any "shadow" there.

IIUC, it's the "fuzzy" effect around some of the characters. The pink 
and yellow ones, on this picture.

And here's the design document, I guess: 
https://github.com/ksqsf/emacsmoe/wiki/Text-Shadow

Re: Support text-shadow on for Emacs face

[Eli Zaretskii]

> Cc: numbchild@gmail.com, emacs-devel@gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Fri, 22 May 2020 15:44:33 +0300
> 
> And here's the design document, I guess: 
> https://github.com/ksqsf/emacsmoe/wiki/Text-Shadow

I only see macOS-specific changes there.

Re: Support text-shadow on for Emacs face

[Dmitry Gutov]

On 22.05.2020 15:58, Eli Zaretskii wrote:
>> And here's the design document, I guess:
>> https://github.com/ksqsf/emacsmoe/wiki/Text-Shadow
> I only see macOS-specific changes there.

You mean the implementation section? Indeed. The original message in 
this thread said as much.

"cairo text shadow" gives some results on web search, though. This one 
looks the most credible: 
https://lists.cairographics.org/archives/cairo/2010-September/020915.html

It's old, though, and the links inside seem to have died. Want me to 
hunt them down?

Re: Support text-shadow on for Emacs face

[Eli Zaretskii]

> Cc: numbchild@gmail.com, emacs-devel@gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Fri, 22 May 2020 16:06:26 +0300
> 
> On 22.05.2020 15:58, Eli Zaretskii wrote:
> >> And here's the design document, I guess:
> >> https://github.com/ksqsf/emacsmoe/wiki/Text-Shadow
> > I only see macOS-specific changes there.
> 
> You mean the implementation section? Indeed. The original message in 
> this thread said as much.

But the text there says there should be changes in xfaces.c etc.  I
wonder how can I see those changes.

> "cairo text shadow" gives some results on web search, though. This one 
> looks the most credible: 
> https://lists.cairographics.org/archives/cairo/2010-September/020915.html
> 
> It's old, though, and the links inside seem to have died. Want me to 
> hunt them down?
 
Given the description, I'm not sure it's worth our while, but if you
can find the patches without investing too much time, it will be
appreciated.  Thanks.

Re: Support text-shadow on for Emacs face

[Dmitry Gutov]

On 22.05.2020 16:19, Eli Zaretskii wrote:
>> Cc: numbchild@gmail.com, emacs-devel@gnu.org
>> From: Dmitry Gutov <dgutov@yandex.ru>
>> Date: Fri, 22 May 2020 16:06:26 +0300
>>
>> On 22.05.2020 15:58, Eli Zaretskii wrote:
>>>> And here's the design document, I guess:
>>>> https://github.com/ksqsf/emacsmoe/wiki/Text-Shadow
>>> I only see macOS-specific changes there.
>>
>> You mean the implementation section? Indeed. The original message in
>> this thread said as much.
> 
> But the text there says there should be changes in xfaces.c etc.  I
> wonder how can I see those changes.

They're inside the PR, already linked to in the original message.

Here, at the bottom: https://github.com/ksqsf/emacsmoe/pull/1/files

Whether you should read it, I don't know, considering there's no 
copyright assignment, and someone might have to re-implement the code. 
But the changes are not particularly long or surprising.

>> "cairo text shadow" gives some results on web search, though. This one
>> looks the most credible:
>> https://lists.cairographics.org/archives/cairo/2010-September/020915.html
>>
>> It's old, though, and the links inside seem to have died. Want me to
>> hunt them down?
>   
> Given the description, I'm not sure it's worth our while,

Perhaps you meant "patches welcome"?

> but if you
> can find the patches without investing too much time, it will be
> appreciated.  Thanks.

There is no ready patch for Emacs for this part.

One is "how Firefox implements text-shadow". Apparently, this is how 
it's done these days: 
https://searchfox.org/mozilla-central/source/gfx/thebes/gfxBlur.cpp

And the second example lives here now: 
https://github.com/syndicodefront/infekt/blob/master/src/lib/cairo_box_blur.cpp

Re: Support text-shadow on for Emacs face

[stardiviner]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256


Yes, I'm think this is a great feature for Emacs. It will make Emacs looks
awesome in some places.

Dimitry, I also found your first replied VS Code's theme screenshot. It looks
great! right.

That's why I hope Emacs can have this too.

I don't know C/C++ programming, but I checked my posted patch's source code,
it's not long. I think it might nor hard to implement in Emacs on Linux. Maybe
other operating system platforms.

Dmitry Gutov <dgutov@yandex.ru> writes:

> On 22.05.2020 16:19, Eli Zaretskii wrote:
>>> Cc: numbchild@gmail.com, emacs-devel@gnu.org
>>> From: Dmitry Gutov <dgutov@yandex.ru>
>>> Date: Fri, 22 May 2020 16:06:26 +0300
>>>
>>> On 22.05.2020 15:58, Eli Zaretskii wrote:
>>>>> And here's the design document, I guess:
>>>>> https://github.com/ksqsf/emacsmoe/wiki/Text-Shadow
>>>> I only see macOS-specific changes there.
>>>
>>> You mean the implementation section? Indeed. The original message in
>>> this thread said as much.
>> But the text there says there should be changes in xfaces.c etc.  I
>> wonder how can I see those changes.
>
> They're inside the PR, already linked to in the original message.
>
> Here, at the bottom: https://github.com/ksqsf/emacsmoe/pull/1/files
>
> Whether you should read it, I don't know, considering there's no copyright
> assignment, and someone might have to re-implement the code. But the changes are
> not particularly long or surprising.
>
>>> "cairo text shadow" gives some results on web search, though. This one
>>> looks the most credible:
>>> https://lists.cairographics.org/archives/cairo/2010-September/020915.html
>>>
>>> It's old, though, and the links inside seem to have died. Want me to
>>> hunt them down?
>>   Given the description, I'm not sure it's worth our while,
>
> Perhaps you meant "patches welcome"?
>
>> but if you
>> can find the patches without investing too much time, it will be
>> appreciated.  Thanks.
>
> There is no ready patch for Emacs for this part.
>
> One is "how Firefox implements text-shadow". Apparently, this is how it's done
> these days: https://searchfox.org/mozilla-central/source/gfx/thebes/gfxBlur.cpp
>
> And the second example lives here now:
> https://github.com/syndicodefront/infekt/blob/master/src/lib/cairo_box_blur.cpp


- -- 
[ stardiviner ]
       I try to make every word tell the meaning that I want to express.

       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner, Matrix: stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
      
-----BEGIN PGP SIGNATURE-----

iQFIBAEBCAAyFiEE8J9lDX1nSBmJJZFAG13xyVromsMFAl7IdNIUHG51bWJjaGls
ZEBnbWFpbC5jb20ACgkQG13xyVromsNwygf6A3KmMvcyqXmb45g24MznKKqptTfy
xq+sajFBMow8Q/8xH5Qo8aWsgUgJuOwNdiO9edr7dBVFQ77Uu9V0Klest8KGQ/bZ
IhQYvpjVkE9gjAACUK4LPeG8TEb1pfOxnjAsMbNvZnjdQ22dt1NdY8xmrGpblzku
/cQngiBAU93KhXUWylyVyWaBg1ptl8YtLloGJGPcfavqU7ty9m6PuXsfmF/Puv27
5RTGEI63KdVApDvZPg0vCIWWEv6ZZZCNLp1f6rRwtz59S9kFm/0SyC96884CFBcR
xhd5isz64Fjw762hwXv1ff/4qBdja8TR0X5AsVsByBttmzuyDHF4jz44/Q==
=JM+c
-----END PGP SIGNATURE-----

Re: Support text-shadow on for Emacs face

[Dmitry Gutov]

On 23.05.2020 10:04, Eli Zaretskii wrote:
> OK, but the actual implementation is still only for macOS

Just like the first message in this thread said.

In the meantime, I've asked the author about the state of Linux support. 
Unfortunately, they're stopped working on it at the moment.

Re: Support text-shadow on for Emacs face

[stardiviner]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256


Dmitry Gutov <dgutov@yandex.ru> writes:

> On 23.05.2020 10:04, Eli Zaretskii wrote:
>> OK, but the actual implementation is still only for macOS
>
> Just like the first message in this thread said.
>
> In the meantime, I've asked the author about the state of Linux support.
> Unfortunately, they're stopped working on it at the moment.

I can contact the author of this patch, he doesn't have progress on supporting
Linux. I'm thinking whether Emacs-dev team can implement this feature by own
design. Or maybe considering merge this macOS support patch at first or any
plan?

- -- 
[ stardiviner ]
       I try to make every word tell the meaning that I want to express.

       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner, Matrix: stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
      
-----BEGIN PGP SIGNATURE-----

iQFIBAEBCAAyFiEE8J9lDX1nSBmJJZFAG13xyVromsMFAl7JGDwUHG51bWJjaGls
ZEBnbWFpbC5jb20ACgkQG13xyVromsMFPQgAgCHdclM7z3vsMavGtfyCRSP7bRRE
dsN0tVPibzRjEwM+lhudYyHhxgzEP/sXnt1i9qGIe7BzDXW/pStTrA/Z41Vx+t0D
php8jSUWuDZxTiXDJGoF/DULP721ZMO3c3DfZZiH80kIjVXZ++d3ZnFXsFn5NOXz
tHTxaa5ZTLipAn0r2SSOPA/gXTPkuZ20wsB2ACc3KnbY8/idxYbdO2M1sKKbMhC6
4e6ycIkFyE0aimMdSnmOo2vo2B3tHfVi/hKan8lYemyEUySZmzggzkZqCOeefNOb
yhdeP51x+16jKnbg/mJXcgNij2jTreSpfHsRS/0HU8fqx9+oYhQL2VLH1Q==
=Gdcj
-----END PGP SIGNATURE-----

Re: Support text-shadow on for Emacs face

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > I can contact the author of this patch, he doesn't have progress
  > on supporting Linux. I'm thinking whether Emacs-dev team can
  > implement this feature by own design.

If someone wants to implement this for GNU/Linux, that would be good,
and then we could install the MacOS code for the same feature.  But I
can't implore people to write that so we could install the code for
MacOS.  MacOS support is a secondary matter.

   Or maybe considering merge this macOS support patch at first

That would be taking an unwise risk.  What if we installed that MacOS
feature, and months went by and no one wrote a similar feature for
GNU/Linux?  We would be in a bad situation, doing what we shouldn't.

We could delete that MacOS code at that point.  But that is asking
for trouble.  It is wiser to avoid getting into that situation.

That is why our policy is not to install features that work only on a
non-GNU platform.  See the node System Portability in the GNU Coding
Standards, https://www.gnu.org/prep/standards/.

-- 
Dr Richard Stallman
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

Re: Support text-shadow on for Emacs face

[stardiviner]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256


Richard Stallman <rms@gnu.org> writes:

> [[[ To any NSA and FBI agents reading my email: please consider    ]]]
> [[[ whether defending the US Constitution against all enemies,     ]]]
> [[[ foreign or domestic, requires you to follow Snowden's example. ]]]
>
>   > I can contact the author of this patch, he doesn't have progress
>   > on supporting Linux. I'm thinking whether Emacs-dev team can
>   > implement this feature by own design.
>
> If someone wants to implement this for GNU/Linux, that would be good,
> and then we could install the MacOS code for the same feature.  But I
> can't implore people to write that so we could install the code for
> MacOS.  MacOS support is a secondary matter.
>
>    Or maybe considering merge this macOS support patch at first
>
> That would be taking an unwise risk.  What if we installed that MacOS
> feature, and months went by and no one wrote a similar feature for
> GNU/Linux?  We would be in a bad situation, doing what we shouldn't.
>
> We could delete that MacOS code at that point.  But that is asking
> for trouble.  It is wiser to avoid getting into that situation.
>
> That is why our policy is not to install features that work only on a
> non-GNU platform.  See the node System Portability in the GNU Coding
> Standards, https://www.gnu.org/prep/standards/.

Sound reasonable, I leaved a message to the author of that macOS patch. Hope he
can take time to implement it.

- -- 
[ stardiviner ]
       I try to make every word tell the meaning that I want to express.

       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner, Matrix: stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
      
-----BEGIN PGP SIGNATURE-----

iQFIBAEBCAAyFiEE8J9lDX1nSBmJJZFAG13xyVromsMFAl7LovgUHG51bWJjaGls
ZEBnbWFpbC5jb20ACgkQG13xyVromsMTuwgAqbdwXmpJ6BraxN4L0ArwEI5Nuayu
kanHBRIeeakHdB44Zm2/9nEJ58lxnsuTNm2QZXgIL/9xI1FSFacjHkKrJmxM3o1E
9wbXu8mBvO7O79tHhO08HH6+57HDwZ39AD5nvCpIMDSV0ChiXn82X74sVfekK01w
j9uG03fXkf6B+vX/RFxT/ag3GPQipFNGH60/mb9XJo1vPCsDr4OOWrrioGNTVL5A
PBcOX8dQF5GJz/Jm2E2lYu2w8Wp2A+iNjMqw4nF4c4Xpkixl34lfDeaFZZwN/Y2z
FmGf4gVV1qD9ADnZ/IE3rdGALuAfPZ4Dwg5/GAyQKVNOv+uRzAE57i3U8A==
=0V90
-----END PGP SIGNATURE-----