all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Jim Porter <jporterbugs@gmail.com>
To: "Mattias Engdegård" <mattias.engdegard@gmail.com>, 59742@debbugs.gnu.org
Subject: bug#59742: server-tests failures
Date: Thu, 1 Dec 2022 09:24:19 -0800	[thread overview]
Message-ID: <2a636206-dbfa-07da-8961-09abd41e283c@gmail.com> (raw)
In-Reply-To: <58159DD8-85B9-4C23-81B2-2D7EA2005EAE@gmail.com>

On 12/1/2022 7:01 AM, Mattias Engdegård wrote:
> At least the batch-mode tests would cease failing if we just applied the following:
> 
>   (defconst server-tests/can-create-frames-p
> -  (not (memq system-type '(windows-nt ms-dos)))
> +  (and window-system (not (memq system-type '(windows-nt ms-dos))))
> 
> Any reason not to?

These tests pass on GNU/Linux when 'window-system' is nil, so I think 
we'd need a different way to check things.

> Even so, there is still a failure if run interactively (M-x ert), and a created frame isn't removed properly.

I'll see if I can improve the tests when run interactively, though I'm 
not sure that will affect the first part of this bug.






  reply	other threads:[~2022-12-01 17:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-01 15:01 bug#59742: server-tests failures Mattias Engdegård
2022-12-01 17:24 ` Jim Porter [this message]
2022-12-01 17:42   ` Mattias Engdegård
2022-12-02 16:45   ` Mattias Engdegård
2022-12-03 15:20     ` Mattias Engdegård
2022-12-10  7:02       ` Jim Porter
2022-12-10 10:09         ` Mattias Engdegård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2a636206-dbfa-07da-8961-09abd41e283c@gmail.com \
    --to=jporterbugs@gmail.com \
    --cc=59742@debbugs.gnu.org \
    --cc=mattias.engdegard@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.